Merge pull request #232 from humanmade/fix-meta-query-sniff

Support 'relation' element in meta query sniff.

Author: tfrommen

HM/Sniffs/Performance/SlowMetaQuerySniff.php

@@ -136,8 +136,16 @@ protected function check_meta_query_item( int $array_open ) {
 			return;
 		}
 
-		// Otherwise, recurse.
 		foreach ( $elements as $element ) {
+			if ( isset( $element['index_start'] ) ) {
+				$index = $this->strip_quotes( $this->tokens[ $element['index_start'] ]['content'] );
+				if ( strtolower( $index ) === 'relation' ) {
+					// Skip 'relation' element.
+					continue;
+				}
+			}
+
+			// Otherwise, recurse.
 			$this->check_meta_query_item( $element['value_start'] );
 		}
 	}

tests/fixtures/pass/meta-queries.php

@@ -19,6 +19,44 @@
 	],
 ] );
 
+// Specifying relation is OK.
+new WP_Query( [
+	'meta_query' => [
+		'relation' => 'AND',
+		[
+			'key' => 'foo',
+			'compare' => 'EXISTS',
+		],
+		[
+			'key' => 'bar',
+			'compare' => 'NOT EXISTS',
+		],
+	],
+] );
+new WP_Query( [
+	'meta_query' => [
+		'relation' => 'OR',
+		[
+			'key' => 'foo',
+			'compare' => 'NOT EXISTS',
+		],
+		[
+			'key' => 'bar',
+			'compare' => 'EXISTS',
+		],
+	],
+] );
+$relation = 'OR';
+new WP_Query( [
+	'meta_query' => [
+		'relation' => $relation,
+		[
+			'key' => 'foo',
+			'compare' => 'EXISTS',
+		],
+	],
+] );
+
 // Ignores should work.
 new WP_Query( [
 	'meta_query' => [