chore: test percent encoding (#241)

* chore: test percent encoding

* chore: format

---------

Co-authored-by: FL33TW00D <FL33TW00D@users.noreply.github.com>

Author: FL33TW00D

Sources/Hub/Downloader.swift

@@ -346,8 +346,8 @@ extension Downloader: URLSessionDownloadDelegate {
 }
 
 extension FileManager {
-    func moveDownloadedFile(from srcURL: URL, to dstURL: URL) throws {
-        if fileExists(atPath: dstURL.path(percentEncoded: false)) {
+    func moveDownloadedFile(from srcURL: URL, to dstURL: URL, percentEncoded: Bool = false) throws {
+        if fileExists(atPath: dstURL.path(percentEncoded: percentEncoded)) {
             try removeItem(at: dstURL)
         }
 

Tests/HubTests/DownloaderTests.swift

@@ -165,4 +165,28 @@ final class DownloaderTests: XCTestCase {
             throw error
         }
     }
+
+    func testMoveDownloadedFilePercentEncodedFlag() throws {
+        let appSupport = tempDir.appendingPathComponent("Application Support")
+        let destination = appSupport.appendingPathComponent("config.json")
+        let source1 = tempDir.appendingPathComponent("v1.incomplete")
+        let source2 = tempDir.appendingPathComponent("v2.incomplete")
+
+        try FileManager.default.createDirectory(at: appSupport, withIntermediateDirectories: true)
+        try "existing".write(to: destination, atomically: true, encoding: .utf8)
+        try "v1".write(to: source1, atomically: true, encoding: .utf8)
+        try "v2".write(to: source2, atomically: true, encoding: .utf8)
+
+        XCTAssertThrowsError(
+            try FileManager.default.moveDownloadedFile(from: source1, to: destination, percentEncoded: true)
+        ) { error in
+            XCTAssertEqual((error as NSError).code, 516)
+        }
+        XCTAssertEqual(try String(contentsOf: destination), "existing")
+
+        XCTAssertNoThrow(
+            try FileManager.default.moveDownloadedFile(from: source2, to: destination, percentEncoded: false)
+        )
+        XCTAssertEqual(try String(contentsOf: destination), "v2")
+    }
 }