Cleaner name getter

Author: LysandreJik

tests/test_dependencies.py

@@ -27,6 +27,9 @@
 from unittest.mock import patch
 
 import pytest
+from packaging.requirements import Requirement
+
+from lighteval.utils.imports import Extra
 
 
 def purge_lighteval():
@@ -48,7 +51,11 @@ def wrapper(*args, **kwargs):
             purge_lighteval()
 
             def fake(requirement):
-                name = getattr(requirement, "name", getattr(requirement, "value", requirement))
+                name = requirement
+                if isinstance(requirement, Requirement):
+                    name = requirement.name
+                elif isinstance(requirement, Extra):
+                    name = requirement.value
 
                 # Probably a cleaner option here; returns False
                 return False if name in names else (importlib.util.find_spec(name) is not None)