Enhance repo_type_and_id_from_hf_id of hf_api

Author: pulltheflower

src/huggingface_hub/hf_api.py

@@ -236,8 +236,14 @@ def repo_type_and_id_from_hf_id(hf_id: str, hub_url: Optional[str] = None) -> tu
     """
     input_hf_id = hf_id
 
-    hub_url = re.sub(r"https?://", "", hub_url if hub_url is not None else constants.ENDPOINT)
-    is_hf_url = hub_url in hf_id and "@" not in hf_id
+    hub_url = hub_url if hub_url is not None else constants.ENDPOINT
+    hub_url = hub_url.rstrip("/")
+    if hf_id.startswith(hub_url):
+        hf_id = hf_id[len(hub_url):].lstrip("/")
+    elif hf_id.startswith(hub_url.replace("https://", "").replace("http://", "")):
+        # Handle urls like "localhost:8080/hf/model/xxx" 
+        # https://github.com/huggingface/huggingface_hub/issues/3494
+        hf_id = hf_id[len(hub_url.replace("https://", "").replace("http://", "")):].lstrip("/")
 
     HFFS_PREFIX = "hf://"
     if hf_id.startswith(HFFS_PREFIX):  # Remove "hf://" prefix if exists

tests/test_hf_api.py

@@ -2760,6 +2760,9 @@ def test_git_push_end_to_end(self):
 class ParseHFUrlTest(unittest.TestCase):
     def test_repo_type_and_id_from_hf_id_on_correct_values(self):
         possible_values = {
+            "http://localhost:8080/hf/user/id": [None, "user", "id"],
+            "http://localhost:8080/hf/datasets/user/id": ["dataset", "user", "id"],
+            "http://localhost:8080/hf/models/user/id": ["model", "user", "id"],
             "https://huggingface.co/id": [None, None, "id"],
             "https://huggingface.co/user/id": [None, "user", "id"],
             "https://huggingface.co/datasets/user/id": ["dataset", "user", "id"],