Skip to content

Commit 0e4779c

Browse files
committed
Ensure admin server stop() creates a clean shutdown
1 parent 3b1fb7d commit 0e4779c

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

src/admin/admin-server.ts

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -476,16 +476,15 @@ export class AdminServer<Plugins extends { [key: string]: AdminPlugin<any, any>
476476
this.eventEmitter.emit('mock-session-started', plugins, sessionId);
477477
}
478478

479-
stop(): Promise<void> {
479+
async stop(): Promise<void> {
480480
if (!this.server) return Promise.resolve();
481481

482-
return Promise.all([
483-
this.server.destroy(),
484-
].concat(
482+
await Promise.all(
485483
Object.values(this.sessions).map((s) => s.stop())
486-
)).then(() => {
487-
this.server = null;
488-
});
484+
);
485+
486+
await this.server.destroy();
487+
this.server = null;
489488
}
490489

491490
private static baseSchema = gql`

0 commit comments

Comments
 (0)