Explicitly use 127.0.0.1 instead of localhost

Bizarrely, some users seem to have localhost resolving
incorrectly, which blocks server startup. They may still
hit issues after this change, but the result should be
clearer, and may be fixable with pure UI changes later.

Author: pimterry

src/httptoolkit-server.ts

@@ -178,7 +178,7 @@ export class HttpToolkitServer extends events.EventEmitter {
         await this.graphql.start(<any> {
             // Hacky solution that lets us limit the server to only localhost,
             // and override the port from 4000 to something less likely to conflict.
-            port: { port: 45457, host: 'localhost' },
+            port: { port: 45457, host: '127.0.0.1' },
             playground: false,
             cors: { origin: ALLOWED_ORIGINS }
         });

src/index.ts

@@ -74,7 +74,7 @@ export async function runHTK(options: {
     });
     standalone.start({
         port: 45456,
-        host: 'localhost'
+        host: '127.0.0.1'
     });
 
     // Start a HTK server

src/interceptors/fresh-chrome.ts

@@ -52,7 +52,7 @@ export class FreshChrome implements Interceptor {
             // Try to launch Chrome if we're not sure - it'll trigger a config update,
             // and might find a new install.
             browser: (await getChromeBrowserName(this.config)) || 'chrome',
-            proxy: `https://localhost:${proxyPort}`,
+            proxy: `https://127.0.0.1:${proxyPort}`,
             noProxy: [
                 // Don't intercept our warning hiding requests
                 hideWarningServer.host,

src/interceptors/fresh-firefox.ts

@@ -73,17 +73,17 @@ export class FreshFirefox implements Interceptor {
         const browser = await launchBrowser(certCheckServer.checkCertUrl, {
             browser: 'firefox',
             profile: firefoxProfile,
-            proxy: `localhost:${proxyPort}`,
+            proxy: `127.0.0.1:${proxyPort}`,
             // Don't intercept our cert testing requests
             noProxy: certCheckServer.host,
             prefs: _.assign(existingPrefs, {
-                // By default james-launcher only configures HTTP, so we need to add HTTPS:
-                'network.proxy.ssl': '"localhost"',
+                // By default browser-launcher only configures HTTP, so we need to add HTTPS:
+                'network.proxy.ssl': '"127.0.0.1"',
                 'network.proxy.ssl_port': proxyPort,
 
-                // The above james proxy/noProxy settings should do this, but don't seem to
+                // The above browser-launcher proxy/noProxy settings should do this, but don't seem to
                 // reliably overwrite existing values, so we set them explicitly.
-                'network.proxy.http': '"localhost"',
+                'network.proxy.http': '"127.0.0.1"',
                 'network.proxy.http_port': proxyPort,
                 'network.proxy.http.network.proxy.http.no_proxies_on': certCheckServer.host,
 

src/interceptors/terminal/terminal-env-overrides.ts

@@ -16,17 +16,17 @@ export function getTerminalEnvVars(
     currentEnv: { [key: string]: string | undefined }
 ): { [key: string]: string } {
     return {
-        'http_proxy': `http://localhost:${proxyPort}`,
-        'HTTP_PROXY': `http://localhost:${proxyPort}`,
-        'https_proxy': `http://localhost:${proxyPort}`,
-        'HTTPS_PROXY': `http://localhost:${proxyPort}`,
+        'http_proxy': `http://127.0.0.1:${proxyPort}`,
+        'HTTP_PROXY': `http://127.0.0.1:${proxyPort}`,
+        'https_proxy': `http://127.0.0.1:${proxyPort}`,
+        'HTTPS_PROXY': `http://127.0.0.1:${proxyPort}`,
         // Used by global-agent to configure node.js HTTP(S) defaults
-        'GLOBAL_AGENT_HTTP_PROXY': `http://localhost:${proxyPort}`,
+        'GLOBAL_AGENT_HTTP_PROXY': `http://127.0.0.1:${proxyPort}`,
         // Used by some CGI engines to avoid 'httpoxy' vulnerability
-        'CGI_HTTP_PROXY': `http://localhost:${proxyPort}`,
+        'CGI_HTTP_PROXY': `http://127.0.0.1:${proxyPort}`,
         // Used by npm, for versions that don't support HTTP_PROXY etc
-        'npm_config_proxy': `http://localhost:${proxyPort}`,
-        'npm_config_https_proxy': `http://localhost:${proxyPort}`,
+        'npm_config_proxy': `http://127.0.0.1:${proxyPort}`,
+        'npm_config_https_proxy': `http://127.0.0.1:${proxyPort}`,
         // Stop npm warning about having a different 'node' in $PATH
         'npm_config_scripts_prepend_node_path': 'false',