Fix clippy warnings

Author: rusty

src/cache/clear_site_data/mod.rs

@@ -269,7 +269,7 @@ mod test {
         entries.apply_header(&mut res);
 
         let entries = ClearSiteData::from_headers(res)?.unwrap();
-        assert_eq!(entries.wildcard(), true);
+        assert!(entries.wildcard());
         let mut entries = entries.iter();
         assert_eq!(entries.next().unwrap(), &ClearDirective::Cache);
         Ok(())
@@ -281,15 +281,15 @@ mod test {
         res.insert_header("clear-site-data", r#""cookies""#);
 
         let entries = ClearSiteData::from_headers(res)?.unwrap();
-        assert_eq!(entries.wildcard(), false);
+        assert!(!entries.wildcard());
         let mut entries = entries.iter();
         assert_eq!(entries.next().unwrap(), &ClearDirective::Cookies);
 
         let mut res = Response::new(200);
         res.insert_header("clear-site-data", r#""*""#);
 
         let entries = ClearSiteData::from_headers(res)?.unwrap();
-        assert_eq!(entries.wildcard(), true);
+        assert!(entries.wildcard());
         let mut entries = entries.iter();
         assert_eq!(entries.next(), None);
         Ok(())

src/conditional/if_match.rs

@@ -265,7 +265,7 @@ mod test {
         entries.apply_header(&mut res);
 
         let entries = IfMatch::from_headers(res)?.unwrap();
-        assert_eq!(entries.wildcard(), true);
+        assert!(entries.wildcard());
         let mut entries = entries.iter();
         assert_eq!(
             entries.next().unwrap(),

src/conditional/if_none_match.rs

@@ -271,7 +271,7 @@ mod test {
         entries.apply_header(&mut res);
 
         let entries = IfNoneMatch::from_headers(res)?.unwrap();
-        assert_eq!(entries.wildcard(), true);
+        assert!(entries.wildcard());
         let mut entries = entries.iter();
         assert_eq!(
             entries.next().unwrap(),

src/conditional/vary.rs

@@ -266,7 +266,7 @@ mod test {
         entries.apply_header(&mut res);
 
         let entries = Vary::from_headers(res)?.unwrap();
-        assert_eq!(entries.wildcard(), true);
+        assert!(entries.wildcard());
         let mut entries = entries.iter();
         assert_eq!(entries.next().unwrap(), "User-Agent");
         Ok(())

src/content/accept.rs

@@ -91,7 +91,7 @@ impl Accept {
             }
         }
 
-        Ok(Some(Self { entries, wildcard }))
+        Ok(Some(Self { wildcard, entries }))
     }
 
     /// Push a directive into the list of entries.

src/content/accept_encoding.rs

@@ -83,7 +83,7 @@ impl AcceptEncoding {
             }
         }
 
-        Ok(Some(Self { entries, wildcard }))
+        Ok(Some(Self { wildcard, entries }))
     }
 
     /// Push a directive into the list of entries.
@@ -161,7 +161,7 @@ impl Header for AcceptEncoding {
     fn header_value(&self) -> HeaderValue {
         let mut output = String::new();
         for (n, directive) in self.entries.iter().enumerate() {
-            let directive: HeaderValue = directive.clone().into();
+            let directive: HeaderValue = (*directive).into();
             match n {
                 0 => write!(output, "{}", directive).unwrap(),
                 _ => write!(output, ", {}", directive).unwrap(),

src/security/timing_allow_origin.rs

@@ -311,7 +311,7 @@ mod test {
         origins.apply_header(&mut headers);
 
         let origins = TimingAllowOrigin::from_headers(headers)?.unwrap();
-        assert_eq!(origins.wildcard(), true);
+        assert!(origins.wildcard());
         let origin = origins.iter().next().unwrap();
         assert_eq!(origin, &Url::parse("https://example.com")?);
         Ok(())

src/status_code.rs

@@ -425,7 +425,7 @@ impl StatusCode {
     /// If this returns `true` it indicates that the request was received,
     /// continuing process.
     pub fn is_informational(&self) -> bool {
-        let num: u16 = self.clone().into();
+        let num: u16 = (*self).into();
         (100..200).contains(&num)
     }
 
@@ -434,7 +434,7 @@ impl StatusCode {
     /// If this returns `true` it indicates that the request was successfully
     /// received, understood, and accepted.
     pub fn is_success(&self) -> bool {
-        let num: u16 = self.clone().into();
+        let num: u16 = (*self).into();
         (200..300).contains(&num)
     }
 
@@ -443,7 +443,7 @@ impl StatusCode {
     /// If this returns `true` it indicates that further action needs to be
     /// taken in order to complete the request.
     pub fn is_redirection(&self) -> bool {
-        let num: u16 = self.clone().into();
+        let num: u16 = (*self).into();
         (300..400).contains(&num)
     }
 
@@ -452,7 +452,7 @@ impl StatusCode {
     /// If this returns `true` it indicates that the request contains bad syntax
     /// or cannot be fulfilled.
     pub fn is_client_error(&self) -> bool {
-        let num: u16 = self.clone().into();
+        let num: u16 = (*self).into();
         (400..500).contains(&num)
     }
 
@@ -461,7 +461,7 @@ impl StatusCode {
     /// If this returns `true` it indicates that the server failed to fulfill an
     /// apparently valid request.
     pub fn is_server_error(&self) -> bool {
-        let num: u16 = self.clone().into();
+        let num: u16 = (*self).into();
         (500..600).contains(&num)
     }
 

src/trace/trace_context.rs

@@ -30,7 +30,7 @@ use crate::Status;
 ///
 /// assert_eq!(context.trace_id(), trace_id.unwrap());
 /// assert_eq!(context.parent_id(), parent_id.ok());
-/// assert_eq!(context.sampled(), true);
+/// assert!(context.sampled());
 /// #
 /// # Ok(()) }
 /// ```
@@ -56,7 +56,7 @@ impl TraceContext {
     /// let context = TraceContext::new();
     ///
     /// assert_eq!(context.parent_id(), None);
-    /// assert_eq!(context.sampled(), true);
+    /// assert!(context.sampled());
     /// ```
     pub fn new() -> Self {
         Self {
@@ -95,7 +95,7 @@ impl TraceContext {
     ///
     /// assert_eq!(context.trace_id(), trace_id.unwrap());
     /// assert_eq!(context.parent_id(), parent_id.ok());
-    /// assert_eq!(context.sampled(), true);
+    /// assert!(context.sampled());
     /// #
     /// # Ok(()) }
     /// ```
@@ -169,7 +169,7 @@ impl TraceContext {
     /// let mut res = Response::new(200);
     /// res.insert_header("traceparent", "00-00000000000000000000000000000001-0000000000000002-01");
     /// let context = TraceContext::from_headers(&res)?.unwrap();
-    /// assert_eq!(context.sampled(), true);
+    /// assert!(context.sampled());
     /// #
     /// # Ok(()) }
     /// ```
@@ -185,9 +185,9 @@ impl TraceContext {
     /// use http_types::trace::TraceContext;
     ///
     /// let mut context = TraceContext::new();
-    /// assert_eq!(context.sampled(), true);
+    /// assert!(context.sampled());
     /// context.set_sampled(false);
-    /// assert_eq!(context.sampled(), false);
+    /// assert!(!context.sampled());
     /// ```
     pub fn set_sampled(&mut self, sampled: bool) {
         let x = sampled as u8;
@@ -229,7 +229,7 @@ mod test {
         assert_eq!(context.trace_id(), 1);
         assert_eq!(context.parent_id().unwrap(), 3735928559);
         assert_eq!(context.flags, 0);
-        assert_eq!(context.sampled(), false);
+        assert!(!context.sampled());
         Ok(())
     }
 
@@ -239,15 +239,15 @@ mod test {
         assert_eq!(context.version(), 0);
         assert_eq!(context.parent_id(), None);
         assert_eq!(context.flags, 1);
-        assert_eq!(context.sampled(), true);
+        assert!(context.sampled());
     }
 
     #[test]
     fn not_sampled() -> crate::Result<()> {
         let mut headers = crate::headers::Headers::new();
         headers.insert(TRACEPARENT, "00-01-02-00");
         let context = TraceContext::from_headers(&mut headers)?.unwrap();
-        assert_eq!(context.sampled(), false);
+        assert!(!context.sampled());
         Ok(())
     }
 
@@ -256,7 +256,7 @@ mod test {
         let mut headers = crate::headers::Headers::new();
         headers.insert(TRACEPARENT, "00-01-02-01");
         let context = TraceContext::from_headers(&mut headers)?.unwrap();
-        assert_eq!(context.sampled(), true);
+        assert!(context.sampled());
         Ok(())
     }
 }

src/transfer/te.rs

@@ -81,7 +81,7 @@ impl TE {
             }
         }
 
-        Ok(Some(Self { entries, wildcard }))
+        Ok(Some(Self { wildcard, entries }))
     }
 
     /// Push a directive into the list of entries.
@@ -159,7 +159,7 @@ impl Header for TE {
     fn header_value(&self) -> HeaderValue {
         let mut output = String::new();
         for (n, directive) in self.entries.iter().enumerate() {
-            let directive: HeaderValue = directive.clone().into();
+            let directive: HeaderValue = (*directive).into();
             match n {
                 0 => write!(output, "{}", directive).unwrap(),
                 _ => write!(output, ", {}", directive).unwrap(),