Merge pull request #128 from kiron1/client-does-not-send-fragment-of-url

Client must not send fragment of URL

Author: yoshuawuyts

src/client/encode.rs

@@ -30,10 +30,6 @@ impl Encoder {
         let mut buf: Vec<u8> = vec![];
 
         let mut url = req.url().path().to_owned();
-        if let Some(fragment) = req.url().fragment() {
-            url.push('#');
-            url.push_str(fragment);
-        }
         if let Some(query) = req.url().query() {
             url.push('?');
             url.push_str(query);

tests/client.rs

@@ -80,3 +80,21 @@ async fn test_encode_request_with_connect() {
 
     case.assert().await;
 }
+
+// The fragment of an URL is not send to the server, see RFC7230 and RFC3986.
+#[async_std::test]
+async fn test_encode_request_with_fragment() {
+    let case = TestCase::new_client(
+        "fixtures/request-with-fragment.txt",
+        "fixtures/response-with-host.txt",
+    )
+    .await;
+
+    let url = Url::parse("http://example.com/path?query#fragment").unwrap();
+    let req = Request::new(Method::Get, url);
+
+    let res = client::connect(case.clone(), req).await.unwrap();
+    assert_eq!(res.status(), StatusCode::Ok);
+
+    case.assert().await;
+}

tests/fixtures/request-with-fragment.txt

@@ -0,0 +1,4 @@
+GET /path?query HTTP/1.1
+host: example.com
+content-length: 0
+