Also consider default access for polymorphic_base and basic_value

Closes #721

Author: hsutter

regression-tests/test-results/version

@@ -1,5 +1,5 @@
 
-cppfront compiler v0.2.1   Build 8A08:1411
+cppfront compiler v0.2.1   Build 8A08:1847
 Copyright(c) Herb Sutter   All rights reserved
 
 SPDX-License-Identifier: CC-BY-NC-ND-4.0

source/reflect.h

@@ -1216,7 +1216,7 @@ auto polymorphic_base(meta::type_declaration& t) -> void
                     "polymorphic base types may not copy or move; consider a virtual clone() instead");
         if (CPP2_UFCS_0(is_destructor, mf)) {
             has_dtor = true;
-            CPP2_UFCS(require, mf, (CPP2_UFCS_0(is_public, mf) && CPP2_UFCS_0(is_virtual, mf)) 
+            CPP2_UFCS(require, mf, ((CPP2_UFCS_0(is_public, mf) || CPP2_UFCS_0(is_default_access, mf)) && CPP2_UFCS_0(is_virtual, mf)) 
                         || (CPP2_UFCS_0(is_protected, mf) && !(CPP2_UFCS_0(is_virtual, mf))), 
                         "a polymorphic base type destructor must be public and virtual, or protected and nonvirtual");
         }
@@ -1302,7 +1302,7 @@ auto basic_value(meta::type_declaration& t) -> void
         has_default_ctor |= CPP2_UFCS_0(is_default_constructor, mf);
         CPP2_UFCS(require, mf, !(CPP2_UFCS_0(is_protected, mf)) && !(CPP2_UFCS_0(is_virtual, mf)), 
                     "a value type may not have a protected or virtual function");
-        CPP2_UFCS(require, mf, !(CPP2_UFCS_0(is_destructor, mf)) || CPP2_UFCS_0(is_public, mf), 
+        CPP2_UFCS(require, mf, !(CPP2_UFCS_0(is_destructor, mf)) || CPP2_UFCS_0(is_public, mf) || CPP2_UFCS_0(is_default_access, mf), 
                     "a value type may not have a non-public destructor");
     }
 

source/reflect.h2

@@ -604,7 +604,7 @@ polymorphic_base: (inout t: meta::type_declaration) =
                     "polymorphic base types may not copy or move; consider a virtual clone() instead");
         if mf.is_destructor() {
             has_dtor = true;
-            mf.require( (mf.is_public() && mf.is_virtual())
+            mf.require( ((mf.is_public() || mf.is_default_access()) && mf.is_virtual())
                         || (mf.is_protected() && !mf.is_virtual()),
                         "a polymorphic base type destructor must be public and virtual, or protected and nonvirtual");
         }
@@ -740,7 +740,7 @@ basic_value: (inout t: meta::type_declaration) =
         has_default_ctor |= mf.is_default_constructor();
         mf.require( !mf.is_protected() && !mf.is_virtual(),
                     "a value type may not have a protected or virtual function");
-        mf.require( !mf.is_destructor() || mf.is_public(),
+        mf.require( !mf.is_destructor() || mf.is_public() || mf.is_default_access(),
                     "a value type may not have a non-public destructor");
     }