Improve maintainability according to Sonar recommendations.

Author: hrytsenko

src/main/java/com/github/hrytsenko/jsondata/springboot/error/WrapErrorsAspect.java

@@ -30,10 +30,9 @@ class WrapErrorsAspect {
     public Object handle(ProceedingJoinPoint point, WrapErrors config) {
         try {
             return point.proceed();
+        } catch (ServiceException exception) {
+            throw exception;
         } catch (Exception exception) {
-            if (exception instanceof ServiceException) {
-                throw exception;
-            }
             throw new ServiceException.InternalServer(config.value(), exception);
         }
     }

src/test/java/com/github/hrytsenko/jsondata/springboot/error/WrapErrorsAspectTest.java

@@ -36,7 +36,8 @@ void handle_noException() {
         ProceedingJoinPoint sourceJoinPoint = Mockito.mock(ProceedingJoinPoint.class);
         WrapErrors sourceConfig = Mockito.mock(WrapErrors.class);
 
-        aspect.handle(sourceJoinPoint, sourceConfig);
+        Assertions.assertDoesNotThrow(
+                () -> aspect.handle(sourceJoinPoint, sourceConfig));
     }
 
     @Test

src/test/java/com/github/hrytsenko/jsondata/springboot/web/ValidateRequestAspectTest.java

@@ -43,7 +43,8 @@ void validate_success() {
         Mockito.doReturn(sourceSchema)
                 .when(aspect).loadSchema(Mockito.any());
 
-        aspect.handle(sourceJoinPoint, sourceConfig);
+        Assertions.assertDoesNotThrow(
+                () -> aspect.handle(sourceJoinPoint, sourceConfig));
     }
 
     @Test

src/test/java/com/github/hrytsenko/jsondata/springboot/web/ValidateResponseAspectTest.java

@@ -44,7 +44,8 @@ void validate_success() {
         Mockito.doReturn(sourceSchema)
                 .when(aspect).loadSchema(Mockito.any());
 
-        aspect.handle(sourceJoinPoint, sourceConfig);
+        Assertions.assertDoesNotThrow(
+                () -> aspect.handle(sourceJoinPoint, sourceConfig));
     }
 
     @Test