Merge pull request open-mpi#7428 from hjelmn/finally_kill_the_old_cpp_bindings

ompi: remove obsolete c++ bindings

Author: jsquyres

Makefile.ompi-rules

@@ -10,9 +10,6 @@
 #
 
 TRIM_OPTIONS=
-if ! MAN_PAGE_BUILD_MPI_CXX_BINDINGS
-    TRIM_OPTIONS += --nocxx
-endif
 if ! MAN_PAGE_BUILD_MPIFH_BINDINGS
     TRIM_OPTIONS += --nofortran
 endif

README

@@ -347,11 +347,6 @@ Compiler Notes
   version of the Intel 12.1 Linux compiler suite, the problem will go
   away.
 
-- Early versions of the Portland Group 6.0 compiler have problems
-  creating the C++ MPI bindings as a shared library (e.g., v6.0-1).
-  Tests with later versions show that this has been fixed (e.g.,
-  v6.0-5).
-
 - The Portland Group compilers prior to version 7.0 require the
   "-Msignextend" compiler flag to extend the sign bit when converting
   from a shorter to longer integer.  This is is different than other
@@ -370,24 +365,6 @@ Compiler Notes
 - It has been reported that Pathscale 5.0.5 and 6.0.527 compilers
   give an internal compiler error when trying to Open MPI.
 
-- Using the MPI C++ bindings with older versions of the Pathscale
-  compiler on some platforms is an old issue that seems to be a
-  problem when Pathscale uses a back-end GCC 3.x compiler. Here's a
-  proposed solution from the Pathscale support team (from July 2010):
-
-      The proposed work-around is to install gcc-4.x on the system and
-      use the pathCC -gnu4 option. Newer versions of the compiler (4.x
-      and beyond) should have this fixed, but we'll have to test to
-      confirm it's actually fixed and working correctly.
-
-  We don't anticipate that this will be much of a problem for Open MPI
-  users these days (our informal testing shows that not many users are
-  still using GCC 3.x).  Contact Pathscale support if you continue to
-  have problems with Open MPI's C++ bindings.
-
-  Note the MPI C++ bindings have been deprecated by the MPI Forum and
-  may not be supported in future releases.
-
 - As of July 2017, the Pathscale compiler suite apparently has no
   further commercial support, and it does not look like there will be
   further releases.  Any issues discovered regarding building /
@@ -1340,12 +1317,6 @@ MPI FUNCTIONALITY
   Disable the MPI thread level MPI_THREAD_MULTIPLE (it is enabled by
   default).
 
---enable-mpi-cxx
-  Enable building the C++ MPI bindings (default: disabled).
-
-  The MPI C++ bindings were deprecated in MPI-2.2, and removed from
-  the MPI standard in MPI-3.0.
-
 --enable-mpi-java
   Enable building of an EXPERIMENTAL Java MPI interface (disabled by
   default).  You may also need to specify --with-jdk-dir,
@@ -1914,7 +1885,7 @@ each different wrapper compiler (language):
 ompi       Synonym for "ompi-c"; Open MPI applications using the C
            MPI bindings
 ompi-c     Open MPI applications using the C MPI bindings
-ompi-cxx   Open MPI applications using the C or C++ MPI bindings
+ompi-cxx   Open MPI applications using the C MPI bindings
 ompi-fort  Open MPI applications using the Fortran MPI bindings
 ------------------------------------------------------------------------
 

VERSION

@@ -70,12 +70,7 @@ date="Unreleased developer copy"
 # functions over time; these technically did not change the interface
 # because Fortran 77 does not link by parameter type.
 
-# 4. Similar to libmpi, libmpi_cxx's version number refers to the
-# public MPI interfaces.  Note that this version number may or may not
-# be affected by changes to inlined functions in OMPI's
-# header-file-based C++ bindings implementation.
-
-# 5. The ORTE and OPAL libraries will change versions when their
+# 4. The ORTE and OPAL libraries will change versions when their
 # public interfaces change (as relative to the layer(s) above them).
 # None of the ORTE and OPAL interfaces are public to MPI applications,
 # but they are "public" within the OMPI code base and select 3rd party
@@ -85,7 +80,6 @@ date="Unreleased developer copy"
 # format.
 
 libmpi_so_version=0:0:0
-libmpi_cxx_so_version=0:0:0
 libmpi_mpifh_so_version=0:0:0
 libmpi_usempi_tkr_so_version=0:0:0
 libmpi_usempi_ignore_tkr_so_version=0:0:0

config/make_manpage.pl

@@ -17,7 +17,6 @@
 my $package_version;
 my $ompi_date;
 my $opal_date;
-my $cxx = '1';
 my $fortran = '1';
 my $f08 = '1';
 my $input;
@@ -29,7 +28,6 @@
                                   "package-version=s" => \$package_version,
                                   "ompi-date=s" => \$ompi_date,
                                   "opal-date=s" => \$opal_date,
-                                  "cxx!" => \$cxx,
                                   "fortran!" => \$fortran,
                                   "f08!" => \$f08,
                                   "input=s" => \$input,
@@ -58,10 +56,6 @@
 $file =~ s/#OMPI_DATE#/$ompi_date/g;
 $file =~ s/#OPAL_DATE#/$opal_date/g;
 
-if ($cxx == 0) {
-    $file =~ s/\n\.SH C\+\+ Syntax.+?\n\.SH/\n\.SH/s;
-}
-
 if ($fortran == 0) {
     $file =~ s/\n\.SH Fortran Syntax.+?\n\.SH/\n\.SH/s;
 }

config/ompi_config_files.m4

@@ -1,6 +1,6 @@
 # -*- shell-script -*-
 #
-# Copyright (c) 2009-2019 Cisco Systems, Inc.  All rights reserved
+# Copyright (c) 2009-2020 Cisco Systems, Inc.  All rights reserved
 # Copyright (c) 2017-2018 Research Organization for Information Science
 #                         and Technology (RIST). All rights reserved.
 # Copyright (c) 2018      Los Alamos National Security, LLC. All rights
@@ -26,7 +26,6 @@ AC_DEFUN([OMPI_CONFIG_FILES],[
 
         ompi/mpi/c/Makefile
         ompi/mpi/c/profile/Makefile
-        ompi/mpi/cxx/Makefile
         ompi/mpi/fortran/base/Makefile
         ompi/mpi/fortran/mpif-h/Makefile
         ompi/mpi/fortran/mpif-h/profile/Makefile

config/ompi_configure_options.m4

@@ -166,36 +166,6 @@ case "x$enable_mpi_fortran" in
         ;;
 esac
 
-#
-# C++
-#
-
-AC_MSG_CHECKING([if want C++ bindings])
-AC_ARG_ENABLE(mpi-cxx,
-    AC_HELP_STRING([--enable-mpi-cxx],
-                   [enable C++ MPI bindings (default: disabled)]))
-if test "$enable_mpi_cxx" = "yes"; then
-    AC_MSG_RESULT([yes])
-    WANT_MPI_CXX_SUPPORT=1
-else
-    AC_MSG_RESULT([no])
-    WANT_MPI_CXX_SUPPORT=0
-fi
-
-AC_MSG_CHECKING([if want MPI::SEEK_SET support])
-AC_ARG_ENABLE([mpi-cxx-seek],
-    [AC_HELP_STRING([--enable-mpi-cxx-seek],
-                   [enable support for MPI::SEEK_SET, MPI::SEEK_END, and MPI::SEEK_POS in C++ bindings (default: enabled)])])
-if test "$enable_mpi_cxx_seek" != "no" ; then
-  AC_MSG_RESULT([yes])
-  OMPI_WANT_MPI_CXX_SEEK=1
-else
-  AC_MSG_RESULT([no])
-  OMPI_WANT_MPI_CXX_SEEK=0
-fi
-AC_DEFINE_UNQUOTED([OMPI_WANT_MPI_CXX_SEEK], [$OMPI_WANT_MPI_CXX_SEEK],
-    [do we want to try to work around C++ bindings SEEK_* issue?])
-
 # Remove these when we finally kill them once and for all
 AC_ARG_ENABLE([mpi1-compatibility],
     [AC_HELP_STRING([--enable-mpi1-compatibility],