Add propper quoting for AC_ARG_ENABLE and AC_ARG_WITH macros where missing

Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>

Author: cniethammer

config/ompi_configure_options.m4

@@ -46,9 +46,9 @@ AC_ARG_ENABLE([mpi],
 #
 
 AC_MSG_CHECKING([if want compile-time warnings inside of mpi.h])
-AC_ARG_ENABLE(mpi-interface-warning,
-    AS_HELP_STRING([--enable-mpi-interface-warning],
-                   [enable compile-time warnings when deprecated MPI functions are used (default: enabled)]))
+AC_ARG_ENABLE([mpi-interface-warning],
+    [AS_HELP_STRING([--enable-mpi-interface-warning],
+                   [enable compile-time warnings when deprecated MPI functions are used (default: enabled)])])
 if test "$enable_mpi_interface_warning" != "no"; then
     AC_MSG_RESULT([yes])
     OMPI_WANT_MPI_INTERFACE_WARNING=1
@@ -64,9 +64,9 @@ AC_DEFINE_UNQUOTED([OMPI_WANT_MPI_INTERFACE_WARNING], [$OMPI_WANT_MPI_INTERFACE_
 #
 
 AC_MSG_CHECKING([if want sparse process groups])
-AC_ARG_ENABLE(sparse-groups,
-    AS_HELP_STRING([--enable-sparse-groups],
-                   [enable sparse process groups (default: not enabled)]))
+AC_ARG_ENABLE([sparse-groups],
+    [AS_HELP_STRING([--enable-sparse-groups],
+                   [enable sparse process groups (default: not enabled)])])
 if test "$enable_sparse_groups" = "yes"; then
     AC_MSG_RESULT([yes])
     GROUP_SPARSE=1
@@ -83,9 +83,9 @@ AC_DEFINE_UNQUOTED([OMPI_GROUP_SPARSE],$GROUP_SPARSE,
 #
 
 AC_MSG_CHECKING([if want peruse support])
-AC_ARG_ENABLE(peruse,
-    AS_HELP_STRING([--enable-peruse],
-                   [enable PERUSE interface (default: disabled)]))
+AC_ARG_ENABLE([peruse],
+    [AS_HELP_STRING([--enable-peruse],
+                   [enable PERUSE interface (default: disabled)])])
 if test "$enable_peruse" = "yes"; then
     AC_MSG_RESULT([yes])
     WANT_PERUSE=1
@@ -102,9 +102,9 @@ AM_CONDITIONAL(WANT_PERUSE, test "$WANT_PERUSE" = "1")
 # Fortran MPI bindings
 #
 AC_MSG_CHECKING([if want Fortran MPI bindings])
-AC_ARG_ENABLE(mpi-fortran,
-    AS_HELP_STRING([--enable-mpi-fortran],
-                   [specify which Fortran MPI bindings to build: yes, none (or no), best-effort, mpifh (build only mpif.h support), usempi (build mpif.h and the mpi module), or usempif08 (or all, build mpifh, the mpi module, and the mpi_f08 module) (default: "yes" if Fortran compiler found)]))
+AC_ARG_ENABLE([mpi-fortran],
+    [AS_HELP_STRING([--enable-mpi-fortran],
+                   [specify which Fortran MPI bindings to build: yes, none (or no), best-effort, mpifh (build only mpif.h support), usempi (build mpif.h and the mpi module), or usempif08 (or all, build mpifh, the mpi module, and the mpi_f08 module) (default: "yes" if Fortran compiler found)])])
 
 # These are the 4 monotonically-rising values indicating levels of
 # Fortran bindings support.
@@ -202,9 +202,9 @@ AM_CONDITIONAL([OMPI_ENABLE_GREQUEST_EXTENSIONS],[test $ompi_grequest_extensions
 #
 
 AC_MSG_CHECKING([if want run-time MPI parameter checking])
-AC_ARG_WITH(mpi-param-check,
-    AS_HELP_STRING([--with-mpi-param-check(=VALUE)],
-                   [behavior of MPI function parameter checking.  Valid values are: always, never, runtime.  If --with-mpi-param-check is specified with no VALUE argument, it is equivalent to a VALUE of "always"; --without-mpi-param-check is equivalent to "never" (default: runtime).]))
+AC_ARG_WITH([mpi-param-check],
+    [AS_HELP_STRING([--with-mpi-param-check(=VALUE)],
+                   [behavior of MPI function parameter checking.  Valid values are: always, never, runtime.  If --with-mpi-param-check is specified with no VALUE argument, it is equivalent to a VALUE of "always"; --without-mpi-param-check is equivalent to "never" (default: runtime).])])
 mpi_param_check=ompi_mpi_param_check
 if test "$with_mpi_param_check" = "no" || \
    test "$with_mpi_param_check" = "never"; then

config/ompi_contrib.m4

@@ -39,8 +39,8 @@ AC_DEFUN([OMPI_CONTRIB],[
 
     # Option to not build some of the contributed software packages
     AC_ARG_ENABLE([contrib-no-build],
-        AS_HELP_STRING([--enable-contrib-no-build=LIST],
-                        [Comma-separated list of contributed package names that will not be built.  Possible values: ompi_mpicontrib_list.  Example: "--enable-contrib-no-build=foo,bar" will disable building both the "foo" and "bar" contributed software packages (default: none -- i.e., build all possible contrib packages)]))
+        [AS_HELP_STRING([--enable-contrib-no-build=LIST],
+                        [Comma-separated list of contributed package names that will not be built.  Possible values: ompi_mpicontrib_list.  Example: "--enable-contrib-no-build=foo,bar" will disable building both the "foo" and "bar" contributed software packages (default: none -- i.e., build all possible contrib packages)])])
 
     # Parse the list to see what we should not build
     opal_show_subtitle "Configuring contributed software packages"

config/ompi_ext.m4

@@ -40,9 +40,9 @@ AC_DEFUN([OMPI_EXT],[
     # [default -- no option given] = No extensions built
     # --enable-mpi-ext=[,]*EXTENSION[,]*
     #
-    AC_ARG_ENABLE(mpi-ext,
-        AS_HELP_STRING([--enable-mpi-ext[=LIST]],
-                       [Comma-separated list of extensions that should be built.  Possible values: ompi_mpiext_list.  Example: "--enable-mpi-ext=foo,bar" will enable building the MPI extensions "foo" and "bar".  If LIST is empty or the special value "all", then all available MPI extensions will be built (default: all).]))
+    AC_ARG_ENABLE([mpi-ext],
+        [AS_HELP_STRING([--enable-mpi-ext[=LIST]],
+                       [Comma-separated list of extensions that should be built.  Possible values: ompi_mpiext_list.  Example: "--enable-mpi-ext=foo,bar" will enable building the MPI extensions "foo" and "bar".  If LIST is empty or the special value "all", then all available MPI extensions will be built (default: all).])])
 
     # print some nice messages about what we're about to do...
     AC_MSG_CHECKING([for available MPI Extensions])

config/ompi_setup_java.m4

@@ -229,15 +229,15 @@ AC_DEFUN([OMPI_SETUP_JAVA],[
     ompi_java_happy=no
     ompi_javah_happy=no
 
-    AC_ARG_WITH(jdk-dir,
-                AS_HELP_STRING([--with-jdk-dir(=DIR)],
-                               [Location of the JDK header directory.  If you use this option, do not specify --with-jdk-bindir or --with-jdk-headers.]))
-    AC_ARG_WITH(jdk-bindir,
-                AS_HELP_STRING([--with-jdk-bindir(=DIR)],
-                               [Location of the JDK bin directory.  If you use this option, you must also use --with-jdk-headers (and you must NOT use --with-jdk-dir)]))
-    AC_ARG_WITH(jdk-headers,
-                AS_HELP_STRING([--with-jdk-headers(=DIR)],
-                               [Location of the JDK header directory.  If you use this option, you must also use --with-jdk-bindir (and you must NOT use --with-jdk-dir)]))
+    AC_ARG_WITH([jdk-dir],
+                [AS_HELP_STRING([--with-jdk-dir(=DIR)],
+                               [Location of the JDK header directory.  If you use this option, do not specify --with-jdk-bindir or --with-jdk-headers.])])
+    AC_ARG_WITH([jdk-bindir],
+                [AS_HELP_STRING([--with-jdk-bindir(=DIR)],
+                               [Location of the JDK bin directory.  If you use this option, you must also use --with-jdk-headers (and you must NOT use --with-jdk-dir)])])
+    AC_ARG_WITH([jdk-headers],
+                [AS_HELP_STRING([--with-jdk-headers(=DIR)],
+                               [Location of the JDK header directory.  If you use this option, you must also use --with-jdk-bindir (and you must NOT use --with-jdk-dir)])])
 
     # Only setup the compiler if we were requested to
     AS_IF([test "$1" = "yes"],

config/ompi_setup_mpi_java.m4

@@ -29,9 +29,9 @@ dnl Do everything required to setup the Java MPI bindings.
 AC_DEFUN([OMPI_SETUP_JAVA_BINDINGS],[
     opal_show_subtitle "Java MPI bindings"
 
-    AC_ARG_ENABLE(mpi-java,
-        AS_HELP_STRING([--enable-mpi-java],
-                       [enable Java MPI bindings (default: disabled)]))
+    AC_ARG_ENABLE([mpi-java],
+        [AS_HELP_STRING([--enable-mpi-java],
+                       [enable Java MPI bindings (default: disabled)])])
 
     # Find the Java compiler and whatnot.
     # It knows to do very little if $enable_mpi_java!="yes".

config/opal_case_sensitive_fs_setup.m4

@@ -59,9 +59,9 @@ rm -f conf_fs_test.$$ CONF_FS_TEST.$$
 # Now see what the user wants to do...
 #
 AC_MSG_CHECKING([if configuring for case sensitive filesystem])
-AC_ARG_WITH(cs_fs,
-            AS_HELP_STRING([--with-cs-fs],
-                           [Destination FS is case sensitive (default: set to value of the build FS's case sensitivity)]))
+AC_ARG_WITH([cs_fs],
+            [AS_HELP_STRING([--with-cs-fs],
+                           [Destination FS is case sensitive (default: set to value of the build FS's case sensitivity)])])
 
 if test "$with_cs_fs" = "yes"; then
     OPAL_WANT_CS_FS=1

config/opal_check_alt_short_float.m4

@@ -16,9 +16,9 @@ dnl ------------------------------------------------------------
 AC_DEFUN([OPAL_CHECK_ALT_SHORT_FLOAT], [
     AC_CHECK_TYPES(_Float16)
     AC_MSG_CHECKING([if want alternate C type of short float])
-    AC_ARG_ENABLE(alt-short-float,
-        AS_HELP_STRING([--enable-alt-short-float=TYPE],
-                       [Use an alternate C type TYPE of 'short float' if 'short float' is not available on the C compiler. 'short float' is a new C type proposed for the next C language standard in ISO/IEC JTC 1/SC 22 WG 14 (C WG). (default: "_Float16" if available, disabled otherwise)]))
+    AC_ARG_ENABLE([alt-short-float],
+        [AS_HELP_STRING([--enable-alt-short-float=TYPE],
+                       [Use an alternate C type TYPE of 'short float' if 'short float' is not available on the C compiler. 'short float' is a new C type proposed for the next C language standard in ISO/IEC JTC 1/SC 22 WG 14 (C WG). (default: "_Float16" if available, disabled otherwise)])])
     if test "$enable_alt_short_float" = "yes"; then
         AC_MSG_ERROR([--enable-alt-short-float must have an argument.])
     elif test "$enable_alt_short_float" = "no"; then

config/opal_check_visibility.m4

@@ -26,9 +26,9 @@ AC_DEFUN([OPAL_CHECK_VISIBILITY],[
 
     # Check if the compiler has support for visibility, like some
     # versions of gcc, icc Sun Studio cc.
-    AC_ARG_ENABLE(visibility,
-        AS_HELP_STRING([--enable-visibility],
-            [enable visibility feature of certain compilers/linkers (default: enabled)]))
+    AC_ARG_ENABLE([visibility],
+        [AS_HELP_STRING([--enable-visibility],
+            [enable visibility feature of certain compilers/linkers (default: enabled)])])
 
     opal_visibility_define=0
     opal_msg="whether to enable symbol visibility"

config/opal_configure_options.m4

@@ -48,9 +48,9 @@ fi
 #
 
 AC_MSG_CHECKING([if want to run code coverage])
-AC_ARG_ENABLE(coverage,
-              AS_HELP_STRING([--enable-coverage],
-                             [enable code coverage files to be generated]))
+AC_ARG_ENABLE([coverage],
+              [AS_HELP_STRING([--enable-coverage],
+                             [enable code coverage files to be generated])])
 if test "$enable_coverage" = "yes"; then
     if test "$enable_shared" = "yes"; then
         AC_MSG_WARN([Code coverage can run only with static libraries. Please
@@ -73,9 +73,9 @@ fi
 #
 
 AC_MSG_CHECKING([if want to compile with branch probabilities])
-AC_ARG_ENABLE(branch-probabilities,
-              AS_HELP_STRING([--enable-branch-probabilities],
-                             [enable profile arcs and branch probability optimization]))
+AC_ARG_ENABLE([branch-probabilities],
+              [AS_HELP_STRING([--enable-branch-probabilities],
+                             [enable profile arcs and branch probability optimization])])
 if test "$enable_branch_probabilities" = "yes"; then
     AC_MSG_RESULT([yes])
     WANT_BRANCH_PROBABILITIES=1
@@ -90,9 +90,9 @@ fi
 #
 
 AC_MSG_CHECKING([if want to debug memory usage])
-AC_ARG_ENABLE(mem-debug,
-    AS_HELP_STRING([--enable-mem-debug],
-                   [enable memory debugging (not for general MPI users!) (default: disabled)]))
+AC_ARG_ENABLE([mem-debug],
+    [AS_HELP_STRING([--enable-mem-debug],
+                   [enable memory debugging (not for general MPI users!) (default: disabled)])])
 if test "$enable_mem_debug" = "yes"; then
     AC_MSG_RESULT([yes])
     WANT_MEM_DEBUG=1
@@ -108,9 +108,9 @@ AC_DEFINE_UNQUOTED(OPAL_ENABLE_MEM_DEBUG, $WANT_MEM_DEBUG,
 #
 
 AC_MSG_CHECKING([if want to profile memory usage])
-AC_ARG_ENABLE(mem-profile,
-    AS_HELP_STRING([--enable-mem-profile],
-                   [enable memory profiling (not for general MPI users!) (default: disabled)]))
+AC_ARG_ENABLE([mem-profile],
+    [AS_HELP_STRING([--enable-mem-profile],
+                   [enable memory profiling (not for general MPI users!) (default: disabled)])])
 if test "$enable_mem_profile" = "yes"; then
     AC_MSG_RESULT([yes])
     WANT_MEM_PROFILE=1
@@ -126,9 +126,9 @@ AC_DEFINE_UNQUOTED(OPAL_ENABLE_MEM_PROFILE, $WANT_MEM_PROFILE,
 #
 
 AC_MSG_CHECKING([if want developer-level compiler pickyness])
-AC_ARG_ENABLE(picky,
-    AS_HELP_STRING([--enable-picky],
-                   [enable developer-level compiler pickyness when building Open MPI (default: disabled, unless a .git directory is found in the build tree)]))
+AC_ARG_ENABLE([picky],
+    [AS_HELP_STRING([--enable-picky],
+                   [enable developer-level compiler pickyness when building Open MPI (default: disabled, unless a .git directory is found in the build tree)])])
 if test "$enable_picky" = "yes"; then
     AC_MSG_RESULT([yes])
     WANT_PICKY_COMPILER=1
@@ -148,9 +148,9 @@ fi
 #
 
 AC_MSG_CHECKING([if want developer-level debugging code])
-AC_ARG_ENABLE(debug,
-    AS_HELP_STRING([--enable-debug],
-                   [enable developer-level debugging code (not for general MPI users!) (default: disabled)]))
+AC_ARG_ENABLE([debug],
+    [AS_HELP_STRING([--enable-debug],
+                   [enable developer-level debugging code (not for general MPI users!) (default: disabled)])])
 if test "$enable_debug" = "yes"; then
     AC_MSG_RESULT([yes])
     WANT_DEBUG=1
@@ -161,9 +161,9 @@ fi
 
 
 AC_MSG_CHECKING([if want to developer-level timing framework])
-AC_ARG_ENABLE(timing,
-    AS_HELP_STRING([--enable-timing],
-                   [enable developer-level timing code (not for general MPI users!) (default: disabled)]))
+AC_ARG_ENABLE([timing],
+    [AS_HELP_STRING([--enable-timing],
+                   [enable developer-level timing code (not for general MPI users!) (default: disabled)])])
 if test "$enable_timing" = "yes"; then
     AC_MSG_RESULT([yes])
     WANT_TIMING=1
@@ -185,18 +185,18 @@ fi
 AC_DEFINE_UNQUOTED(OPAL_ENABLE_DEBUG, $WANT_DEBUG,
     [Whether we want developer-level debugging code or not])
 
-AC_ARG_ENABLE(debug-symbols,
-    AS_HELP_STRING([--disable-debug-symbols],
-        [Disable adding compiler flags to enable debugging symbols if --enable-debug is specified.  For non-debugging builds, this flag has no effect.]))
+AC_ARG_ENABLE([debug-symbols],
+    [AS_HELP_STRING([--disable-debug-symbols],
+        [Disable adding compiler flags to enable debugging symbols if --enable-debug is specified.  For non-debugging builds, this flag has no effect.])])
 
 #
 # Do we want to install all of OPAL/ORTE and OMPI's header files?
 #
 
 AC_MSG_CHECKING([if want to install project-internal header files])
-AC_ARG_WITH(devel-headers,
-    AS_HELP_STRING([--with-devel-headers],
-                   [normal MPI users/applications do not need this (mpi.h and mpif.h are ALWAYS installed).  Developer headers are only necessary for MCA module authors (default: disabled).]))
+AC_ARG_WITH([devel-headers],
+    [AS_HELP_STRING([--with-devel-headers],
+                   [normal MPI users/applications do not need this (mpi.h and mpif.h are ALWAYS installed).  Developer headers are only necessary for MCA module authors (default: disabled).])])
 if test "$with_devel_headers" = "yes"; then
     AC_MSG_RESULT([yes])
     WANT_INSTALL_HEADERS=1
@@ -232,9 +232,9 @@ AC_DEFINE_UNQUOTED([OPAL_WANT_PRETTY_PRINT_STACKTRACE],
 #
 
 AC_MSG_CHECKING([if want pty support])
-AC_ARG_ENABLE(pty-support,
-    AS_HELP_STRING([--enable-pty-support],
-                   [Enable/disable PTY support for STDIO forwarding.  (default: enabled)]))
+AC_ARG_ENABLE([pty-support],
+    [AS_HELP_STRING([--enable-pty-support],
+                   [Enable/disable PTY support for STDIO forwarding.  (default: enabled)])])
 if test "$enable_pty_support" = "no" ; then
     AC_MSG_RESULT([no])
     OPAL_ENABLE_PTY_SUPPORT=0
@@ -251,9 +251,9 @@ AC_DEFINE_UNQUOTED([OPAL_ENABLE_PTY_SUPPORT], [$OPAL_ENABLE_PTY_SUPPORT],
 #
 
 AC_MSG_CHECKING([if want weak symbol support])
-AC_ARG_ENABLE(weak-symbols,
-    AS_HELP_STRING([--enable-weak-symbols],
-                   [use weak symbols, if available (default: enabled)]))
+AC_ARG_ENABLE([weak-symbols],
+    [AS_HELP_STRING([--enable-weak-symbols],
+                   [use weak symbols, if available (default: enabled)])])
 if test "$enable_weak_symbols" != "no"; then
     AC_MSG_RESULT([yes])
     WANT_WEAK_SYMBOLS=1

config/opal_functions.m4

@@ -576,8 +576,8 @@ AC_DEFUN([OPAL_WITH_OPTION_MIN_MAX_VALUE], [
     max_value=[$2]
     AC_MSG_CHECKING([maximum length of ]m4_translit($1, [_], [ ]))
     AC_ARG_WITH([max-]m4_translit($1, [_], [-]),
-        AS_HELP_STRING([--with-max-]m4_translit($1, [_], [-])[=VALUE],
-                       [maximum length of ]m4_translit($1, [_], [ ])[s.  VALUE argument has to be specified (default: [$2]).]))
+        [AS_HELP_STRING([--with-max-]m4_translit($1, [_], [-])[=VALUE],
+                       [maximum length of ]m4_translit($1, [_], [ ])[s.  VALUE argument has to be specified (default: [$2]).])])
     if test ! -z "$with_max_[$1]" && test "$with_max_[$1]" != "no" ; then
         # Ensure it's a number (hopefully an integer!), and >0
         expr $with_max_[$1] + 1 > /dev/null 2> /dev/null