Skip to content

Commit b122090

Browse files
committed
pml/ob1: fix some typos that got missed on Dec push
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
1 parent 2212db7 commit b122090

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

ompi/mca/pml/ob1/pml_ob1.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
* Copyright (c) 2015 FUJITSU LIMITED. All rights reserved.
2121
* Copyright (c) 2018 Sandia National Laboratories
2222
* All rights reserved.
23+
* Copyright (c) 2018-2019 Triad National Security, LLC. All rights
24+
* reseved.
2325
* $COPYRIGHT$
2426
*
2527
* Additional copyrights may follow
@@ -793,7 +795,7 @@ void mca_pml_ob1_process_pending_packets(mca_bml_base_btl_t* bml_btl)
793795
mca_pml_ob1_pckt_pending_t *pckt;
794796
int32_t rc, max = (int32_t) opal_list_get_size (&mca_pml_ob1.pckt_pending);
795797

796-
for (int32_t i = 0; i < max ; +i) {
798+
for (int32_t i = 0; i < max ; ++i) {
797799
mca_bml_base_btl_t *send_dst = NULL;
798800
OPAL_THREAD_SCOPED_LOCK(&mca_pml_ob1.lock, {
799801
pckt = (mca_pml_ob1_pckt_pending_t*)

ompi/mca/pml/ob1/pml_ob1.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
* reserved.
1717
* Copyright (c) 2015 Research Organization for Information Science
1818
* and Technology (RIST). All rights reserved.
19-
* Copyright (c) 2018 Triad National Security, LLC. All rights
19+
* Copyright (c) 2018-2019 Triad National Security, LLC. All rights
2020
* reserved.
2121
* $COPYRIGHT$
2222
*
@@ -252,10 +252,12 @@ static inline void mca_pml_ob1_add_to_pending (ompi_proc_t *proc, mca_bml_base_b
252252
mca_pml_ob1_pckt_pending_t *pckt;
253253

254254
MCA_PML_OB1_PCKT_PENDING_ALLOC(pckt);
255-
assert (sizeof (pckt->hdr) <= hdr_size);
255+
assert (sizeof (pckt->hdr) >= hdr_size);
256256
pckt->proc = proc;
257257
pckt->order = order;
258258
pckt->hdr_size = hdr_size;
259+
pckt->bml_btl = bml_btl;
260+
memcpy (&pckt->hdr, hdr, hdr_size);
259261
OPAL_THREAD_SCOPED_LOCK(&mca_pml_ob1.lock, {
260262
opal_list_append(&mca_pml_ob1.pckt_pending, &pckt->super.super);
261263
});

ompi/mca/pml/ob1/pml_ob1_sendreq.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
* Copyright (c) 2016 Research Organization for Information Science
2020
* and Technology (RIST). All rights reserved.
2121
* Copyright (c) 2018 FUJITSU LIMITED. All rights reserved.
22+
* Copyright (c) 2018-2019 Triad National Security, LLC. All rights
23+
* reserved.
2224
* $COPYRIGHT$
2325
*
2426
* Additional copyrights may follow
@@ -761,11 +763,11 @@ int mca_pml_ob1_send_request_start_rdma( mca_pml_ob1_send_request_t* sendreq,
761763

762764
/* build match header */
763765
hdr = (mca_pml_ob1_hdr_t *) des->des_segments->seg_addr.pval;
764-
if (MCA_PML_OB1_PROC_REQUIRES_EXT_MATCH(sendreq->ob1_proc)) {
766+
if (need_ext_match) {
765767
hdr_rget = &hdr->hdr_ext_rget.hdr_rget;
766768
mca_pml_ob1_cid_hdr_prepare (&hdr->hdr_cid, sendreq->req_send.req_base.req_comm);
767769
} else {
768-
hdr_rget = &hdr->hdr_ext_rget.hdr_rget;
770+
hdr_rget = &hdr->hdr_rget;
769771
}
770772

771773
/* TODO -- Add support for multiple segments for get */

0 commit comments

Comments
 (0)