CON-3113 - Implementation of probes for NFS deployments #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AnushaY1916 <anuanusha471@gmail.com>
Signed-off-by: AnushaY1916 <anuanusha471@gmail.com>
AnushaY1916
requested review from
datamattsson,
dileepds,
pavansshanbhag,
raunakkumar,
rohit-balakrishna,
sijeesh and
suneeth51
as code owners
…to new-nfsprobe
Signed-off-by: AnushaY1916 <anuanusha471@gmail.com>
Signed-off-by: AnushaY1916 <anuanusha471@gmail.com>
Signed-off-by: AnushaY1916 <anuanusha471@gmail.com>
Signed-off-by: AnushaY1916 <anuanusha471@gmail.com>
rohit-balakrishna
approved these changes
Mar 24, 2025
dileepds
approved these changes
Apr 9, 2025
datamattsson
requested changes
Apr 9, 2025
Collaborator
datamattsson
left a comment
datamattsson
left a comment
There was a problem hiding this comment.
Are we leaving residual serviceAccounts, roles and roleBindings around? I can't see these being pruned in deleteNFSResources.
datamattsson
requested changes
Apr 11, 2025
pkg/flavor/kubernetes/nfs.go
Outdated
| livenessProbe := &core_v1.Probe{ | ||
| ProbeHandler: core_v1.ProbeHandler{ | ||
| Exec: &core_v1.ExecAction{ | ||
| Command: []string{"/bin/sh", "/nfsHealthCheck.sh", "3", name, nfsNamespace}, |
Collaborator
There was a problem hiding this comment.
Can we maintain a hash of actions for the 1, 2 and 3 in the script instead? I find this numbering very counter-intuitive. nfsNamespace is not being used in the script and should be removed.
Signed-off-by: AnushaY1916 <anuanusha471@gmail.com>
Signed-off-by: AnushaY1916 <anuanusha471@gmail.com>
Signed-off-by: Michael Mattsson <michael.mattsson@gmail.com>
datamattsson
approved these changes
Apr 20, 2025
Collaborator
datamattsson
left a comment
datamattsson
left a comment
There was a problem hiding this comment.
LGTM, can we please work #437 next?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.