Skip to content

Commit 29360e0

Browse files
Alex ZherdevKent C. Dodds
authored andcommitted
fix(rollup): properly handle no externals (#84)
1 parent 03ad7bf commit 29360e0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/config/rollup.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ if (isPreact) {
8080
const externalPattern = new RegExp(`^(${external.join('|')})($|/)`)
8181

8282
function externalPredicate(id) {
83-
const isDep = externalPattern.test(id)
83+
const isDep = external.length > 0 && externalPattern.test(id)
8484
if (umd) {
8585
// for UMD, we want to bundle all non-peer deps
8686
return isDep

0 commit comments

Comments
 (0)