wait for the process to be terminated (#17)

Author: DomAmato

Hologram/Network/Modem/ModemMode/PPP.py

@@ -78,7 +78,10 @@ def __shut_down_existing_ppp_session(self):
         for pid in pid_list:
             self.logger.info('Killing pid %s that currently have an active PPP session',
                              pid)
-            psutil.Process(pid).terminate()
+            process = psutil.Process(pid)
+            process.terminate()
+            # Wait at least 10 seconds for the process to terminate
+            process.wait(10)
 
     def __check_for_existing_ppp_sessions(self):
 

scripts/hologram_modem.py

@@ -73,7 +73,9 @@ def run_modem_disconnect(args):
         if 'pppd' in pinfo['name']:
             print('Found existing PPP session on pid: %s' % pinfo['pid'])
             print('Killing pid %s now' % pinfo['pid'])
-            psutil.Process(pinfo['pid']).terminate()
+            process = psutil.Process(pinfo['pid'])
+            process.terminate()
+            process.wait()
 
 def run_modem_signal(args):
     cloud = CustomCloud(None, network='cellular')

scripts/hologram_network.py

@@ -40,7 +40,9 @@ def run_network_disconnect(args):
         if 'pppd' in pinfo['name']:
             print('Found existing PPP session on pid: %s' % pinfo['pid'])
             print('Killing pid %s now' % pinfo['pid'])
-            psutil.Process(pinfo['pid']).terminate()
+            process = psutil.Process(pinfo['pid'])
+            process.terminate()
+            process.wait()
 
 _run_handlers = {
     'network_connect': run_network_connect,