Skip to content

Configure String Value to Decimal Places of Step #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Configure String Value to Decimal Places of Step #87

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
504748c
Configure String Value to Decimal Places of Step
m-mcardle Jun 14, 2022
6cbe7de
Set correct number of decimal places on initial values
m-mcardle Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions NumericInput/NumericInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default class NumericInput extends Component {
this.state = {
value: noInitSent ? props.value ? props.value : 0 : props.initValue,
lastValid: noInitSent ? props.value ? props.value : 0 : props.initValue,
stringValue: (noInitSent ? props.value ? props.value : 0 : props.initValue).toString(),
stringValue: (noInitSent ? props.value ? props.value : 0 : props.initValue).toFixed(this.decimalCount(props.step)),
}
this.ref = null
}
Expand All @@ -33,6 +33,13 @@ export default class NumericInput extends Component {
}
}

decimalCount = (num) => {
const numStr = String(num);
if (numStr.includes('.')) {
return numStr.split('.')[1].length;
};
return 0;
}
updateBaseResolution = (width, height) => {
calcSize = create({ width, height })
}
Expand All @@ -41,11 +48,11 @@ export default class NumericInput extends Component {
if (this.props.maxValue === null || (value + this.props.step < this.props.maxValue)) {
value = (value + this.props.step).toFixed(12)
value = this.props.valueType === 'real' ? parseFloat(value) : parseInt(value)
this.setState({ value, stringValue: value.toString() })
this.setState({ value, stringValue: value.toFixed(this.decimalCount(this.props.step)) })
} else if (this.props.maxValue !== null) {
this.props.onLimitReached(true, 'Reached Maximum Value!')
value = this.props.maxValue
this.setState({ value, stringValue: value.toString() })
this.setState({ value, stringValue: value.toFixed(this.decimalCount(this.props.step)) })

}
if (value !== this.props.value)
Expand All @@ -62,7 +69,7 @@ export default class NumericInput extends Component {
}
if (value !== this.props.value)
this.props.onChange && this.props.onChange(Number(value))
this.setState({ value, stringValue: value.toString() })
this.setState({ value, stringValue: value.toFixed(this.decimalCount(this.props.step)) })
}
isLegalValue = (value, mReal, mInt) => value === '' || (((this.props.valueType === 'real' && mReal(value)) || (this.props.valueType !== 'real' && mInt(value))) && (this.props.maxValue === null || (parseFloat(value) <= this.props.maxValue)) && (this.props.minValue === null || (parseFloat(value) >= this.props.minValue)))

Expand Down