feat: implement account creation with EVM-style alias transaction #922

MonaaEid · 2025-11-28T21:10:59Z

This pull request introduces:

An example demonstrating how to create an account using an EVM-style alias (EVM address).
The script guides users through generating an ECDSA key pair, creating an account with an EVM alias, and displaying the resulting account information.

Related issue(s):
Fixes #918

Checklist

Create examples/account/create_account_with_alias_transaction.py
Update CHANGELOG
Documented (Code comments)
Tested

…mple Signed-off-by: MonaaEid <monaa_eid@hotmail.com>

github-actions · 2025-11-28T21:11:16Z

Hi, this is MergeConflictBot.
Your pull request cannot be merged because it contains merge conflicts.

Please resolve these conflicts locally and push the changes.

To assist you, please read:

Thank you for contributing!

From the Hiero Python SDK Team

github-actions · 2025-11-28T21:11:41Z

Hi, this is WorkflowBot.
Your pull request cannot be merged as it is not passing all our workflow checks.
Please click on each check to review the logs and resolve issues so all checks pass.
To help you:

DCO signing guide
Changelog guide
Merge conflicts guide
Rebase guide
Testing guide
Discord
Community Calls
Thank you for contributing!
From the Hiero Python SDK Team

Signed-off-by: MontyPokemon <59332150+MonaaEid@users.noreply.github.com>

Copilot

Pull request overview

This PR adds a new example demonstrating how to create a Hedera account using an EVM-style alias derived from an ECDSA key pair. The example guides users through generating an ECDSA key, deriving an EVM address, and creating an account with that alias.

Key changes:

New example script showing EVM alias account creation workflow
CHANGELOG entries for the new example and unrelated bot workflow

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File	Description
examples/account/create_account_with_alias_transaction.py	Implements the EVM alias account creation example with step-by-step guidance
CHANGELOG.md	Documents the new example addition under the Unreleased section

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-28T21:20:53Z

CHANGELOG.md

 - Add example demonstrating usage of `CustomFeeLimit` in `examples/transaction/custom_fee_limit.py`
 - Added `.github/workflows/merge-conflict-bot.yml` to automatically detect and notify users of merge conflicts in Pull Requests.
+- Added `.github/workflows/bot-office-hours.yml` to automate the Weekly Office Hour Reminder.  
+- feat: Implement account creation with EVM-style alias transaction example.


The changelog entry format is inconsistent with other entries in the file. Most entries follow the pattern "Add example demonstrating..." or "Added..." without the "feat:" prefix. For consistency, consider changing to: "Add example demonstrating account creation with EVM-style alias transaction in examples/account/create_account_with_alias_transaction.py"

Suggested change

- feat: Implement account creation with EVM-style alias transaction example.

- Add example demonstrating account creation with EVM-style alias transaction in `examples/account/create_account_with_alias_transaction.py`

Copilot · 2025-11-28T21:20:53Z

examples/account/account_create_transaction_evm_alias.py

+
+load_dotenv()
+network_name = os.getenv('NETWORK', 'testnet').lower()
+key_type = os.getenv('KEY_TYPE', 'ecdsa')


The key_type variable is defined but never used in the code. It should either be removed or utilized in the example.

Copilot · 2025-11-28T21:20:54Z

examples/account/account_create_transaction_evm_alias.py

+# uv run examples/account/create_account_with_alias_transaction.py
+# python examples/account/create_account_with_alias_transaction.py
+"""
+Example: Create an account using an EVM-style alias (evm_address).


The docstring is minimal compared to other examples in this directory (e.g., account_create_transaction.py). Consider adding a more comprehensive module-level docstring that includes:

A detailed description of what the example demonstrates

The specific features being showcased (ECDSA keys, EVM alias, etc.)

Usage instructions (how to run with python/uv)

Required environment variables

Expected outcomes

This would make the example more accessible and educational for users.

Suggested change

Example: Create an account using an EVM-style alias (evm_address).

Example: Create a Hedera account using an EVM-style alias (evm_address).

This example demonstrates how to:

- Generate a new ECDSA key pair.

- Derive an EVM-compatible address (alias) from the public key.

- Create a new Hedera account using the EVM address as an alias.

- Query and display the account information, including the contract account ID (alias).

Features showcased:

- ECDSA key generation

- EVM aliasing (evm_address)

- Account creation with alias

- Account info query

Usage:

uv run examples/account/create_account_with_alias_transaction.py

python examples/account/create_account_with_alias_transaction.py

Required environment variables (set in a .env file or your environment):

- OPERATOR_ID: The account ID of the operator (payer) account.

- OPERATOR_KEY: The private key of the operator account.

- NETWORK: (Optional) The Hedera network to use (default: testnet).

- KEY_TYPE: (Optional) The key type to use for the new account (default: ecdsa).

Expected outcome:

- A new Hedera account is created with an EVM-style alias.

- The script outputs the new account ID, EVM address, and detailed account information.

- The contract account ID (alias) is displayed if available.

Copilot · 2025-11-28T21:20:54Z

examples/account/account_create_transaction_evm_alias.py

+key_type = os.getenv('KEY_TYPE', 'ecdsa')
+
+def setup_client():
+    """Setup Client """


The docstring "Setup Client " is incomplete and lacks detail. Following the pattern in account_create_transaction.py, consider expanding this to document:

What the function does (connects to network, configures operator)

Return type and what's returned

Exceptions that may be raised

Required environment variables

Also note the trailing space in "Client " which should be removed.

Suggested change

"""Setup Client """

"""

Set up and return a Hedera Client configured for the specified network and operator.

This function connects to the Hedera network specified by the NETWORK environment variable,

and configures the client with the operator account and private key from the environment.

Returns:

Client: A configured Hedera Client instance.

Raises:

SystemExit: If required environment variables are missing or invalid.

Required Environment Variables:

- OPERATOR_ID: The account ID of the operator (payer) account.

- OPERATOR_KEY: The private key of the operator account.

- NETWORK: The Hedera network to connect to (e.g., 'testnet', 'mainnet', 'previewnet'). Defaults to 'testnet'.

- KEY_TYPE: The type of key to use (e.g., 'ecdsa'). Defaults to 'ecdsa'.

"""

Copilot · 2025-11-28T21:20:54Z

examples/account/account_create_transaction_evm_alias.py

+key_type = os.getenv('KEY_TYPE', 'ecdsa')
+
+def setup_client():
+    """Setup Client """


Trailing whitespace after "Client".

Suggested change

"""Setup Client """

"""Setup Client"""

Copilot · 2025-11-28T21:20:54Z

examples/account/create_account_with_alias_transaction.py

+        public_key = private_key.public_key()
+        evm_address = public_key.to_evm_address()
+        if evm_address is None:
+            print("❌ Error generating ECDSA key pair")


The error message "Error generating ECDSA key pair" is misleading. The error occurs when to_evm_address() returns None, not during key generation (which happens on line 64). Consider a more accurate message like "Failed to generate EVM address from ECDSA public key".

Suggested change

print("❌ Error generating ECDSA key pair")

print("❌ Failed to generate EVM address from ECDSA public key")

Copilot · 2025-11-28T21:20:55Z

CHANGELOG.md


 - Add example demonstrating usage of `CustomFeeLimit` in `examples/transaction/custom_fee_limit.py`
 - Added `.github/workflows/merge-conflict-bot.yml` to automatically detect and notify users of merge conflicts in Pull Requests.
+- Added `.github/workflows/bot-office-hours.yml` to automate the Weekly Office Hour Reminder.  


Trailing whitespace at the end of the line.

Suggested change

- Added `.github/workflows/bot-office-hours.yml` to automate the Weekly Office Hour Reminder.

- Added `.github/workflows/bot-office-hours.yml` to automate the Weekly Office Hour Reminder.

…mple Signed-off-by: MontyPokemon <59332150+MonaaEid@users.noreply.github.com>

…mple Signed-off-by: MonaaEid <monaa_eid@hotmail.com>

manishdait · 2025-11-29T09:20:45Z

Hi @MonaaEid, Thanks for PR!

Could you please rename the example file to account_create_transaction_evm_alias.py? This will keep it consistent with our current file naming scheme.

…mple Signed-off-by: MontyPokemon <59332150+MonaaEid@users.noreply.github.com>

MonaaEid · 2025-11-29T12:30:43Z

Hi @manishdait, please check

examples/account/account_create_transaction_evm_alias.py

manishdait

Hi @MonaaEid, just a few changes. The rest of the PR looks good.

…mple Signed-off-by: MontyPokemon <59332150+MonaaEid@users.noreply.github.com>

feat: implement account creation with EVM-style alias transaction exa…

3418206

…mple Signed-off-by: MonaaEid <monaa_eid@hotmail.com>

MonaaEid changed the title ~~feat: implement account creation with EVM-style alias transaction exa…~~ feat: implement account creation with EVM-style alias transaction Nov 28, 2025

Merge branch 'main' into 918-create_account_with_alias_transaction

a2a2087

Signed-off-by: MontyPokemon <59332150+MonaaEid@users.noreply.github.com>

MonaaEid marked this pull request as ready for review November 28, 2025 21:18

Copilot AI review requested due to automatic review settings November 28, 2025 21:18

Copilot started reviewing on behalf of MonaaEid November 28, 2025 21:18 View session

Copilot finished reviewing on behalf of MonaaEid November 28, 2025 21:20

Copilot AI reviewed Nov 28, 2025

View reviewed changes

MonaaEid and others added 3 commits November 29, 2025 00:06

feat: implement account creation with EVM-style alias transaction exa…

d08f2b4

…mple Signed-off-by: MontyPokemon <59332150+MonaaEid@users.noreply.github.com>

feat: implement account creation with EVM-style alias transaction exa…

90248d9

…mple Signed-off-by: MontyPokemon <59332150+MonaaEid@users.noreply.github.com>

feat: implement account creation with EVM-style alias transaction exa…

5152e6e

…mple Signed-off-by: MonaaEid <monaa_eid@hotmail.com>

feat: implement account creation with EVM-style alias transaction exa…

c8ac3aa

…mple Signed-off-by: MontyPokemon <59332150+MonaaEid@users.noreply.github.com>

Merge branch 'main' into 918-create_account_with_alias_transaction

1c49004

manishdait reviewed Nov 30, 2025

View reviewed changes

examples/account/account_create_transaction_evm_alias.py Outdated Show resolved Hide resolved

manishdait reviewed Nov 30, 2025

View reviewed changes

examples/account/account_create_transaction_evm_alias.py Outdated Show resolved Hide resolved

manishdait requested changes Nov 30, 2025

View reviewed changes

feat: implement account creation with EVM-style alias transaction exa…

c10d99d

…mple Signed-off-by: MontyPokemon <59332150+MonaaEid@users.noreply.github.com>

MonaaEid requested a review from manishdait December 1, 2025 14:38

Merge branch 'main' into 918-create_account_with_alias_transaction

3a22283

	- feat: Implement account creation with EVM-style alias transaction example.
	- Add example demonstrating account creation with EVM-style alias transaction in `examples/account/create_account_with_alias_transaction.py`

-Example: Create an account using an EVM-style alias (evm_address).
+Example: Create a Hedera account using an EVM-style alias (evm_address).
+This example demonstrates how to:
+- Generate a new ECDSA key pair.
+- Derive an EVM-compatible address (alias) from the public key.
+- Create a new Hedera account using the EVM address as an alias.
+- Query and display the account information, including the contract account ID (alias).
+Features showcased:
+- ECDSA key generation
+- EVM aliasing (evm_address)
+- Account creation with alias
+- Account info query
+Usage:
+    uv run examples/account/create_account_with_alias_transaction.py
+    python examples/account/create_account_with_alias_transaction.py
+Required environment variables (set in a .env file or your environment):
+- OPERATOR_ID: The account ID of the operator (payer) account.
+- OPERATOR_KEY: The private key of the operator account.
+- NETWORK: (Optional) The Hedera network to use (default: testnet).
+- KEY_TYPE: (Optional) The key type to use for the new account (default: ecdsa).
+Expected outcome:
+- A new Hedera account is created with an EVM-style alias.
+- The script outputs the new account ID, EVM address, and detailed account information.
+- The contract account ID (alias) is displayed if available.

-    """Setup Client """
+    """
+    Set up and return a Hedera Client configured for the specified network and operator.
+    This function connects to the Hedera network specified by the NETWORK environment variable,
+    and configures the client with the operator account and private key from the environment.
+    Returns:
+        Client: A configured Hedera Client instance.
+    Raises:
+        SystemExit: If required environment variables are missing or invalid.
+    Required Environment Variables:
+        - OPERATOR_ID: The account ID of the operator (payer) account.
+        - OPERATOR_KEY: The private key of the operator account.
+        - NETWORK: The Hedera network to connect to (e.g., 'testnet', 'mainnet', 'previewnet'). Defaults to 'testnet'.
+        - KEY_TYPE: The type of key to use (e.g., 'ecdsa'). Defaults to 'ecdsa'.
+    """

	print("❌ Error generating ECDSA key pair")
	print("❌ Failed to generate EVM address from ECDSA public key")

	- Added `.github/workflows/bot-office-hours.yml` to automate the Weekly Office Hour Reminder.
	- Added `.github/workflows/bot-office-hours.yml` to automate the Weekly Office Hour Reminder.

feat: implement account creation with EVM-style alias transaction #922

Are you sure you want to change the base?

feat: implement account creation with EVM-style alias transaction #922

Conversation

MonaaEid commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

manishdait commented Nov 29, 2025

Uh oh!

MonaaEid commented Nov 29, 2025

Uh oh!

Uh oh!

Uh oh!

manishdait left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MonaaEid commented Nov 28, 2025 •

edited

Loading