Skip to content

Conversation

@emiliyank
Copy link
Contributor

Description:
Add missing fields for AccountUpdateTransaction class

Fixes #801

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@emiliyank emiliyank changed the title add fileds to AccountUpdateTransaction feat: Add missing fields for AccountUpdateTransaction Nov 20, 2025
@emiliyank emiliyank force-pushed the feat/add-missing-fields-for-account-update-transaction branch from e786992 to 3208cb7 Compare November 20, 2025 14:57
@nadineloepfe
Copy link
Contributor

LGTM, quick change of Changelog and then that's ready to go! Thank you

@emiliyank emiliyank force-pushed the feat/add-missing-fields-for-account-update-transaction branch 3 times, most recently from 6cae2fa to 867f745 Compare November 21, 2025 08:44
@exploreriii
Copy link
Contributor

Request review @manishdait @nadineloepfe if able

manishdait
manishdait previously approved these changes Nov 22, 2025
Copy link
Contributor

@manishdait manishdait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@exploreriii
Copy link
Contributor

Thanks Manish. @emiliyank please rebase when able 👍

nadineloepfe
nadineloepfe previously approved these changes Nov 24, 2025
Copy link
Contributor

@nadineloepfe nadineloepfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase please and then that's ready to go @emiliyank

@emiliyank emiliyank dismissed stale reviews from nadineloepfe and manishdait via 787bc00 November 24, 2025 15:25
@emiliyank emiliyank force-pushed the feat/add-missing-fields-for-account-update-transaction branch 2 times, most recently from 787bc00 to 82ba211 Compare November 24, 2025 15:26
@emiliyank emiliyank force-pushed the feat/add-missing-fields-for-account-update-transaction branch from 82ba211 to 546a99d Compare November 24, 2025 15:28
@github-actions
Copy link

Hi, this is WorkflowBot.
Your pull request cannot be merged as it is not passing all our workflow checks.
Please click on each check to review the logs and resolve issues so all checks pass.
To help you:

@exploreriii
Copy link
Contributor

sorry for the spam, there is something going on with our tests.

@exploreriii
Copy link
Contributor

Hi @emiliyank please rebase to pull in main's changes, we applied a fix that was blocking our tests.

@emiliyank emiliyank force-pushed the feat/add-missing-fields-for-account-update-transaction branch 2 times, most recently from d9d5038 to be5472d Compare November 27, 2025 09:34
Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/hiero-ledger/hiero-sdk-python/pull/837/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edL45

Please add back in line 45

  • Added examples/token_create_transaction_supply_key.py to demonstrate token creation with and without a supply key.

additionally please move

  • Add max_automatic_token_associations, staked_account_id, staked_node_id and decline_staking_reward fields to AccountUpdateTransaction (#801)
    to rouhgly line 11

Your changelog needs updating becaues we did a new release 👍

@exploreriii
Copy link
Contributor

Hi @emiliyank reminder to rebase when you are able and move your changelog entry to the UNRELEASED section
Thank you

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

[commit-verification-bot]
Hi, this is VerificationBot.
Your pull request cannot be merged as it has unverified commits.
View your commit verification status: Commits Tab.

To achieve verified status, please read:

Remember, you require a GPG key and each commit must be signed with:
git commit -S -s -m "Your message here"

Thank you for contributing!

From the Hiero Python SDK Team

Signed-off-by: emiliyank <e.kadiyski@gmail.com>
@emiliyank emiliyank force-pushed the feat/add-missing-fields-for-account-update-transaction branch from 71591df to 6094ed3 Compare December 1, 2025 18:48
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Hi, this is MergeConflictBot.
Your pull request cannot be merged because it contains merge conflicts.

Please resolve these conflicts locally and push the changes.

To assist you, please read:

Thank you for contributing!

From the Hiero Python SDK Team

@emiliyank emiliyank closed this Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing fields for AccountUpdateTransaction class

4 participants