-
Notifications
You must be signed in to change notification settings - Fork 92
feat: Add missing fields for AccountUpdateTransaction #837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add missing fields for AccountUpdateTransaction #837
Conversation
e786992 to
3208cb7
Compare
|
LGTM, quick change of Changelog and then that's ready to go! Thank you |
6cae2fa to
867f745
Compare
|
Request review @manishdait @nadineloepfe if able |
manishdait
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me
|
Thanks Manish. @emiliyank please rebase when able 👍 |
nadineloepfe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebase please and then that's ready to go @emiliyank
787bc00
787bc00 to
82ba211
Compare
82ba211 to
546a99d
Compare
|
Hi, this is WorkflowBot.
|
|
sorry for the spam, there is something going on with our tests. |
|
Hi @emiliyank please rebase to pull in main's changes, we applied a fix that was blocking our tests. |
d9d5038 to
be5472d
Compare
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add back in line 45
- Added
examples/token_create_transaction_supply_key.pyto demonstrate token creation with and without a supply key.
additionally please move
- Add
max_automatic_token_associations,staked_account_id,staked_node_idanddecline_staking_rewardfields toAccountUpdateTransaction(#801)
to rouhgly line 11
Your changelog needs updating becaues we did a new release 👍
|
Hi @emiliyank reminder to rebase when you are able and move your changelog entry to the UNRELEASED section |
|
[commit-verification-bot] To achieve verified status, please read: Remember, you require a GPG key and each commit must be signed with: Thank you for contributing! From the Hiero Python SDK Team |
Signed-off-by: emiliyank <e.kadiyski@gmail.com>
71591df to
6094ed3
Compare
|
Hi, this is MergeConflictBot. Please resolve these conflicts locally and push the changes. To assist you, please read: Thank you for contributing! From the Hiero Python SDK Team |
Description:
Add missing fields for
AccountUpdateTransactionclassFixes #801
Checklist