Skip to content

Conversation

@Pranay22077
Copy link
Contributor

Description:

Related issue(s):

Fixes #677

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…d example

Signed-off-by: Pranay <pranaygadh_mc24b06_003@dtu.ac.in>
def define_custom_fee(collector_id: AccountId) -> CustomFixedFee:
"""
Defines and prints a CustomFixedFee object.
This will use the __repr__ method added in the previous issue.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I can wait to review this PR once the repr method is added... or do you want to submit it assuming no repr method?

Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i recommend you remove the repr method as its not yet merged

You need to be able to run the script to test if it really does work - sending a non working script to be reviewed is not a good use of time

I would also recommend you read docs/sdk_developers/pylance.md and install it, it will help you find errors in your code

Note your imports are not pointing to the correct places, I suggest fixes for them
Additionally you are using 1.5 hbar which doesn't work (as our sdk is flawed, does not accept flloats currently, issue was raised)

So a lot of good content, but the key thing is your script won't run
Please read README.md to see how to create a hedera portal account and set up your env with testnet credentials so you can run it 👍

Image Image Image

@Pranay22077
Copy link
Contributor Author

Hey @exploreriii
A little difficult in understanding the issue
Can it be resolved on a meet tomorrow anytime?

@exploreriii
Copy link
Contributor

Hi Pranay
yes, we have meetings every week - 2pm Wednesday UTC and 5pm Wednesday UTC
https://zoom-lfx.platform.linuxfoundation.org/meetings/hiero?view=week
Else please get in touch @Pranay22077 👍

@exploreriii
Copy link
Contributor

Alternatively, would you like me to resolve the issue for you from this point?

@Pranay22077
Copy link
Contributor Author

Either way would work @exploreriii
I can understand the issue and resolve it , else if it would be late till wednesday, rsolution by you would also suffice!

@exploreriii
Copy link
Contributor

If you want to talk about it to resolve it, please get in touch. This is not a conversation area, we recommend discord.md. This is just for reviews. Thanks

@exploreriii
Copy link
Contributor

hi @Pranay22077 is this issue still active please? We have just released 0.1.8

@Pranay22077
Copy link
Contributor Author

Hey @exploreriii
Actually, I got very busy these days due to my exams, and this would take me some days more
If the issue needs to be resolved a little, I suggest to unassign me, and again make the issue open for others!

Thanks!

@exploreriii
Copy link
Contributor

Hi @Pranay22077 good luck with your exams
We can wait a while (but not weeks!), however, let me know if your status changes to request unassigned

@Pranay22077
Copy link
Contributor Author

Hey @exploreriii
Yes, it would take some time (till 7 December) for the exams to end.
and i feel, it's a good amount of time, so you can see accordingly what to be done
Thanks!

@exploreriii
Copy link
Contributor

Thanks for the information.
We will try to wait - but I will let you know if there is a dependency emerges and we need it faster - in which case I will re-assign. Meanwhile it continues assigned to you

@Pranay22077
Copy link
Contributor Author

No issues!
Thanks a lot @exploreriii

@nadineloepfe
Copy link
Contributor

Stale until at least 7th Dec

@Pranay22077
Copy link
Contributor Author

Hi @nadineloepfe
Appreciate for the time given
Thanks a lot

One request: if it can be extended till 9th?
I have my last exam on 8th, so immediately after it, would get back in it

Thanks

@nadineloepfe
Copy link
Contributor

Stale until at least 9th of Dec

@Pranay22077
Copy link
Contributor Author

Thanks a lot @nadineloepfe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt custom_fixed_fee to set up a client and run an end-to-end example

3 participants