-
Notifications
You must be signed in to change notification settings - Fork 92
chore: refactored examples/custom_fixed_fee.py to be a full end-to-end example #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…d example Signed-off-by: Pranay <pranaygadh_mc24b06_003@dtu.ac.in>
| def define_custom_fee(collector_id: AccountId) -> CustomFixedFee: | ||
| """ | ||
| Defines and prints a CustomFixedFee object. | ||
| This will use the __repr__ method added in the previous issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I can wait to review this PR once the repr method is added... or do you want to submit it assuming no repr method?
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i recommend you remove the repr method as its not yet merged
You need to be able to run the script to test if it really does work - sending a non working script to be reviewed is not a good use of time
I would also recommend you read docs/sdk_developers/pylance.md and install it, it will help you find errors in your code
Note your imports are not pointing to the correct places, I suggest fixes for them
Additionally you are using 1.5 hbar which doesn't work (as our sdk is flawed, does not accept flloats currently, issue was raised)
So a lot of good content, but the key thing is your script won't run
Please read README.md to see how to create a hedera portal account and set up your env with testnet credentials so you can run it 👍
|
Hey @exploreriii |
|
Hi Pranay |
|
Alternatively, would you like me to resolve the issue for you from this point? |
|
Either way would work @exploreriii |
|
If you want to talk about it to resolve it, please get in touch. This is not a conversation area, we recommend discord.md. This is just for reviews. Thanks |
|
hi @Pranay22077 is this issue still active please? We have just released 0.1.8 |
|
Hey @exploreriii Thanks! |
|
Hi @Pranay22077 good luck with your exams |
|
Hey @exploreriii |
|
Thanks for the information. |
|
No issues! |
|
Stale until at least 7th Dec |
|
Hi @nadineloepfe One request: if it can be extended till 9th? Thanks |
|
Stale until at least 9th of Dec |
|
Thanks a lot @nadineloepfe |
Description:
Related issue(s):
Fixes #677
Notes for reviewer:
Checklist