hip 1299 - use new method Client.updateNetworkFromAddressBook()

Signed-off-by: emiliyank <e.kadiyski@gmail.com>

Author: emiliyank

sdk/src/main/java/com/hedera/hashgraph/sdk/Client.java

@@ -473,6 +473,40 @@ public synchronized Client setMirrorNetwork(List<String> network) throws Interru
         return this;
     }
 
+    /**
+     * Trigger an immediate address book update.
+     * This will fetch the address book even if periodic updates are disabled.
+     */
+    public synchronized Client updateNetworkFromAddressBook() {
+        try {
+            var fileId = FileId.getAddressBookFileIdFor(this.shard, this.realm);
+
+            logger.debug("Fetching address book from file {}", fileId);
+            System.out.println("Fetching address book from file " + fileId);
+
+            // Execute synchronously - no async complexity
+            var addressBook = new AddressBookQuery()
+                .setFileId(fileId)
+                .execute(this);  // ← Synchronous!
+
+            logger.debug("Received address book with {} nodes", addressBook.nodeAddresses.size());
+            System.out.println("address book size: " + addressBook.nodeAddresses.size());
+
+            // Update the network
+            this.setNetworkFromAddressBook(addressBook);
+
+            logger.info("Address book update completed successfully");
+            System.out.println("Address book update completed successfully");
+
+        } catch (TimeoutException e) {
+            logger.warn("Failed to fetch address book: {}", e.getMessage());
+        } catch (Exception e) {
+            logger.warn("Failed to update address book", e);
+        }
+
+        return this;
+    }
+
     private synchronized void scheduleNetworkUpdate(@Nullable Duration delay) {
         if (delay == null) {
             networkUpdateFuture = null;
@@ -1411,10 +1445,26 @@ public synchronized Client setNetworkUpdatePeriod(Duration networkUpdatePeriod)
      *
      * @return {@code this}
      */
-    public synchronized Client updateNetworkFromAddressBook() {
-        scheduleNetworkUpdate(Duration.ZERO);
-        return this;
-    }
+//    public synchronized Client updateNetworkFromAddressBook() {
+////        scheduleNetworkUpdate(Duration.ZERO);
+//        updateNetworkFromAddressBook2();
+//
+//        if (networkUpdateFuture != null) {
+//            try {
+//                networkUpdateFuture.get(30, TimeUnit.SECONDS);
+//                logger.debug("Address book update completed successfully");
+//            } catch (TimeoutException e) {
+//                logger.warn("Address book update timed out after 30 seconds", e);
+//            } catch (InterruptedException e) {
+//                Thread.currentThread().interrupt();
+//                logger.warn("Address book update was interrupted", e);
+//            } catch (ExecutionException e) {
+//                logger.warn("Address book update failed", e);
+//            }
+//        }
+//
+//        return this;
+//    }
 
     public Logger getLogger() {
         return this.logger;

sdk/src/main/java/com/hedera/hashgraph/sdk/Executable.java

@@ -442,13 +442,13 @@ public O execute(Client client, Duration timeout) throws TimeoutException, Prech
                     lastException = grpcRequest.mapStatusException();
                     advanceRequest(); // Advance to next node before retrying
 
-                    // Handle INVALID_NODE_ACCOUNT after advancing (matches Go SDK's executionStateRetryWithAnotherNode)
+                    // Handle INVALID_NODE_ACCOUNT after advancing
                     if (status == Status.INVALID_NODE_ACCOUNT) {
                         logger.trace(
                                 "Received INVALID_NODE_ACCOUNT; updating address book and marking node {} as unhealthy, attempt #{}",
                                 node.getAccountId(),
                                 attempt);
-                        // Schedule async address book update (matches Go's defer client._UpdateAddressBook())
+                        // Schedule async address book update
                         client.updateNetworkFromAddressBook();
                         // Mark this node as unhealthy
                         client.network.increaseBackoff(node);
@@ -613,7 +613,19 @@ void setNodesFromNodeAccountIds(Client client) {
         if (nodeAccountIds.size() == 1) {
             var nodeProxies = client.network.getNodeProxies(nodeAccountIds.get(0));
             if (nodeProxies == null || nodeProxies.isEmpty()) {
-                throw new IllegalStateException("Account ID did not map to valid node in the client's network");
+                logger.warn("Node {} not found in network, fetching latest address book",
+                    nodeAccountIds.get(0));
+
+                try {
+                    client.updateNetworkFromAddressBook();  // Synchronous update
+                    nodeProxies = client.network.getNodeProxies(nodeAccountIds.get(0));
+                } catch (Exception e) {
+                    logger.error("Failed to update address book", e);
+                }
+
+                if (nodeProxies == null || nodeProxies.isEmpty()) {
+                    throw new IllegalStateException("nodeProxies is null or empty");
+                }
             }
 
             nodes.addAll(nodeProxies).shuffle();
@@ -696,7 +708,7 @@ private ProtoRequestT getRequestForExecute() {
         var request = makeRequest();
 
         // NOTE: advanceRequest() is now called explicitly in the retry logic
-        // after we determine that a retry is needed, to match Go SDK behavior
+        // after we determine that a retry is needed
         // where node advancement happens AFTER error detection, not before
 
         return request;
@@ -903,12 +915,14 @@ ExecutionState getExecutionState(Status status, ResponseT response) {
                 return ExecutionState.SERVER_ERROR;
             case BUSY:
                 return ExecutionState.RETRY;
-            case INVALID_NODE_ACCOUNT:
-                // Matches Go SDK's executionStateRetryWithAnotherNode behavior:
-                // immediately retry with next node without delay
-                // This occurs when a node's account ID has changed
-                return ExecutionState.SERVER_ERROR;
-            case OK:
+                //TODO - use ExecutionState.SUCCESS otherwise there is issue with transaction receipt - raised status INVALID_NODE_ACCOUNT
+//            case INVALID_NODE_ACCOUNT:
+//                // Matches Go SDK's executionStateRetryWithAnotherNode behavior:
+//                // immediately retry with next node without delay
+//                // This occurs when a node's account ID has changed
+//                return ExecutionState.SERVER_ERROR;
+                case INVALID_NODE_ACCOUNT:
+                case OK:
                 return ExecutionState.SUCCESS;
             default:
                 return ExecutionState.REQUEST_ERROR; // user error

sdk/src/testIntegration/java/com/hedera/hashgraph/sdk/test/integration/NodeUpdateAccountIdIntegrationTest.java

@@ -116,6 +116,10 @@ void testNodeUpdateTransactionCanChangeNodeAccountUpdateAddressbookAndRetry() th
                     .setAccountId(newNodeAccountID)
                     .execute(client);
 
+            // Add before line 119 in your test
+            System.out.println("Transaction node: " + resp.nodeId);
+            System.out.println("Receipt query nodes: " + resp.getReceiptQuery().getNodeAccountIds());
+            System.out.println("Client network: " + client.getNetwork());
             receipt = resp.setValidateStatus(true).getReceipt(client);
             assertThat(receipt.status).isEqualTo(Status.SUCCESS);