Skip to content

Commit 97fa884

Browse files
authored
Update CONTRIBUTING.md
1 parent 1025d76 commit 97fa884

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

CONTRIBUTING.md

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
# CONTRIBUTING
22

3+
## PR
4+
5+
We take PRs on a case-by-case basis. Please contact us in the discord in the #dev channel to have your PR considered.
6+
7+
You will need to create a feature branch from the `main` branch, write all your code there, and then when you submit your PR you submit it against the `main` branch.
8+
9+
If anything else is new to you, don't feel intimidated, come and join us on Discord and we'll take the time to help.
10+
311
## Components
412

513
When creating a component you need to provide a few properties in order to render the component properly. Try to avoid creating prop drilling, or even accessing react context in a component. The components should be as dumb as possible. The only place where you should have access to API requests, or React.Context is at the page level (`src/pages/*`).
@@ -18,10 +26,3 @@ export const MyComponent = () => {
1826

1927
There are some auxiliary components that aren't doing much besides aiding with the layout. A good example of that is the `/src/pages/objkt-display` where you have `<Container/>` and `<Padding />`. These components are similar to what `reactstrap` provides, but we're trying to minimize our bundle size, so we're reducing on dependencies.
2028

21-
## PR
22-
23-
We take PRs on a case-by-case basis. Please contact us in the discord in the #dev channel to have your PR considered.
24-
25-
You will need to create a feature branch from the `main` branch, write all your code there, and then when you submit your PR you submit it against the `main` branch.
26-
27-
If anything else is new to you, don't feel intimidated, come and join us on Discord and we'll take the time to help.

0 commit comments

Comments
 (0)