[#1205] added tests to test with null collection and demonstrate fetch options for lazy initialization

Author: blafond

hibernate-reactive-core/src/test/java/org/hibernate/reactive/LazyInitializationExceptionWithMutiny.java

@@ -18,7 +18,9 @@
 import javax.persistence.OneToMany;
 import javax.persistence.Table;
 
+import org.hibernate.Hibernate;
 import org.hibernate.LazyInitializationException;
+import org.hibernate.reactive.mutiny.Mutiny;
 
 import org.junit.Before;
 import org.junit.Test;
@@ -31,15 +33,21 @@ public class LazyInitializationExceptionWithMutiny extends BaseReactiveTest {
 
 	@Override
 	protected Collection<Class<?>> annotatedEntities() {
-		return List.of( Artist.class, Painting.class );
+		return List.of( Painting.class, Artist.class );
 	}
 
 	@Before
 	public void populateDB(TestContext context) {
 		Async async = context.async();
 		Artist artemisia = new Artist( "Artemisia Gentileschi" );
+		Painting sev = new Painting();
+		sev.setAuthor( artemisia );
+		sev.setName( "Susanna e i vecchioni" );
+		Painting liuto = new Painting();
+		liuto.setAuthor( artemisia );
+		liuto.setName( "Autoritratto come suonatrice di liuto" );
 		getMutinySessionFactory()
-				.withTransaction( (session, tx) -> session.persist( artemisia ) )
+				.withTransaction( (session, tx) -> session.persistAll( artemisia, liuto, sev ) )
 				.subscribe().with( success -> async.complete(), context::fail );
 	}
 
@@ -53,9 +61,9 @@ public void testLazyInitializationException(TestContext context) {
 					  .onItem().invoke( () -> context.fail( "Unexpected success, we expect " + LazyInitializationException.class.getName() ) )
 					  .onFailure().recoverWithUni( throwable -> {
 						  context.assertEquals( LazyInitializationException.class, throwable.getClass() );
-						  context.assertEquals(
-								  "HR000056: Collection cannot be initialized: org.hibernate.reactive.LazyInitializationExceptionWithMutiny$Artist.paintings",
-								  throwable.getMessage()
+						  context.assertTrue(
+						  		throwable.getMessage().startsWith(
+									"HR000056: Collection cannot be initialized: org.hibernate.reactive.LazyInitializationExceptionWithMutiny$Artist.paintings" )
 						  );
 						  return Uni.createFrom().nullItem();
 					  } )
@@ -73,6 +81,33 @@ public void testLazyInitializationExceptionNotThrown(TestContext context) {
 		);
 	}
 
+	@Test
+	public void testLazyInitializationWithJoinFetch(TestContext context) {
+		test( context, openMutinySession()
+				.chain( session -> session
+						.createQuery( "from Artist a join fetch a.paintings", Artist.class )
+						.getSingleResult() )
+				.onItem().invoke( artist -> {
+					context.assertTrue( Hibernate.isInitialized( artist ) );
+					context.assertEquals( 2, artist.getPaintings().size() );
+				} ) );
+	}
+
+	@Test
+	public void testLazyInitializationWithMutinyFetch(TestContext context) {
+		test( context,
+				openMutinySession().chain( session -> session
+						.createQuery( "from Artist", Artist.class )
+						.getSingleResult() )
+						.chain( artist -> Mutiny.fetch( artist.paintings )
+								.invoke( paintings -> {
+							context.assertTrue( Hibernate.isInitialized( paintings ) );
+							context.assertEquals( 2, paintings.size() );
+						} )
+					)
+		);
+	}
+
 	@Entity(name = "Painting")
 	@Table(name = "painting")
 	public static class Painting {
@@ -186,10 +221,6 @@ public List<Painting> getPaintings() {
 			return paintings;
 		}
 
-		public void setPaintings(List<Painting> paintings) {
-			this.paintings = paintings;
-		}
-
 		@Override
 		public boolean equals(Object o) {
 			if ( this == o ) {

hibernate-reactive-core/src/test/java/org/hibernate/reactive/LazyInitializationExceptionWithStage.java

@@ -19,7 +19,9 @@
 import javax.persistence.OneToMany;
 import javax.persistence.Table;
 
+import org.hibernate.Hibernate;
 import org.hibernate.LazyInitializationException;
+import org.hibernate.reactive.stage.Stage;
 
 import org.junit.Before;
 import org.junit.Test;
@@ -31,13 +33,19 @@ public class LazyInitializationExceptionWithStage extends BaseReactiveTest {
 
 	@Override
 	protected Collection<Class<?>> annotatedEntities() {
-		return List.of( Artist.class, Painting.class );
+		return List.of(  Painting.class, Artist.class);
 	}
 
 	@Before
 	public void populateDB(TestContext context) {
 		Artist artemisia = new Artist( "Artemisia Gentileschi" );
-		test( context, getSessionFactory().withTransaction( (session, tx) -> session.persist( artemisia ) ) );
+		Painting sev = new Painting();
+		sev.setAuthor( artemisia );
+		sev.setName( "Susanna e i vecchioni" );
+		Painting liuto = new Painting();
+		liuto.setAuthor( artemisia );
+		liuto.setName( "Autoritratto come suonatrice di liuto" );
+		test( context, getSessionFactory().withTransaction( session -> session.persist( artemisia, liuto, sev ) ) );
 	}
 
 	@Test
@@ -55,9 +63,10 @@ public void testLazyInitializationException(TestContext context) {
 								else {
 									context.assertEquals( CompletionException.class, throwable.getClass() );
 									context.assertEquals( LazyInitializationException.class, throwable.getCause().getClass() );
-									context.assertEquals(
-											"org.hibernate.LazyInitializationException: HR000056: Collection cannot be initialized: org.hibernate.reactive.LazyInitializationExceptionWithStage$Artist.paintings",
-											throwable.getMessage() );
+									context.assertTrue(
+											throwable.getMessage().startsWith(
+												"org.hibernate.LazyInitializationException: HR000056: Collection cannot be initialized: org.hibernate.reactive.LazyInitializationExceptionWithStage$Artist.paintings" )
+									);
 								}
 								return null;
 							} )
@@ -73,6 +82,31 @@ public void testLazyInitializationExceptionNotThrown(TestContext context) {
 		);
 	}
 
+	@Test
+	public void testLazyInitializationWithJoinFetch(TestContext context) {
+		test( context, openSession()
+				.thenCompose( session -> session
+						.createQuery( "from Artist a join fetch a.paintings", Artist.class )
+						.getSingleResult() )
+				.thenAccept( artist -> {
+					context.assertTrue( Hibernate.isInitialized( artist.paintings ) );
+					context.assertEquals( 2, artist.getPaintings().size() );
+				} ) );
+	}
+
+	@Test
+	public void testLazyInitializationWithStageFetch(TestContext context) {
+		test( context, openSession()
+				.thenCompose( session -> session.createQuery( "from Artist", Artist.class ).getSingleResult() )
+				.thenCompose( artist -> Stage.fetch( artist.paintings )
+						.thenAccept( paintings -> {
+							context.assertTrue( Hibernate.isInitialized( paintings ) );
+							context.assertEquals( 2, paintings.size() );
+						} )
+				)
+		);
+	}
+
 	@Entity(name = "Painting")
 	@Table(name = "painting")
 	public static class Painting {
@@ -186,10 +220,6 @@ public List<Painting> getPaintings() {
 			return paintings;
 		}
 
-		public void setPaintings(List<Painting> paintings) {
-			this.paintings = paintings;
-		}
-
 		@Override
 		public boolean equals(Object o) {
 			if ( this == o ) {