fix up weird signature of ReactiveEntityPersister.insertReactive()

Author: gavinking

hibernate-reactive-core/src/main/java/org/hibernate/reactive/engine/impl/ReactiveEntityRegularInsertAction.java

@@ -63,7 +63,7 @@ public CompletionStage<Void> reactiveExecute() throws HibernateException {
 			final ReactiveEntityPersister reactivePersister = (ReactiveEntityPersister) persister;
 			final PersistenceContext persistenceContext = session.getPersistenceContextInternal();
 			return stage
-					.thenCompose( v -> reactivePersister.insertReactive( id, getState(), instance, session, false ) )
+					.thenCompose( v -> reactivePersister.insertReactive( id, getState(), instance, session ) )
 					.thenCompose( generatedValues -> {
 						final EntityEntry entry = persistenceContext.getEntry( instance );
 						if ( entry == null ) {

hibernate-reactive-core/src/main/java/org/hibernate/reactive/persister/entity/impl/ReactiveEntityPersister.java

@@ -16,7 +16,6 @@
 import org.hibernate.generator.values.GeneratedValues;
 import org.hibernate.loader.ast.spi.MultiIdLoadOptions;
 import org.hibernate.persister.entity.EntityPersister;
-import org.hibernate.reactive.persister.entity.mutation.ReactiveInsertCoordinator;
 
 import jakarta.persistence.metamodel.Attribute;
 
@@ -33,15 +32,14 @@ public interface ReactiveEntityPersister extends EntityPersister {
 	 *
 	 * @see EntityPersister#insert(Object, Object[], Object, SharedSessionContractImplementor)
 	 */
-	default CompletionStage<GeneratedValues> insertReactive(Object id, Object[] fields, Object object, SharedSessionContractImplementor session) {
-		return ( (ReactiveInsertCoordinator) getInsertCoordinator() ).reactiveInsert( object, id, fields, session );
-	};
+	CompletionStage<GeneratedValues> insertReactive(Object id, Object[] fields, Object object, SharedSessionContractImplementor session);
 
 	/**
 	 * Insert the given instance state without blocking, but it allows to specify if it's an identity insert or a regular one.
 	 *
 	 * @see EntityPersister#insert(Object, Object[], Object, SharedSessionContractImplementor)
 	 */
+	@Deprecated(forRemoval = true)
 	CompletionStage<GeneratedValues> insertReactive(Object id, Object[] fields, Object object, SharedSessionContractImplementor session, boolean isIdentityType);
 
 	/**

hibernate-reactive-core/src/main/java/org/hibernate/reactive/persister/entity/impl/ReactiveJoinedSubclassEntityPersister.java

@@ -183,10 +183,10 @@ public NaturalIdMapping generateNaturalIdMapping(MappingModelCreationProcess cre
 
 	@Override
 	public CompletionStage<GeneratedValues> insertReactive(Object id, Object[] fields, Object object, SharedSessionContractImplementor session) {
-		return insertReactive( id, fields, object, session, true );
+		return ( (ReactiveInsertCoordinatorStandard) getInsertCoordinator() ).coordinateReactiveInsert( object, id, fields, session, false );
 	}
 
-	@Override
+	@Override @Deprecated(forRemoval = true)
 	public CompletionStage<GeneratedValues> insertReactive(Object id, Object[] fields, Object object, SharedSessionContractImplementor session, boolean isIdentityInsert) {
 		return ( (ReactiveInsertCoordinatorStandard) getInsertCoordinator() ).coordinateReactiveInsert( object, id, fields, session, isIdentityInsert );
 	}

hibernate-reactive-core/src/main/java/org/hibernate/reactive/persister/entity/impl/ReactiveSingleTableEntityPersister.java

@@ -343,10 +343,10 @@ public CompletionStage<GeneratedValues> insertReactive(Object[] fields, Object e
 
 	@Override
 	public CompletionStage<GeneratedValues> insertReactive(Object id, Object[] fields, Object entity, SharedSessionContractImplementor session) {
-		return insertReactive( id, fields, entity, session, true );
+		return ( (ReactiveInsertCoordinatorStandard) getInsertCoordinator() ).coordinateReactiveInsert( entity, id, fields, session, false );
 	}
 
-	@Override
+	@Override @Deprecated(forRemoval = true)
 	public CompletionStage<GeneratedValues> insertReactive(Object id, Object[] fields, Object entity, SharedSessionContractImplementor session, boolean isIdentityInsert) {
 		return ( (ReactiveInsertCoordinatorStandard) getInsertCoordinator() ).coordinateReactiveInsert( entity, id, fields, session, isIdentityInsert );
 	}

hibernate-reactive-core/src/main/java/org/hibernate/reactive/persister/entity/impl/ReactiveUnionSubclassEntityPersister.java

@@ -310,13 +310,12 @@ private CompletionStage<Object> doReactiveLoad(Object id, Object optionalObject,
 
 	@Override
 	public CompletionStage<GeneratedValues> insertReactive(Object id, Object[] fields, Object entity, SharedSessionContractImplementor session) {
-		return insertReactive( id, fields, entity, session, true );
+		return ( (ReactiveInsertCoordinatorStandard) getInsertCoordinator() ).coordinateReactiveInsert( entity, id, fields, session, false );
 	}
 
-	@Override
+	@Override @Deprecated(forRemoval = true)
 	public CompletionStage<GeneratedValues> insertReactive(Object id, Object[] fields, Object entity, SharedSessionContractImplementor session, boolean isIdentityInsert) {
-		return ( (ReactiveInsertCoordinatorStandard) getInsertCoordinator() )
-				.coordinateReactiveInsert( entity, id, fields, session, isIdentityInsert );
+		return ( (ReactiveInsertCoordinatorStandard) getInsertCoordinator() ).coordinateReactiveInsert( entity, id, fields, session, isIdentityInsert );
 	}
 
 	@Override