[#1205] Refactor tests for LazyInitializationException

Merge the two classes into one - we create one less SessionFactory -
and update the tests using the latest utilities we have.

Author: DavideD

hibernate-reactive-core/src/test/java/org/hibernate/reactive/LazyInitializationExceptionWithStage.java renamed to hibernate-reactive-core/src/test/java/org/hibernate/reactive/LazyInitializationExceptionTest.java

@@ -8,7 +8,6 @@
 import java.util.Collection;
 import java.util.List;
 import java.util.Objects;
-import java.util.concurrent.CompletionException;
 import javax.persistence.Entity;
 import javax.persistence.FetchType;
 import javax.persistence.GeneratedValue;
@@ -21,19 +20,27 @@
 
 import org.hibernate.Hibernate;
 import org.hibernate.LazyInitializationException;
+import org.hibernate.reactive.mutiny.Mutiny;
 import org.hibernate.reactive.stage.Stage;
 
 import org.junit.Before;
 import org.junit.Test;
 
 import io.vertx.ext.unit.TestContext;
 
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.hibernate.reactive.testing.ReactiveAssertions.assertThrown;
 
-public class LazyInitializationExceptionWithStage extends BaseReactiveTest {
+/**
+ * We expect to throw the right exception when a lazy initialization error happens.
+ *
+ * @see LazyInitializationException
+ */
+public class LazyInitializationExceptionTest extends BaseReactiveTest {
 
 	@Override
 	protected Collection<Class<?>> annotatedEntities() {
-		return List.of(  Painting.class, Artist.class);
+		return List.of( Painting.class, Artist.class );
 	}
 
 	@Before
@@ -49,39 +56,56 @@ public void populateDB(TestContext context) {
 	}
 
 	@Test
-	public void testLazyInitializationException(TestContext context) {
-		test( context, openSession()
-				.thenCompose( session ->
-				  	session.createQuery( "from Artist", Artist.class )
-						.getSingleResult()
-							.thenAccept( artist -> artist.getPaintings().size() )
-							.handle( (ignore, throwable) -> {
-								if (throwable == null ) {
-									context.fail( "Unexpected success, we expect "
-														  + LazyInitializationException.class.getName() );
-								}
-								else {
-									context.assertEquals( CompletionException.class, throwable.getClass() );
-									context.assertEquals( LazyInitializationException.class, throwable.getCause().getClass() );
-									context.assertTrue(
-											throwable.getMessage().startsWith(
-												"org.hibernate.LazyInitializationException: HR000056: Collection cannot be initialized: org.hibernate.reactive.LazyInitializationExceptionWithStage$Artist.paintings" )
-									);
-								}
-								return null;
-							} )
-				) );
+	public void testLazyInitializationExceptionWithMutiny(TestContext context) {
+		test( context, assertThrown( LazyInitializationException.class, openMutinySession()
+				.chain( ms -> ms.createQuery( "from Artist", Artist.class ).getSingleResult() )
+				.invoke( artist -> artist.getPaintings().size() ) )
+				.invoke( LazyInitializationExceptionTest::assertLazyInitialization )
+		);
+	}
+
+	@Test
+	public void testLazyInitializationExceptionWithStage(TestContext context) {
+		test( context, assertThrown( LazyInitializationException.class, openSession()
+				.thenCompose( ss -> ss.createQuery( "from Artist", Artist.class ).getSingleResult() )
+				.thenAccept( artist -> artist.getPaintings().size() ) )
+				.thenAccept( LazyInitializationExceptionTest::assertLazyInitialization )
+		);
+	}
+
+	private static void assertLazyInitialization(LazyInitializationException e) {
+		assertThat( e.getMessage() )
+				.startsWith( "HR000056: Collection cannot be initialized: " + Artist.class.getName() + ".paintings" );
+	}
+
+	@Test
+	public void testLazyInitializationExceptionNotThrownWithMutiny(TestContext context) {
+		test( context, openMutinySession()
+				.chain( session -> session.createQuery( "from Artist", Artist.class ).getSingleResult() )
+				// We are checking `.getPaintings()` but not doing anything with it and therefore it should work.
+				.invoke( Artist::getPaintings )
+		);
 	}
 
 	@Test
-	public void testLazyInitializationExceptionNotThrown(TestContext context) {
+	public void testLazyInitializationExceptionNotThrownWithStage(TestContext context) {
 		test( context, openSession()
-			.thenCompose( session -> session.createQuery( "from Artist", Artist.class ).getSingleResult() )
-			 // We are checking `.getPaintings()` but not doing anything with it and therefore it should work.
-			.thenAccept( Artist::getPaintings )
+				.thenCompose( session -> session.createQuery( "from Artist", Artist.class ).getSingleResult() )
+				// We are checking `.getPaintings()` but not doing anything with it and therefore it should work.
+				.thenAccept( Artist::getPaintings )
 		);
 	}
 
+	@Test
+	public void testLazyInitializationWithJoinFetchAndMutiny(TestContext context) {
+		test( context, openMutinySession()
+				.chain( session -> session.createQuery( "from Artist a join fetch a.paintings", Artist.class ).getSingleResult() )
+				.onItem().invoke( artist -> {
+					context.assertTrue( Hibernate.isInitialized( artist ) );
+					context.assertEquals( 2, artist.getPaintings().size() );
+				} ) );
+	}
+
 	@Test
 	public void testLazyInitializationWithJoinFetch(TestContext context) {
 		test( context, openSession()
@@ -94,6 +118,19 @@ public void testLazyInitializationWithJoinFetch(TestContext context) {
 				} ) );
 	}
 
+	@Test
+	public void testLazyInitializationWithMutinyFetch(TestContext context) {
+		test( context, openMutinySession()
+				.chain( session -> session.createQuery( "from Artist", Artist.class ).getSingleResult() )
+				.chain( artist -> Mutiny.fetch( artist.paintings )
+						.invoke( paintings -> {
+							context.assertTrue( Hibernate.isInitialized( paintings ) );
+							context.assertEquals( 2, paintings.size() );
+						} )
+				)
+		);
+	}
+
 	@Test
 	public void testLazyInitializationWithStageFetch(TestContext context) {
 		test( context, openSession()