Fix for PostgreSQL ReactiveSqmMultiTableMutationStrategyProvider

Author: DavideD

hibernate-reactive-core/src/main/java/org/hibernate/reactive/dialect/ReactiveDialectWrapper.java

@@ -8,10 +8,6 @@
 import org.hibernate.dialect.Dialect;
 import org.hibernate.dialect.DialectDelegateWrapper;
 import org.hibernate.dialect.identity.IdentityColumnSupport;
-import org.hibernate.metamodel.mapping.EntityMappingType;
-import org.hibernate.metamodel.spi.RuntimeModelCreationContext;
-import org.hibernate.query.sqm.mutation.spi.SqmMultiTableInsertStrategy;
-import org.hibernate.query.sqm.mutation.spi.SqmMultiTableMutationStrategy;
 import org.hibernate.reactive.dialect.identity.ReactiveIdentityColumnSupportAdapter;
 
 /**
@@ -29,22 +25,4 @@ public ReactiveDialectWrapper(Dialect wrapped) {
 	public IdentityColumnSupport getIdentityColumnSupport() {
 		return new ReactiveIdentityColumnSupportAdapter( super.getIdentityColumnSupport() );
 	}
-
-	@Override
-	public SqmMultiTableMutationStrategy getFallbackSqmMutationStrategy(
-			EntityMappingType rootEntityDescriptor,
-			RuntimeModelCreationContext runtimeModelCreationContext) {
-		throw new IllegalStateException(
-				"Should never be called - see ReactiveSqmMultiTableMutationStrategyProvider" );
-	}
-
-	@Override
-	public SqmMultiTableInsertStrategy getFallbackSqmInsertStrategy(
-			EntityMappingType rootEntityDescriptor,
-			RuntimeModelCreationContext runtimeModelCreationContext) {
-		throw new IllegalStateException(
-				"Should never be called - see ReactiveSqmMultiTableMutationStrategyProvider" );
-
-	}
-
 }

hibernate-reactive-core/src/main/java/org/hibernate/reactive/provider/service/ReactiveSqmMultiTableMutationStrategyProvider.java

@@ -5,9 +5,12 @@
  */
 package org.hibernate.reactive.provider.service;
 
+import org.hibernate.boot.spi.SessionFactoryOptions;
 import org.hibernate.metamodel.mapping.EntityMappingType;
 import org.hibernate.metamodel.mapping.internal.MappingModelCreationProcess;
 import org.hibernate.metamodel.spi.RuntimeModelCreationContext;
+import org.hibernate.query.sqm.mutation.internal.cte.CteInsertStrategy;
+import org.hibernate.query.sqm.mutation.internal.cte.CteMutationStrategy;
 import org.hibernate.query.sqm.mutation.spi.SqmMultiTableInsertStrategy;
 import org.hibernate.query.sqm.mutation.spi.SqmMultiTableMutationStrategy;
 import org.hibernate.query.sqm.mutation.spi.SqmMultiTableMutationStrategyProvider;
@@ -21,19 +24,40 @@ public SqmMultiTableMutationStrategy createMutationStrategy(
 			EntityMappingType rootEntityDescriptor,
 			MappingModelCreationProcess creationProcess) {
 		final RuntimeModelCreationContext creationContext = creationProcess.getCreationContext();
+		SqmMultiTableMutationStrategy mutationStrategy = mutationStrategy( rootEntityDescriptor, creationContext );
+		if ( mutationStrategy instanceof CteMutationStrategy ) {
+			return new ReactiveCteMutationStrategy( rootEntityDescriptor, creationContext );
+		}
+		return mutationStrategy;
+	}
 
-		//TODO there's more flavours in ORM ? And what do we do about explicitly configured instances & Dialect produced implementations?
-		return new ReactiveCteMutationStrategy( rootEntityDescriptor, creationContext );
+	private static SqmMultiTableMutationStrategy mutationStrategy(
+			EntityMappingType rootEntityDescriptor,
+			RuntimeModelCreationContext creationContext) {
+		final SessionFactoryOptions options = creationContext.getSessionFactoryOptions();
+		return options.getCustomSqmMultiTableMutationStrategy() != null
+				? options.getCustomSqmMultiTableMutationStrategy()
+				: creationContext.getDialect().getFallbackSqmMutationStrategy( rootEntityDescriptor, creationContext );
 	}
 
 	@Override
 	public SqmMultiTableInsertStrategy createInsertStrategy(
 			EntityMappingType rootEntityDescriptor,
 			MappingModelCreationProcess creationProcess) {
 		final RuntimeModelCreationContext creationContext = creationProcess.getCreationContext();
-
-		//TODO there's more flavours in ORM ? And what do we do about explicitly configured instances & Dialect produced implementations?
-		return new ReactiveCteInsertStrategy( rootEntityDescriptor, creationContext );
+		final SqmMultiTableInsertStrategy insertStrategy = insertStrategy( rootEntityDescriptor, creationContext );
+		if ( insertStrategy instanceof CteInsertStrategy ) {
+			return new ReactiveCteInsertStrategy( rootEntityDescriptor, creationContext );
+		}
+		return insertStrategy;
 	}
 
+	private static SqmMultiTableInsertStrategy insertStrategy(
+			EntityMappingType rootEntityDescriptor,
+			RuntimeModelCreationContext creationContext) {
+		final SessionFactoryOptions options = creationContext.getSessionFactoryOptions();
+		return options.getCustomSqmMultiTableInsertStrategy() != null
+				? options.getCustomSqmMultiTableInsertStrategy()
+				: creationContext.getDialect().getFallbackSqmInsertStrategy( rootEntityDescriptor, creationContext );
+	}
 }