[#1596] Allow use of Sql Server dialect 11+

Vert.x 4.2.2 add a partial implementation of SSVARIANTTYPE decoding,
just enough to support querying metadata about integer MSSQL sequences.

Author: DavideD

hibernate-reactive-core/src/main/java/org/hibernate/reactive/adaptor/impl/ResultSetAdaptor.java

@@ -29,6 +29,7 @@
 import java.time.LocalTime;
 import java.util.Calendar;
 import java.util.Map;
+import java.util.NoSuchElementException;
 import java.util.function.Function;
 
 import org.hibernate.engine.jdbc.BlobProxy;
@@ -191,8 +192,19 @@ public InputStream getBinaryStream(int columnIndex) {
 
 	@Override
 	public String getString(String columnLabel) {
-		String string = row.getString( columnLabel );
-		return ( wasNull = string == null ) ? null : string;
+		String result = caseInsensitiveGet( columnLabel, row::getString );
+		wasNull = result == null;
+		return result;
+	}
+
+	private <T> T caseInsensitiveGet(String columnLabel, Function<String, T> produce) {
+		for ( String columnName : rows.columnsNames() ) {
+			if ( columnName.equalsIgnoreCase( columnLabel ) ) {
+				return produce.apply( columnName );
+			}
+		}
+		// Same error thrown by io.vertx.sqlclient.Row when it doesn't find the label
+		throw new NoSuchElementException( "Column " + columnLabel + " does not exist" );
 	}
 
 	@Override
@@ -239,7 +251,7 @@ public int getInt(String columnLabel) {
 
 	@Override
 	public long getLong(String columnLabel) {
-		Long aLong = row.getLong( columnLabel );
+		Long aLong = caseInsensitiveGet( columnLabel, row::getLong );
 		wasNull = aLong == null;
 		return wasNull ? 0 : aLong;
 	}

hibernate-reactive-core/src/main/java/org/hibernate/reactive/provider/service/NoJdbcEnvironmentInitiator.java

@@ -9,16 +9,12 @@
 import java.util.concurrent.CompletionStage;
 
 import org.hibernate.boot.registry.StandardServiceInitiator;
-import org.hibernate.dialect.DatabaseVersion;
 import org.hibernate.dialect.Dialect;
-import org.hibernate.dialect.SQLServerDialect;
 import org.hibernate.engine.jdbc.dialect.spi.DialectFactory;
 import org.hibernate.engine.jdbc.dialect.spi.DialectResolutionInfo;
 import org.hibernate.engine.jdbc.env.spi.JdbcEnvironment;
 import org.hibernate.engine.jdbc.spi.SqlExceptionHelper;
 import org.hibernate.reactive.engine.jdbc.env.internal.ReactiveJdbcEnvironment;
-import org.hibernate.reactive.logging.impl.Log;
-import org.hibernate.reactive.logging.impl.LogCategory;
 import org.hibernate.reactive.pool.ReactiveConnection;
 import org.hibernate.reactive.pool.ReactiveConnectionPool;
 import org.hibernate.reactive.provider.Settings;
@@ -29,7 +25,6 @@
 import io.vertx.sqlclient.spi.DatabaseMetadata;
 
 import static java.util.function.Function.identity;
-import static org.hibernate.reactive.logging.impl.LoggerFactory.make;
 import static org.hibernate.reactive.util.impl.CompletionStages.completedFuture;
 
 /**
@@ -39,11 +34,6 @@
  */
 public class NoJdbcEnvironmentInitiator implements StandardServiceInitiator<JdbcEnvironment> {
 
-	/**
-	 * I'm using the same logger category used in {@link org.hibernate.engine.jdbc.dialect.internal.DialectFactoryImpl}.
-	 */
-	private static final Log LOG = make( Log.class, new LogCategory( "SQL dialect" ) );
-
 	public static final NoJdbcEnvironmentInitiator INSTANCE = new NoJdbcEnvironmentInitiator();
 
 	@Override
@@ -75,24 +65,7 @@ public DialectBuilder(Map<String, Object> configurationValues, ServiceRegistry r
 
 		public Dialect build() {
 			DialectFactory dialectFactory = registry.getService( DialectFactory.class );
-			Dialect dialect = dialectFactory.buildDialect( configurationValues, this::dialectResolutionInfo );
-			return checkDialect( dialect );
-		}
-
-		/**
-		 * Workaround for <a href="https://github.com/eclipse-vertx/vertx-sql-client/issues/1312">vertx-sql-client#1312</a>
-		 * <p>
-		 * For extracting the information about sequences, the Sql Server dialect 11+ uses the following query:
-		 * <pre>{@code select * from INFORMATION_SCHEMA.SEQUENCES}</pre>
-		 * But, the Vert.x MSSQL client throws an exception when running it.
-		 */
-		private static Dialect checkDialect(Dialect dialect) {
-			if ( dialect instanceof SQLServerDialect && dialect.getVersion().isSameOrAfter( 11 ) ) {
-				SQLServerDialect sqlServerDialect = new SQLServerDialect( DatabaseVersion.make( 10 ) );
-				LOG.replacingDialect( dialect, sqlServerDialect );
-				return sqlServerDialect;
-			}
-			return dialect;
+			return dialectFactory.buildDialect( configurationValues, this::dialectResolutionInfo );
 		}
 
 		private DialectResolutionInfo dialectResolutionInfo() {