HHH-19746 Test JPA Criteria parameter hashCode collision

Author: beikov

hibernate-core/src/test/java/org/hibernate/orm/test/query/criteria/CriteriaValueParameterTests.java

@@ -0,0 +1,95 @@
+/*
+ * SPDX-License-Identifier: Apache-2.0
+ * Copyright Red Hat Inc. and Hibernate Authors
+ */
+package org.hibernate.orm.test.query.criteria;
+
+import java.util.HashMap;
+
+import org.hibernate.query.criteria.JpaParameterExpression;
+
+import org.hibernate.testing.orm.junit.DomainModel;
+import org.hibernate.testing.orm.junit.Jira;
+import org.hibernate.testing.orm.junit.SessionFactory;
+import org.hibernate.testing.orm.junit.SessionFactoryScope;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.Test;
+
+import jakarta.persistence.Entity;
+import jakarta.persistence.Id;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+
+@DomainModel(annotatedClasses = CriteriaValueParameterTests.Cat.class)
+@SessionFactory
+@Jira("https://hibernate.atlassian.net/browse/HHH-19746")
+public class CriteriaValueParameterTests {
+
+	@AfterEach
+	public void tearDown(SessionFactoryScope scope) {
+		scope.getSessionFactory().getSchemaManager().truncateMappedObjects();
+	}
+
+	@Test
+	void test_named_parameter_with_same_hashcode_will_crash_the_query(SessionFactoryScope scope) {
+		scope.inTransaction( session -> {
+			var builder = session.getCriteriaBuilder();
+			var criteria = builder.createQuery( Cat.class );
+			var root = criteria.from( Cat.class );
+			var p1 = builder.parameter( String.class, "Aa" );
+			var p2 = builder.parameter( String.class, "BB" );
+			assertEquals( p1.hashCode(), p2.hashCode() );
+			criteria.where( root.get( "name" ).in( p1, p2 ) );
+			var query = session.createQuery( criteria );
+			query.setParameter( p1, "value" );
+			query.setParameter( p2, "value" );
+			query.getResultList();
+		} );
+	}
+
+	@Test
+	void test_collisions_will_cause_bindings_to_get_lost(SessionFactoryScope scope) {
+		scope.inTransaction( session -> {
+			session.persist( new Cat( "a" ) );
+			session.persist( new Cat( "b" ) );
+			var builder = session.getCriteriaBuilder();
+			var criteria = builder.createQuery( Long.class );
+			var root = criteria.from( Cat.class );
+			// Generating around 100K parameters so far always resulted in a hashCode collision
+			var map = new HashMap<Integer, JpaParameterExpression<String>>( 100_000 );
+			JpaParameterExpression<String> parameter1 = null;
+			JpaParameterExpression<String> parameter2 = null;
+			for ( int i = 0; i < 1_000_000; i++ ) {
+				final JpaParameterExpression<String> parameter = builder.parameter( String.class );
+				final JpaParameterExpression<String> old = map.put( parameter.hashCode(), parameter );
+				if ( old != null ) {
+					parameter1 = old;
+					parameter2 = parameter;
+					map.clear();
+					break;
+				}
+			}
+			assertNotNull( parameter1, "Failed to provoke hashCode collision" );
+			criteria.select( builder.count( root ) )
+					.where( root.get( "name" ).in( parameter1, parameter2 ) );
+			var query = session.createQuery( criteria );
+			query.setParameter( parameter1, "a" );
+			query.setParameter( parameter2, "b" );
+			assertEquals( 2, query.getSingleResult() );
+		} );
+	}
+
+	@Entity(name = "Cat")
+	static class Cat {
+		@Id
+		private String name;
+
+		public Cat() {
+		}
+
+		public Cat(String name) {
+			this.name = name;
+		}
+	}
+}