HHH-9938 - field access parameter on gradle plugin

Author: barreiro

documentation/src/main/asciidoc/topical/bytecode/BytecodeEnhancement.adoc

@@ -78,13 +78,16 @@ hibernate {
 ----
 ====
 
-Currently the "enhance" extension supports 3 properties:
+Currently the "enhance" extension supports 4 properties:
 
     * `enableLazyInitialization`
     * `enableDirtyTracking`
     * `enableAssociationManagement`
+    * `enableFieldAccessEnhancement`
 
-Once enhancement overall is enabled, the default for these 3 properties is `true`.
+Once enhancement overall is enabled, the default for the first 3 properties is `true`. Field access is not enhanced by
+default, as it can potentially trigger enhancement of code outside the entities, and also because it assumes that all
+the target entities are enhanced, which may not always be the case.
 
 
 === Ant Task

tooling/hibernate-gradle-plugin/src/main/groovy/org/hibernate/orm/tooling/gradle/EnhanceExtension.groovy

@@ -16,8 +16,9 @@ class EnhanceExtension {
 	def boolean enableLazyInitialization = true
 	def boolean enableDirtyTracking = true
 	def boolean enableAssociationManagement = true
+	def boolean enableFieldAccessEnhancement = false
 
 	boolean shouldApply() {
-		return enableLazyInitialization || enableDirtyTracking || enableAssociationManagement;
+		return enableLazyInitialization || enableDirtyTracking || enableAssociationManagement || enableFieldAccessEnhancement;
 	}
 }

tooling/hibernate-gradle-plugin/src/main/groovy/org/hibernate/orm/tooling/gradle/EnhancerTask.groovy

@@ -110,6 +110,11 @@ public boolean hasLazyLoadableAttributes(CtClass classDescriptor) {
 								public boolean isLazyLoadable(CtField field) {
 									return hibernateExtension.enhance.getEnableLazyInitialization();
 								}
+
+								@Override
+								public boolean doFieldAccessEnhancement(CtClass classDescriptor) {
+									return  hibernateExtension.enhance.getEnableFieldAccessEnhancement();
+								}
 							};
 
 							final Enhancer enhancer = new Enhancer( enhancementContext );

tooling/hibernate-gradle-plugin/src/main/groovy/org/hibernate/orm/tooling/gradle/HibernatePlugin.java

@@ -5,15 +5,12 @@
  * See the lgpl.txt file in the root directory or <http://www.gnu.org/licenses/lgpl-2.1.html>.
  */
 package org.hibernate.orm.tooling.gradle
-
 import org.gradle.api.Project
 import org.gradle.testfixtures.ProjectBuilder
 
 import org.junit.Test
 
 import static org.junit.Assert.assertNotNull
-import static org.junit.Assert.assertTrue
-
 /**
  * Test what we can.  ProjectBuilder is better than nothing, but still quited limited in what
  * you can test (e.g. you cannot test task execution).
@@ -35,7 +32,10 @@ class HibernatePluginTest {
 		project.plugins.apply 'org.hibernate.orm'
 
 		project.extensions.findByType( HibernateExtension.class ).enhance {
+			enableLazyInitialization = true
+			enableDirtyTracking = true
 			enableAssociationManagement = false
+			enableFieldAccessEnhancement = false
 		}
 	}
 }