Add set/get server version api (facebook#1296)

Summary:
This diff added support for set/get server version api in rocksdb

Pull Request resolved: facebook#1296

Test Plan: Test it locally

Reviewed By: luqun

Differential Revision: D45332426

Pulled By: sunshine-Chun



------------------------------------------------------------------------

Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299)

Summary:
We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function.

This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping.

Pull Request resolved: facebook#1299

Test Plan:
The diff will unblock the test failure in D44598701

Imported from GitHub, without a `Test Plan:` line.

Reviewed By: luqun

Differential Revision: D45723276

Pulled By: sunshine-Chun

Author: sunshine-Chun

storage/rocksdb/ha_rocksdb.cc

@@ -7435,6 +7435,9 @@ static int rocksdb_init_internal(void *const p) {
   rocksdb_hton->clone_interface.clone_apply_end = rocksdb_clone_apply_end;
 
   rocksdb_hton->dict_register_dd_table_id = rocksdb_dict_register_dd_table_id;
+  rocksdb_hton->dict_get_server_version = rocksdb_dict_get_server_version;
+  rocksdb_hton->dict_set_server_version = rocksdb_dict_set_server_version;
+  rocksdb_hton->is_supported_system_table = rocksdb_is_supported_system_table;
 
   rocksdb_hton->flags = HTON_SUPPORTS_EXTENDED_KEYS | HTON_CAN_RECREATE;
 

storage/rocksdb/rdb_datadic.cc

@@ -5309,6 +5309,11 @@ bool Rdb_dict_manager::init(rocksdb::TransactionDB *const rdb_dict,
       rocksdb::Slice(reinterpret_cast<char *>(m_key_buf_max_index_id),
                      Rdb_key_def::INDEX_NUMBER_SIZE);
 
+  rdb_netbuf_store_index(m_key_buf_server_version, Rdb_key_def::SERVER_VERSION);
+  m_key_slice_server_version =
+      rocksdb::Slice(reinterpret_cast<char *>(m_key_buf_server_version),
+                     Rdb_key_def::INDEX_NUMBER_SIZE);
+
   resume_drop_indexes();
   rollback_ongoing_index_creation();
 
@@ -6033,6 +6038,39 @@ bool Rdb_dict_manager::update_max_index_id(rocksdb::WriteBatch *const batch,
   return false;
 }
 
+bool Rdb_dict_manager::get_server_version(uint *const ser_version) const {
+  std::string value;
+
+  const rocksdb::Status status = get_value(m_key_slice_server_version, &value);
+  if (status.ok()) {
+    Rdb_string_reader reader(value);
+    uint version = 0;
+    reader.read_uint16(&version);
+    if (version == Rdb_key_def::SERVER_VERSION_VERSION) {
+      return reader.read_uint32(ser_version);
+    }
+  }
+
+  return true;
+}
+
+bool Rdb_dict_manager::set_server_version() const {
+  const std::unique_ptr<rocksdb::WriteBatch> batch = begin();
+
+  Rdb_buf_writer<Rdb_key_def::VERSION_SIZE + Rdb_key_def::SERVER_VERSION_SIZE>
+      value_writer;
+
+  uint32 server_ver = MYSQL_VERSION_ID;
+  value_writer.write_uint16(Rdb_key_def::SERVER_VERSION_VERSION);
+  value_writer.write_uint32(server_ver);
+  const rocksdb::Status status = batch.get()->Put(
+      m_system_cfh, m_key_slice_server_version, value_writer.to_slice());
+
+  commit(batch.get());
+
+  return !status.ok();
+}
+
 void Rdb_dict_manager::add_stats(
     rocksdb::WriteBatch *const batch,
     const std::vector<Rdb_index_stats> &stats) const {

storage/rocksdb/rdb_datadic.h

@@ -421,6 +421,7 @@ class Rdb_key_def {
     CF_NUMBER_SIZE = 4,
     CF_FLAG_SIZE = 4,
     PACKED_SIZE = 4,  // one int
+    SERVER_VERSION_SIZE = 4,
   };
 
   // bit flags for combining bools when writing to disk
@@ -457,6 +458,7 @@ class Rdb_key_def {
     AUTO_INC = 9,
     DROPPED_CF = 10,
     MAX_DD_INDEX_ID = 11,
+    SERVER_VERSION = 12,
     END_DICT_INDEX_ID = 255
   };
 
@@ -472,6 +474,7 @@ class Rdb_key_def {
     DDL_CREATE_INDEX_ONGOING_VERSION = 1,
     AUTO_INCREMENT_VERSION = 1,
     DROPPED_CF_VERSION = 1,
+    SERVER_VERSION_VERSION = 1,
     // Version for index stats is stored in IndexStats struct
   };
 
@@ -1559,6 +1562,11 @@ class Rdb_binlog_manager {
   value: version, index_id
   index_id is 4 bytes
 
+  12. server version
+  key: Rdb_key_def::SERVER_VERSION(0xc)
+  value: version, {server version}
+  server version is 4 bytes
+
   Data dictionary operations are atomic inside RocksDB. For example,
   when creating a table with two indexes, it is necessary to call Put
   three times. They have to be atomic. Rdb_dict_manager has a wrapper function
@@ -1578,6 +1586,9 @@ class Rdb_dict_manager : public Ensure_initialized {
   uchar m_key_buf_max_dd_index_id[Rdb_key_def::INDEX_NUMBER_SIZE] = {0};
   rocksdb::Slice m_key_slice_max_dd_index_id;
 
+  uchar m_key_buf_server_version[Rdb_key_def::INDEX_NUMBER_SIZE] = {0};
+  rocksdb::Slice m_key_slice_server_version;
+
   static void dump_index_id(uchar *const netbuf,
                             Rdb_key_def::DATA_DICT_TYPE dict_type,
                             const GL_INDEX_ID &gl_index_id);
@@ -1725,6 +1736,22 @@ class Rdb_dict_manager : public Ensure_initialized {
   bool update_max_index_id(rocksdb::WriteBatch *const batch,
                            const uint32_t index_id,
                            bool is_dd_tbl = false) const;
+
+  /**
+    Get the server version from the private data dictionary table
+    @param version  out parameter
+    @retval false   ok
+    @retval true    error
+  */
+  bool get_server_version(uint *const version) const;
+
+  /**
+    Set the server version to the private data dictionary table
+    @retval false   ok
+    @retval true    error
+  */
+  bool set_server_version() const;
+
   void add_stats(rocksdb::WriteBatch *const batch,
                  const std::vector<Rdb_index_stats> &stats) const;
   Rdb_index_stats get_stats(GL_INDEX_ID gl_index_id) const;

storage/rocksdb/rdb_native_dd.cc

@@ -22,6 +22,8 @@
 
 /* MyRocks header files */
 #include "ha_rocksdb.h"
+#include "storage/rocksdb/ha_rocksdb_proto.h"
+#include "storage/rocksdb/rdb_datadic.h"
 
 namespace myrocks {
 std::unordered_set<dd::Object_id> native_dd::s_dd_table_ids = {};
@@ -50,4 +52,20 @@ void rocksdb_dict_register_dd_table_id(dd::Object_id dd_table_id) {
   native_dd::insert_dd_table_ids(dd_table_id);
 };
 
+bool rocksdb_dict_get_server_version(uint *version) {
+  return rdb_get_dict_manager()
+      ->get_dict_manager_selector_non_const(false /*is_tmp_table*/)
+      ->get_server_version(version);
+};
+
+bool rocksdb_dict_set_server_version() {
+  return rdb_get_dict_manager()
+      ->get_dict_manager_selector_non_const(false /*is_tmp_table*/)
+      ->set_server_version();
+};
+
+bool rocksdb_is_supported_system_table(const char *, const char *, bool) {
+  return false;
+}
+
 }  // namespace myrocks

storage/rocksdb/rdb_native_dd.h

@@ -16,6 +16,7 @@
 #pragma once
 
 /* C++ standard header files */
+#include <sys/types.h>
 #include <unordered_set>
 
 /* MySQL header files */
@@ -28,6 +29,9 @@ class Table;
 namespace myrocks {
 
 void rocksdb_dict_register_dd_table_id(dd::Object_id dd_table_id);
+bool rocksdb_dict_get_server_version(uint *version);
+bool rocksdb_dict_set_server_version();
+bool rocksdb_is_supported_system_table(const char *, const char *, bool);
 
 class native_dd {
  private: