Refactor the plotting framework to use the RecipesBase package #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Plotting
Changed the plotting implementation from the standard
Plotspackage to theRecipesBasepackage.RecipesBaseis a lightweight package by the Plots team that allows for third party software to interact with thePlotspackage without the need to import everything onto the project. It is a preferred method to implement plotting using thePlotspackage in third party packages.This modifies the two previous function,
plotGAMandPartialDependencePlotrenaming them toplotgamandpartialdependenceplot. This doesn't affect their usability, their parameter call stays the same; as a bonus, it adds the ability to pass additional keyword arguments to the plotting function, likelinecolor,label, etc like soplotgam(mod, linecolor=:red).The second modification is that the standard
plotfunction fromPlotspackage now accepts aGAMDatatype. Runningplot(mod)will give the same result asplotgam(mod), aditionaly the keyword argumentvaris also available and, when passed, the function behaves just likepartialdependenceplot, e.g.plot(mod, var=1).Test
A testing target has been created in the Project.toml file, isolating test packages from necessary packages for the use of
GAM.jl.