test: improve and ajust mutation issues

Author: AlissonMedeiros

adapter/input/jaxrs-controller-v1/pom.xml

@@ -17,9 +17,6 @@
         <maven.compiler.target>11</maven.compiler.target>
         <swagger-core.version>2.1.6</swagger-core.version>
         <swagger-maven-plugin.version>2.1.5</swagger-maven-plugin.version>
-        <coverage.line>1</coverage.line>
-        <coverage.branch>1</coverage.branch>
-        <mutation.threshold>100</mutation.threshold>
     </properties>
 
     <dependencies>

adapter/input/jaxrs-controller-v1/src/main/java/br/com/helpdev/controller/handler/MethodArgumentNotValidExceptionMapper.java renamed to adapter/input/jaxrs-controller-v1/src/main/java/br/com/helpdev/controller/handler/NotificationExceptionMapper.java

@@ -7,7 +7,7 @@
 import javax.ws.rs.ext.Provider;
 
 @Provider
-public class MethodArgumentNotValidExceptionMapper implements ExceptionMapper<NotificationException> {
+public class NotificationExceptionMapper implements ExceptionMapper<NotificationException> {
 
   @Override
   public Response toResponse(final NotificationException e) {

adapter/input/jaxrs-controller-v1/src/test/java/br/com/helpdev/controller/MessageControllerTest.java

@@ -51,7 +51,7 @@ class MessageControllerTest {
   private final ControllerMessageMapper mapper = new ControllerMessageMapper();
 
   @Test
-  public void whenDeleteTheReturn204() throws NotificationException {
+  void whenDeleteTheReturn204() throws NotificationException {
     var id = 1L;
     var messageId = MessageId.from(id);
     var response = messageController.delete(id);
@@ -62,7 +62,7 @@ public void whenDeleteTheReturn204() throws NotificationException {
   }
 
   @Test
-  public void whenFindByIdTheReturn200() throws NotificationException {
+  void whenFindByIdTheReturn200() throws NotificationException {
     var id = 2L;
     var messageId = MessageId.from(id);
     when(findRequestNotification.find(messageId)).thenReturn(Message.builder()
@@ -84,7 +84,7 @@ public void whenFindByIdTheReturn200() throws NotificationException {
   }
 
   @Test
-  public void whenCreateTheReturn201() throws NotificationException {
+  void whenCreateTheReturn201() throws NotificationException {
     var id = 4L;
     var messageId = MessageId.from(id);
     var body = "Olá";

adapter/input/jaxrs-controller-v1/src/test/java/br/com/helpdev/controller/handler/MethodArgumentNotValidExceptionMapperTest.java

@@ -1,7 +1,19 @@
 package br.com.helpdev.controller.handler;
 
-import static org.junit.jupiter.api.Assertions.*;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import br.com.helpdev.controller.dto.ErrorDto;
+import br.com.helpdev.usecase.exception.MessageNotFoundException;
+import org.junit.jupiter.api.Test;
 
 class NotFoundExceptionMapperTest {
 
+  @Test
+  void whenReturnErrorThenCreateResponse() {
+    var mapper = new NotFoundExceptionMapper();
+    var response = mapper.toResponse(new MessageNotFoundException("Error"));
+    assertThat(response.getStatus()).isEqualTo(404);
+    assertThat(response.getEntity()).isEqualTo(ErrorDto.builder().message("Error").build());
+  }
+
 }

adapter/input/jaxrs-controller-v1/src/test/java/br/com/helpdev/controller/handler/NotFoundExceptionMapperTest.java

@@ -0,0 +1,19 @@
+package br.com.helpdev.controller.handler;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import br.com.helpdev.controller.dto.ErrorDto;
+import br.com.helpdev.domain.exception.NotificationException;
+import org.junit.jupiter.api.Test;
+
+class NotificationExceptionMapperTest {
+
+  @Test
+  void whenReturnErrorThenCreateResponse() {
+    var mapper = new NotificationExceptionMapper();
+    var response = mapper.toResponse(new NotificationException("Error"));
+    assertThat(response.getStatus()).isEqualTo(400);
+    assertThat(response.getEntity()).isEqualTo(ErrorDto.builder().message("Error").build());
+  }
+
+}

adapter/input/jaxrs-controller-v1/src/test/java/br/com/helpdev/controller/handler/NotificationExceptionMapperTest.java

@@ -24,7 +24,7 @@ class ControllerMessageMapperTest {
   private final ControllerMessageMapper mapper = new ControllerMessageMapper();
 
   @Test
-  public void whenBodyHasEntityThenConvertToDto() {
+  void whenBodyHasEntityThenConvertToDto() {
     var message = fakeBuilder()
         .body(MessageBody.from("Test"))
         .build();
@@ -34,7 +34,7 @@ public void whenBodyHasEntityThenConvertToDto() {
   }
 
   @Test
-  public void whenHasBodyInCreateDtoThenConvertToEntity() {
+  void whenHasBodyInCreateDtoThenConvertToEntity() {
     var message = fakeDto()
         .body("Test")
         .build();
@@ -44,7 +44,7 @@ public void whenHasBodyInCreateDtoThenConvertToEntity() {
   }
 
   @Test
-  public void whenDateHasEntityThenConvertToDto() {
+  void whenDateHasEntityThenConvertToDto() {
     var date = ZonedDateTime.now();
     var message = fakeBuilder()
         .scheduleDate(date)
@@ -56,7 +56,7 @@ public void whenDateHasEntityThenConvertToDto() {
 
 
   @Test
-  public void whenEntityHasWhatsAppThenConvertToDto() {
+  void whenEntityHasWhatsAppThenConvertToDto() {
     var message = fakeBuilder()
         .channel(CommunicationChannel.WHATSAPP)
         .build();
@@ -66,7 +66,7 @@ public void whenEntityHasWhatsAppThenConvertToDto() {
   }
 
   @Test
-  public void whenHasDateInCreateDtoThenConvertToEntity() {
+  void whenHasDateInCreateDtoThenConvertToEntity() {
     var date = ZonedDateTime.now();
     var message = fakeDto()
         .scheduleDate(date)
@@ -77,7 +77,7 @@ public void whenHasDateInCreateDtoThenConvertToEntity() {
   }
 
   @Test
-  public void whenHasWhatsAppInCreateDtoThenConvertToEntity() {
+  void whenHasWhatsAppInCreateDtoThenConvertToEntity() {
     var message = fakeDto()
         .channel(CommunicationChannelDto.WHATSAPP)
         .build();
@@ -87,7 +87,7 @@ public void whenHasWhatsAppInCreateDtoThenConvertToEntity() {
   }
 
   @Test
-  public void whenEntityHasEmailThenConvertToDto() {
+  void whenEntityHasEmailThenConvertToDto() {
     var message = fakeBuilder()
         .channel(CommunicationChannel.EMAIL)
         .build();
@@ -97,7 +97,7 @@ public void whenEntityHasEmailThenConvertToDto() {
   }
 
   @Test
-  public void whenHasEmailInCreateDtoThenConvertToEntity() {
+  void whenHasEmailInCreateDtoThenConvertToEntity() {
     var message = fakeDto()
         .channel(CommunicationChannelDto.EMAIL)
         .build();
@@ -106,15 +106,9 @@ public void whenHasEmailInCreateDtoThenConvertToEntity() {
     assertThat(entity.getChannel()).isEqualTo(CommunicationChannel.EMAIL);
   }
 
-  private MessageCreateDto.MessageCreateDtoBuilder fakeDto() {
-    return MessageCreateDto.builder().body("empty")
-        .recipient(RecipientDto.builder()
-            .phoneNumber("123")
-            .build());
-  }
 
   @Test
-  public void whenEntityHasSmsThenConvertToDto() {
+  void whenEntityHasSmsThenConvertToDto() {
     var message = fakeBuilder()
         .channel(CommunicationChannel.SMS)
         .build();
@@ -124,7 +118,7 @@ public void whenEntityHasSmsThenConvertToDto() {
   }
 
   @Test
-  public void whenHasSmsInCreateDtoThenConvertToEntity() {
+  void whenHasSmsInCreateDtoThenConvertToEntity() {
     var message = fakeDto()
         .channel(CommunicationChannelDto.SMS)
         .build();
@@ -134,7 +128,7 @@ public void whenHasSmsInCreateDtoThenConvertToEntity() {
   }
 
   @Test
-  public void whenEntityHasPushThenConvertToDto() {
+  void whenEntityHasPushThenConvertToDto() {
     var message = fakeBuilder()
         .channel(CommunicationChannel.PUSH)
         .build();
@@ -144,7 +138,7 @@ public void whenEntityHasPushThenConvertToDto() {
   }
 
   @Test
-  public void whenHasPushInCreateDtoThenConvertToEntity() {
+  void whenHasPushInCreateDtoThenConvertToEntity() {
     var message = fakeDto()
         .channel(CommunicationChannelDto.PUSH)
         .build();
@@ -154,7 +148,7 @@ public void whenHasPushInCreateDtoThenConvertToEntity() {
   }
 
   @Test
-  public void whenWaitingStatusOnChannelThenConvertToDto() {
+  void whenWaitingStatusOnChannelThenConvertToDto() {
     var message = fakeBuilder()
         .chats(List.of(Chat.builder().status(Status.WAITING).build()))
         .build();
@@ -166,7 +160,7 @@ public void whenWaitingStatusOnChannelThenConvertToDto() {
   }
 
   @Test
-  public void whenSentStatusOnChannelThenConvertToDto() {
+  void whenSentStatusOnChannelThenConvertToDto() {
     var message = fakeBuilder()
         .chats(List.of(Chat.builder().status(Status.SENT).build()))
         .build();
@@ -177,16 +171,8 @@ public void whenSentStatusOnChannelThenConvertToDto() {
     );
   }
 
-  private Message.MessageBuilder fakeBuilder() {
-    return Message.builder().body(MessageBody.from("empty"))
-        .recipient(Recipient.builder()
-            .phone(Phone.newNumber("123123"))
-            .build())
-        .id(MessageId.from(1L));
-  }
-
   @Test
-  public void whenSendingStatusOnChannelThenConvertToDto() {
+  void whenSendingStatusOnChannelThenConvertToDto() {
     var message = fakeBuilder()
         .chats(List.of(Chat.builder().status(Status.SENDING).build()))
         .build();
@@ -198,20 +184,24 @@ public void whenSendingStatusOnChannelThenConvertToDto() {
   }
 
   @Test
-  public void whenDateOnChannelThenConvertToDto() {
+  void whenDateOnChannelThenConvertToDto() {
     var date = ZonedDateTime.now();
     var message = fakeBuilder()
         .chats(List.of(Chat.builder().date(date).build()))
         .build();
     var dto = mapper.toDto(message);
     assertThat(dto).isNotNull();
-    assertThat(dto.getChats()).hasSize(1).first().satisfies(
-        c -> assertThat(c.getDate()).isEqualTo(date)
+    assertThat(dto).isNotNull();
+    assertThat(dto.getChats()).hasSize(1).first().satisfies(c ->
+        {
+          assertThat(c.getDate()).isEqualTo(date);
+          assertThat(c.getStatus()).isEqualTo(StatusResponseDto.WAITING);
+        }
     );
   }
 
   @Test
-  public void whenHasIdThenConvertToDto() {
+  void whenHasIdThenConvertToDto() {
     var message = fakeBuilder()
         .id(MessageId.from(123L))
         .build();
@@ -221,7 +211,7 @@ public void whenHasIdThenConvertToDto() {
   }
 
   @Test
-  public void whenEntityHasRecipientNameThenConvertToDto() {
+  void whenEntityHasRecipientNameThenConvertToDto() {
     var message = fakeBuilder()
         .recipient(Recipient.builder()
             .name("Alisson")
@@ -234,7 +224,7 @@ public void whenEntityHasRecipientNameThenConvertToDto() {
   }
 
   @Test
-  public void whenHasRecipientNameInCreateDtoThenConvertToEntity() {
+  void whenHasRecipientNameInCreateDtoThenConvertToEntity() {
     var message = MessageCreateDto.builder()
         .body("empty")
         .recipient(RecipientDto.builder()
@@ -248,7 +238,7 @@ public void whenHasRecipientNameInCreateDtoThenConvertToEntity() {
   }
 
   @Test
-  public void whenEntityHasRecipientEmailThenConvertToDto() {
+  void whenEntityHasRecipientEmailThenConvertToDto() {
     var message = fakeBuilder()
         .recipient(Recipient.builder()
             .email("alisson@mail.com")
@@ -261,7 +251,7 @@ public void whenEntityHasRecipientEmailThenConvertToDto() {
   }
 
   @Test
-  public void whenHasRecipientEmailInCreateDtoThenConvertToEntity() {
+  void whenHasRecipientEmailInCreateDtoThenConvertToEntity() {
     var message = MessageCreateDto.builder().body("empty")
         .recipient(RecipientDto.builder()
             .phoneNumber("123")
@@ -274,7 +264,7 @@ public void whenHasRecipientEmailInCreateDtoThenConvertToEntity() {
   }
 
   @Test
-  public void whenEntityHasRecipientPhoneIdThenConvertToDto() {
+  void whenEntityHasRecipientPhoneIdThenConvertToDto() {
     var message = fakeBuilder()
         .recipient(Recipient.builder()
             .phone(Phone.from("123", "16000000"))
@@ -286,7 +276,7 @@ public void whenEntityHasRecipientPhoneIdThenConvertToDto() {
   }
 
   @Test
-  public void whenHasRecipientPhoneIdInCreateDtoThenConvertToEntity() {
+  void whenHasRecipientPhoneIdInCreateDtoThenConvertToEntity() {
     var message = MessageCreateDto.builder().body("empty")
         .recipient(RecipientDto.builder()
             .phoneId("123")
@@ -299,7 +289,7 @@ public void whenHasRecipientPhoneIdInCreateDtoThenConvertToEntity() {
   }
 
   @Test
-  public void whenEntityHasRecipientPhoneNumberThenConvertToDto() {
+  void whenEntityHasRecipientPhoneNumberThenConvertToDto() {
     var message = fakeBuilder()
         .recipient(Recipient.builder()
             .phone(Phone.from("123", "999988887777"))
@@ -311,7 +301,7 @@ public void whenEntityHasRecipientPhoneNumberThenConvertToDto() {
   }
 
   @Test
-  public void whenHasRecipientPhoneNumberInCreateDtoThenConvertToEntity() {
+  void whenHasRecipientPhoneNumberInCreateDtoThenConvertToEntity() {
     var message = MessageCreateDto.builder().body("body")
         .recipient(RecipientDto.builder()
             .phoneNumber("999988887777")
@@ -322,5 +312,19 @@ public void whenHasRecipientPhoneNumberInCreateDtoThenConvertToEntity() {
     assertThat(entity.getRecipient().getPhone().getPhoneNumber()).isEqualTo("999988887777");
   }
 
+  private MessageCreateDto.MessageCreateDtoBuilder fakeDto() {
+    return MessageCreateDto.builder().body("empty")
+        .recipient(RecipientDto.builder()
+            .phoneNumber("123")
+            .build());
+  }
 
+  private Message.MessageBuilder fakeBuilder() {
+    return Message.builder().body(MessageBody.from("empty"))
+        .recipient(Recipient.builder()
+            .phone(Phone.newNumber("123123"))
+            .build())
+        .id(MessageId.from(1L));
+  }
+  
 }