test: improve and fix

Author: AlissonMedeiros

acceptance-test/src/test/java/br/com/helpdev/atdd/ApplicationIT.java

@@ -70,7 +70,6 @@ public void whenDeleteMessageThenRemove() {
         .statusCode(201)
         .extract()
         .path("id");
-    System.out.println("Id: " + id);
     given()
         .when()
         .delete("/v1/message/{id}", id)
@@ -130,7 +129,6 @@ public void whenCreateNewSmsScheduleThenReturn() {
         .body(buildMessage(ZonedDateTime.now(), CommunicationChannelDto.SMS))
         .when()
         .post("/v1/message/")
-        .prettyPeek()
         .then()
         .statusCode(201)
         .body("id", notNullValue())

adapter/input/jaxrs-controller-v1/pom.xml

@@ -17,9 +17,9 @@
         <maven.compiler.target>11</maven.compiler.target>
         <swagger-core.version>2.1.6</swagger-core.version>
         <swagger-maven-plugin.version>2.1.5</swagger-maven-plugin.version>
-        <coverage.line>0</coverage.line>
-        <coverage.branch>0</coverage.branch>
-        <mutation.threshold>0</mutation.threshold>
+        <coverage.line>1</coverage.line>
+        <coverage.branch>1</coverage.branch>
+        <mutation.threshold>100</mutation.threshold>
     </properties>
 
     <dependencies>

adapter/input/jaxrs-controller-v1/src/main/java/br/com/helpdev/controller/mapper/ControllerMessageMapper.java

@@ -61,15 +61,15 @@ private CommunicationChannelDto parse(final CommunicationChannel value) {
   }
 
   private Recipient parse(final RecipientDto recipient) {
-    return recipient == null ? null : Recipient.builder()
+    return Recipient.builder()
         .email(recipient.getEmail())
         .name(recipient.getName())
         .phone(Phone.from(recipient.getPhoneId(), recipient.getPhoneNumber()))
         .build();
   }
 
   private RecipientDto parse(final Recipient recipient) {
-    return recipient == null ? null : RecipientDto.builder()
+    return RecipientDto.builder()
         .email(recipient.getEmail())
         .name(recipient.getName())
         .phoneId(recipient.getPhone().getPhoneId().orElse(null))

adapter/input/jaxrs-controller-v1/src/test/java/br/com/helpdev/controller/handler/MethodArgumentNotValidExceptionMapperTest.java

@@ -0,0 +1,7 @@
+package br.com.helpdev.controller.handler;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class MethodArgumentNotValidExceptionMapperTest {
+
+}

adapter/input/jaxrs-controller-v1/src/test/java/br/com/helpdev/controller/handler/NotFoundExceptionMapperTest.java

@@ -0,0 +1,7 @@
+package br.com.helpdev.controller.handler;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class NotFoundExceptionMapperTest {
+
+}

adapter/input/jaxrs-controller-v1/src/test/java/br/com/helpdev/controller/mapper/ControllerMessageMapperTest.java

@@ -322,4 +322,5 @@ public void whenHasRecipientPhoneNumberInCreateDtoThenConvertToEntity() {
     assertThat(entity.getRecipient().getPhone().getPhoneNumber()).isEqualTo("999988887777");
   }
 
+
 }