fix(memfault): do not log missing device as error

Author: coderbyheart

Memfault/api.ts

@@ -1,5 +1,6 @@
 import { validateWithTypeBox } from '@hello.nrfcloud.com/proto'
 import { type Static } from '@sinclair/typebox'
+import { NotFoundError } from '../util/NotFoundError.js'
 import { ValidationError } from '../util/ValidationError.js'
 import { MemfaultReboots } from './MemfaultReboots.js'
 
@@ -42,12 +43,20 @@ export const getDeviceReboots =
 				}),
 			},
 		)
-		if (!res.ok)
+		if (!res.ok) {
+			if (res.status === 404) {
+				return {
+					error: new NotFoundError(
+						`Failed to fetch reboots: ${res.status}. ${await res.text()}`,
+					),
+				}
+			}
 			return {
 				error: new Error(
 					`Failed to fetch reboots: ${res.status}. ${await res.text()}`,
 				),
 			}
+		}
 
 		const maybeValid = v(await res.json())
 		if ('errors' in maybeValid)

lambda/memfault/fetchReboots.ts

@@ -9,6 +9,7 @@ import { fromEnv } from '@bifravst/from-env'
 import { logger } from '@hello.nrfcloud.com/lambda-helpers/logger'
 import { metricsForComponent } from '@hello.nrfcloud.com/lambda-helpers/metrics'
 import { requestLogger } from '@hello.nrfcloud.com/lambda-helpers/requestLogger'
+import { NotFoundError } from '@hello.nrfcloud.com/proto/hello'
 import middy from '@middy/core'
 import type { SQSEvent } from 'aws-lambda'
 import { getDeviceReboots } from '../../Memfault/api.js'
@@ -61,13 +62,16 @@ const h = async (event: SQSEvent): Promise<void> => {
 
 		if (deviceId === undefined || since === undefined) {
 			log.error('Missing required attributes')
-			track('error', MetricUnit.Count, 1)
 			continue
 		}
 		const maybeReboots = await fetchReboots(deviceId, since)
 		if ('error' in maybeReboots) {
-			log.error(maybeReboots.error.message)
-			track('error', MetricUnit.Count, 1)
+			if (maybeReboots.error instanceof NotFoundError) {
+				log.debug(maybeReboots.error.message)
+			} else {
+				log.error(maybeReboots.error.message)
+				track('error', MetricUnit.Count, 1)
+			}
 			continue
 		}
 		const reboots = maybeReboots.value.data

util/NotFoundError.ts

@@ -0,0 +1,6 @@
+export class NotFoundError extends Error {
+	constructor(message: string) {
+		super(message)
+		this.name = 'NotFoundError'
+	}
+}