psbt: remove derives from UtxoUpdateError and OutputUpdateError

Going forward, we should only derive Debug and whichever of Clone,
PartialEq and Eq are possible.

PartialEq is very useful for doing assertions, and Clone is often
useful because it allows Results to be cloned. But the other traits
are uncommon to implement on error types, have an unclear meaning,
and limit our ability to compose types without breaking changes.

Also adds a bunch of Eq bounds to error types that implement PartialEq.
There is almost never a reason to implement PartialEq but not Eq.

In the next commit I'm gonna replace ConversionError, an old error
which derives all these things, with the new NonDefiniteKeyError,
which will prevent these derives from working on UtxoUpdateError.

Author: heap-coder

src/descriptor/key.rs

@@ -328,7 +328,7 @@ impl DescriptorMultiXKey<bip32::Xpriv> {
 }
 
 /// Kinds of malformed key data
-#[derive(Debug, PartialEq, Clone)]
+#[derive(Debug, PartialEq, Eq, Clone)]
 #[non_exhaustive]
 #[allow(missing_docs)]
 pub enum NonDefiniteKeyError {
@@ -353,7 +353,7 @@ impl fmt::Display for NonDefiniteKeyError {
 impl error::Error for NonDefiniteKeyError {}
 
 /// Kinds of malformed key data
-#[derive(Debug, PartialEq, Clone)]
+#[derive(Debug, PartialEq, Eq, Clone)]
 #[non_exhaustive]
 #[allow(missing_docs)]
 pub enum MalformedKeyDataKind {
@@ -397,7 +397,7 @@ impl fmt::Display for MalformedKeyDataKind {
 }
 
 /// Descriptor Key parsing errors
-#[derive(Debug, PartialEq, Clone)]
+#[derive(Debug, PartialEq, Eq, Clone)]
 #[non_exhaustive]
 pub enum DescriptorKeyParseError {
     /// Error while parsing a BIP32 extended private key

src/psbt/mod.rs

@@ -1175,7 +1175,7 @@ fn update_item_with_descriptor_helper<F: PsbtFields>(
 }
 
 /// Return error type for [`PsbtExt::update_input_with_descriptor`]
-#[derive(Debug, PartialEq, Eq, PartialOrd, Ord, Hash, Clone, Copy)]
+#[derive(Debug, PartialEq, Eq, Clone)]
 pub enum UtxoUpdateError {
     /// Index out of bounds
     IndexOutOfBounds(usize, usize),
@@ -1224,7 +1224,7 @@ impl error::Error for UtxoUpdateError {
 }
 
 /// Return error type for [`PsbtExt::update_output_with_descriptor`]
-#[derive(Debug, PartialEq, Eq, PartialOrd, Ord, Hash, Clone, Copy)]
+#[derive(Debug, PartialEq, Eq, Clone)]
 pub enum OutputUpdateError {
     /// Index out of bounds
     IndexOutOfBounds(usize, usize),