Skip to content

Commit b930912

Browse files
authored
Fix GitHub Actions on Windows (#1533)
The [actions fail](https://github.com/hazelcast/hazelcast-nodejs-client/actions/runs/14506740078/job/40704373693) because the `java-config.env` isn't parsed correctly. Specifically, we are using the _default_ shell (on Windows, `pwsh`), which doesn't work with `cat` - we should be specifying `bash` explicitly (even on Windows) as per the C++ repo: https://github.com/hazelcast/hazelcast-cpp-client/blob/0659bebcca6f8d001ef9abb11077f7431fb39bbd/.github/actions/build-test/windows/action.yml#L53-L55 [Example Windows execution showing that it succeeded in setting the Java version with this change](https://github.com/hazelcast/hazelcast-nodejs-client/actions/runs/14509405447/job/40704693730) (other test failures out of scope).
1 parent b55e48f commit b930912

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

.github/workflows/code_sample_checker.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ jobs:
1414
- name: Checkout code
1515
uses: actions/checkout@v4
1616
- name: Read Java Config
17+
shell: bash
1718
run: cat .github/java-config.env >> $GITHUB_ENV
1819
- name: Setup Java
1920
uses: actions/setup-java@v4

.github/workflows/coverage_runner.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ jobs:
5555
ref: refs/pull/${{ github.event.inputs.pr_number }}/merge
5656

5757
- name: Read Java Config
58+
shell: bash
5859
run: cat .github/java-config.env >> $GITHUB_ENV
5960
- name: Setup Java
6061
uses: actions/setup-java@v4

.github/workflows/nightly_runner_master.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ jobs:
1616
- name: Checkout code
1717
uses: actions/checkout@v4
1818
- name: Read Java Config
19+
shell: bash
1920
run: cat .github/java-config.env >> $GITHUB_ENV
2021
- name: Setup Java
2122
uses: actions/setup-java@v4

0 commit comments

Comments
 (0)