spec compliance: _registerOptions should be a Maybe

Author: thomasjm

lsp-test/src/Language/LSP/Test.hs

@@ -430,7 +430,7 @@ createDoc file languageId contents = do
       createHits (WatchKind create _ _) = create
 
       regHits :: Registration WorkspaceDidChangeWatchedFiles -> Bool
-      regHits reg = foldl' (\acc w -> acc || watchHits w) False (reg ^. registerOptions . watchers)
+      regHits reg = foldl' (\acc w -> acc || watchHits w) False (reg ^. registerOptions . _Just . watchers)
 
       clientCapsSupports =
           caps ^? workspace . _Just . didChangeWatchedFiles . _Just . dynamicRegistration . _Just

lsp-types/src/Language/LSP/Types/Registration.hs

@@ -111,7 +111,7 @@ data Registration (m :: Method FromClient t) =
     , _method :: SClientMethod m
       -- | Options necessary for the registration.
       -- Make this strict to aid the pattern matching exhaustiveness checker
-    , _registerOptions :: !(RegistrationOptions m)
+    , _registerOptions :: !(Maybe (RegistrationOptions m))
     }
   deriving Generic
 

lsp/src/Language/LSP/Server/Core.hs

@@ -503,7 +503,7 @@ registerCapability method regOpts f = do
       -- First, check to see if the client supports dynamic registration on this method
       | dynamicSupported clientCaps = do
           uuid <- liftIO $ UUID.toText <$> getStdRandom random
-          let registration = J.Registration uuid method regOpts
+          let registration = J.Registration uuid method (Just regOpts)
               params = J.RegistrationParams (J.List [J.SomeRegistration registration])
               regId = RegistrationId uuid
           rio <- askUnliftIO