force complete pattern in ghcide lib

Author: soulomoon

ghcide/ghcide.cabal

@@ -35,6 +35,7 @@ flag pedantic
 
 common warnings
   ghc-options:
+    -Werror=incomplete-patterns
     -Wall
     -Wincomplete-uni-patterns
     -Wunused-packages
@@ -43,6 +44,7 @@ common warnings
     -fno-ignore-asserts
 
 library
+  import: warnings
   default-language:   GHC2021
   build-depends:
     , aeson

ghcide/src/Development/IDE/GHC/CoreFile.hs

@@ -202,6 +202,7 @@ tcIfaceId = fmap getIfaceId . tcIfaceDecl False <=< unmangle_decl_name
         name' <- newIfaceName (mkVarOcc $ getOccString name)
         pure $ ifid{ ifName = name' }
       | otherwise = pure ifid
+    unmangle_decl_name _ifid = error $ "tcIfaceId: got non IfaceId: "
     -- invariant: 'IfaceId' is always a 'IfaceId' constructor
     getIfaceId (AnId identifier) = identifier
     getIfaceId _                 = error "tcIfaceId: got non Id"

ghcide/src/Development/IDE/GHC/Orphans.hs

@@ -60,6 +60,7 @@ instance NFData Unlinked where
   rnf (DotA f)   = rnf f
   rnf (DotDLL f) = rnf f
   rnf (BCOs a b) = seqCompiledByteCode a `seq` liftRnf rwhnf b
+  rnf  _         = error "rnf: not implemented for Unlinked"
 instance Show PackageFlag where show = unpack . printOutputable
 instance Show InteractiveImport where show = unpack . printOutputable
 instance Show PackageName  where show = unpack . printOutputable

ghcide/src/Development/IDE/LSP/Notifications.hs

@@ -41,7 +41,6 @@ import           Numeric.Natural
 data Log
   = LogShake Shake.Log
   | LogFileStore FileStore.Log
-  | LogOpenTextDocument !Uri
   | LogOpenedTextDocument !Uri
   | LogModifiedTextDocument !Uri
   | LogSavedTextDocument !Uri

srcipt.bash

@@ -0,0 +1,19 @@
+# recommended to build test binary separately and then run it in a loop (to avoid running cabal test in a loop)
+# cabal build hls-eval-plugin-tests
+# find dist-newstyle -name hls-eval-plugin-tests -type f
+# # ./dist-newstyle/build/x86_64-linux/ghc-9.4.8/haskell-language-server-2.7.0.0/t/hls-eval-plugin-tests/build/hls-eval-plugin-tests/hls-eval-plugin-tests
+# # Run tests in a loop
+for i in {1..500}; do
+    echo "Iteration $i" &&
+    # LSP_TEST_LOG_MESSAGES=0 LSP_TEST_LOG_STDERR=0 TASTY_PATTERN="Testing PluginError order" $(find dist-newstyle -name ghcide-tests -type f | head -n 1) \
+    LSP_TEST_LOG_MESSAGES=0 LSP_TEST_LOG_STDERR=0 TASTY_PATTERN="notification handlers run in priority order" $(find dist-newstyle -name ghcide-tests -type f | head -n 1) \
+    || {
+        # line_count=$(wc -l < test.txt)
+        # if (( line_count > 100 )); then
+        #     echo "Warning: More than 100 lines in test.txt at iteration $i"
+        #     break
+        # fi
+        echo "Warning: error at iteration $i"
+        break
+        }; done
+