Skip to content

Commit a339277

Browse files
jhrcekjhrcek
authored
Upgrade to latest lsp / lsp-types / lsp-test (#4166)
1 parent c7f8ced commit a339277

File tree

31 files changed

+214
-219
lines changed

31 files changed

+214
-219
lines changed

‎cabal.project‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ packages:
77
./hls-plugin-api
88
./hls-test-utils
99

10-
index-state: 2024-04-23T12:00:00Z
10+
index-state: 2024-04-30T10:44:19Z
1111

1212
tests: True
1313
test-show-details: direct

‎ghcide-bench/src/Experiments.hs‎

Lines changed: 32 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
{-# LANGUAGE GADTs #-}
33
{-# LANGUAGE ImplicitParams #-}
44
{-# LANGUAGE ImpredicativeTypes #-}
5-
{-# LANGUAGE OverloadedLabels #-}
65
{-# LANGUAGE OverloadedStrings #-}
76
{-# OPTIONS_GHC -Wno-deprecations -Wno-unticked-promoted-constructors #-}
87

@@ -43,7 +42,6 @@ import Data.Either (fromRight)
4342
import Data.List
4443
import Data.Maybe
4544
import Data.Proxy
46-
import Data.Row hiding (switch)
4745
import Data.Text (Text)
4846
import qualified Data.Text as T
4947
import Data.Version
@@ -71,15 +69,19 @@ import Text.Printf
7169

7270
charEdit :: Position -> TextDocumentContentChangeEvent
7371
charEdit p =
74-
TextDocumentContentChangeEvent $ InL $ #range .== Range p p
75-
.+ #rangeLength .== Nothing
76-
.+ #text .== "a"
72+
TextDocumentContentChangeEvent $ InL TextDocumentContentChangePartial
73+
{ _range = Range p p
74+
, _rangeLength = Nothing
75+
, _text = "a"
76+
}
7777

7878
headerEdit :: TextDocumentContentChangeEvent
7979
headerEdit =
80-
TextDocumentContentChangeEvent $ InL $ #range .== Range (Position 0 0) (Position 0 0)
81-
.+ #rangeLength .== Nothing
82-
.+ #text .== "-- header comment \n"
80+
TextDocumentContentChangeEvent $ InL TextDocumentContentChangePartial
81+
{ _range = Range (Position 0 0) (Position 0 0)
82+
, _rangeLength = Nothing
83+
, _text = "-- header comment \n"
84+
}
8385

8486
data DocumentPositions = DocumentPositions {
8587
-- | A position that can be used to generate non null goto-def and completion responses
@@ -240,9 +242,11 @@ experiments =
240242
benchWithSetup
241243
"hole fit suggestions"
242244
( mapM_ $ \DocumentPositions{..} -> do
243-
let edit = TextDocumentContentChangeEvent $ InL $ #range .== Range bottom bottom
244-
.+ #rangeLength .== Nothing
245-
.+ #text .== t
245+
let edit = TextDocumentContentChangeEvent $ InL TextDocumentContentChangePartial
246+
{ _range = Range bottom bottom
247+
, _rangeLength = Nothing
248+
, _text = t
249+
}
246250
bottom = Position maxBound 0
247251
t = T.unlines
248252
[""
@@ -270,9 +274,11 @@ experiments =
270274
benchWithSetup
271275
"eval execute single-line code lens"
272276
( mapM_ $ \DocumentPositions{..} -> do
273-
let edit = TextDocumentContentChangeEvent $ InL $ #range .== Range bottom bottom
274-
.+ #rangeLength .== Nothing
275-
.+ #text .== t
277+
let edit = TextDocumentContentChangeEvent $ InL TextDocumentContentChangePartial
278+
{ _range = Range bottom bottom
279+
, _rangeLength = Nothing
280+
, _text = t
281+
}
276282
bottom = Position maxBound 0
277283
t = T.unlines
278284
[ ""
@@ -295,9 +301,11 @@ experiments =
295301
benchWithSetup
296302
"eval execute multi-line code lens"
297303
( mapM_ $ \DocumentPositions{..} -> do
298-
let edit = TextDocumentContentChangeEvent $ InL $ #range .== Range bottom bottom
299-
.+ #rangeLength .== Nothing
300-
.+ #text .== t
304+
let edit = TextDocumentContentChangeEvent $ InL TextDocumentContentChangePartial
305+
{ _range = Range bottom bottom
306+
, _rangeLength = Nothing
307+
, _text = t
308+
}
301309
bottom = Position maxBound 0
302310
t = T.unlines
303311
[ ""
@@ -551,7 +559,7 @@ runBenchmarksFun dir allBenchmarks = do
551559
lspTestCaps =
552560
fullCaps
553561
& (L.window . _Just) .~ WindowClientCapabilities (Just True) Nothing Nothing
554-
& (L.textDocument . _Just . L.codeAction . _Just . L.resolveSupport . _Just) .~ (#properties .== ["edit"])
562+
& (L.textDocument . _Just . L.codeAction . _Just . L.resolveSupport . _Just) .~ (ClientCodeActionResolveOptions ["edit"])
555563
& (L.textDocument . _Just . L.codeAction . _Just . L.dataSupport . _Just) .~ True
556564

557565
showMs :: Seconds -> String
@@ -755,10 +763,12 @@ setupDocumentContents config =
755763

756764
-- Setup the special positions used by the experiments
757765
lastLine <- fromIntegral . length . T.lines <$> documentContents doc
758-
changeDoc doc [TextDocumentContentChangeEvent $ InL
759-
$ #range .== Range (Position lastLine 0) (Position lastLine 0)
760-
.+ #rangeLength .== Nothing
761-
.+ #text .== T.unlines [ "_hygienic = \"hygienic\"" ]]
766+
changeDoc doc [TextDocumentContentChangeEvent $ InL TextDocumentContentChangePartial
767+
{ _range = Range (Position lastLine 0) (Position lastLine 0)
768+
, _rangeLength = Nothing
769+
, _text = T.unlines [ "_hygienic = \"hygienic\"" ]
770+
}
771+
]
762772
let
763773
-- Points to a string in the target file,
764774
-- convenient for hygienic edits

‎ghcide/ghcide.cabal‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ library
8686
, implicit-hie >= 0.1.4.0 && < 0.1.5
8787
, lens
8888
, list-t
89-
, lsp ^>=2.4.0.0
90-
, lsp-types ^>=2.1.0.0
89+
, lsp ^>=2.5.0.0
90+
, lsp-types ^>=2.2.0.0
9191
, mtl
9292
, opentelemetry >=0.6.1
9393
, optparse-applicative

‎ghcide/src/Development/IDE/Core/PositionMapping.hs‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
{-# LANGUAGE OverloadedLabels #-}
21
-- Copyright (c) 2019 The DAML Authors. All rights reserved.
32
-- SPDX-License-Identifier: Apache-2.0
43
module Development.IDE.Core.PositionMapping
@@ -25,13 +24,15 @@ module Development.IDE.Core.PositionMapping
2524
) where
2625

2726
import Control.DeepSeq
27+
import Control.Lens ((^.))
2828
import Control.Monad
2929
import Data.Algorithm.Diff
3030
import Data.Bifunctor
3131
import Data.List
3232
import Data.Row
3333
import qualified Data.Text as T
3434
import qualified Data.Vector.Unboxed as V
35+
import qualified Language.LSP.Protocol.Lens as L
3536
import Language.LSP.Protocol.Types (Position (Position),
3637
Range (Range),
3738
TextDocumentContentChangeEvent (TextDocumentContentChangeEvent),
@@ -131,8 +132,8 @@ addOldDelta delta (PositionMapping pm) = PositionMapping (composeDelta pm delta)
131132
-- that was what was done with lsp* 1.6 packages
132133
applyChange :: PositionDelta -> TextDocumentContentChangeEvent -> PositionDelta
133134
applyChange PositionDelta{..} (TextDocumentContentChangeEvent (InL x)) = PositionDelta
134-
{ toDelta = toCurrent (x .! #range) (x .! #text) <=< toDelta
135-
, fromDelta = fromDelta <=< fromCurrent (x .! #range) (x .! #text)
135+
{ toDelta = toCurrent (x ^. L.range) (x ^. L.text) <=< toDelta
136+
, fromDelta = fromDelta <=< fromCurrent (x ^. L.range) (x ^. L.text)
136137
}
137138
applyChange posMapping _ = posMapping
138139

‎ghcide/src/Development/IDE/Plugin/Completions/Logic.hs‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
{-# LANGUAGE DuplicateRecordFields #-}
33
{-# LANGUAGE GADTs #-}
44
{-# LANGUAGE MultiWayIf #-}
5-
{-# LANGUAGE OverloadedLabels #-}
65

76
-- Mostly taken from "haskell-ide-engine"
87
module Development.IDE.Plugin.Completions.Logic (
@@ -530,7 +529,7 @@ toggleSnippets ClientCapabilities {_textDocument} CompletionsConfig{..} =
530529
removeSnippetsWhen (not $ enableSnippets && supported)
531530
where
532531
supported =
533-
Just True == (_textDocument >>= _completion >>= view L.completionItem >>= (\x -> x .! #snippetSupport))
532+
Just True == (_textDocument >>= _completion >>= view L.completionItem >>= view L.snippetSupport)
534533

535534
toggleAutoExtend :: CompletionsConfig -> CompItem -> CompItem
536535
toggleAutoExtend CompletionsConfig{enableAutoExtend=False} x = x {additionalTextEdits = Nothing}

‎ghcide/test/exe/CompletionTests.hs‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import Control.Monad.IO.Class (liftIO)
1515
import Data.Default
1616
import Data.List.Extra
1717
import Data.Maybe
18-
import Data.Row
1918
import qualified Data.Text as T
2019
import Development.IDE.GHC.Compat (GhcVersion (..), ghcVersion)
2120
import Development.IDE.Types.Location
@@ -205,7 +204,7 @@ localCompletionTests = [
205204
doc <- createDoc "A.hs" "haskell" $ src "AAA"
206205
void $ waitForTypecheck doc
207206
let editA rhs =
208-
changeDoc doc [TextDocumentContentChangeEvent . InR . (.==) #text $ src rhs]
207+
changeDoc doc [TextDocumentContentChangeEvent . InR . TextDocumentContentChangeWholeDocument $ src rhs]
209208
editA "AAAA"
210209
void $ waitForTypecheck doc
211210
editA "AAAAA"

‎ghcide/test/exe/CradleTests.hs‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11

2-
{-# LANGUAGE GADTs #-}
3-
{-# LANGUAGE OverloadedLabels #-}
2+
{-# LANGUAGE GADTs #-}
43

54
module CradleTests (tests) where
65

76
import Control.Applicative.Combinators
87
import Control.Monad.IO.Class (liftIO)
9-
import Data.Row
108
import qualified Data.Text as T
119
import Development.IDE.GHC.Compat (GhcVersion (..))
1210
import Development.IDE.GHC.Util
@@ -63,7 +61,7 @@ loadCradleOnlyonce = testGroup "load cradle only once"
6361
doc <- createDoc "B.hs" "haskell" "module B where\nimport Data.Foo"
6462
msgs <- someTill (skipManyTill anyMessage cradleLoadedMessage) (skipManyTill anyMessage (message SMethod_TextDocumentPublishDiagnostics))
6563
liftIO $ length msgs @?= 1
66-
changeDoc doc [TextDocumentContentChangeEvent . InR . (.==) #text $ "module B where\nimport Data.Maybe"]
64+
changeDoc doc [TextDocumentContentChangeEvent . InR . TextDocumentContentChangeWholeDocument $ "module B where\nimport Data.Maybe"]
6765
msgs <- manyTill (skipManyTill anyMessage cradleLoadedMessage) (skipManyTill anyMessage (message SMethod_TextDocumentPublishDiagnostics))
6866
liftIO $ length msgs @?= 0
6967
_ <- createDoc "A.hs" "haskell" "module A where\nimport LoadCradleBar"
@@ -222,9 +220,11 @@ sessionDepsArePickedUp = testSession'
222220
[FileEvent (filePathToUri $ dir </> "hie.yaml") FileChangeType_Changed ]
223221
-- Send change event.
224222
let change =
225-
TextDocumentContentChangeEvent $ InL $ #range .== Range (Position 4 0) (Position 4 0)
226-
.+ #rangeLength .== Nothing
227-
.+ #text .== "\n"
223+
TextDocumentContentChangeEvent $ InL TextDocumentContentChangePartial
224+
{ _range = Range (Position 4 0) (Position 4 0)
225+
, _rangeLength = Nothing
226+
, _text = "\n"
227+
}
228228
changeDoc doc [change]
229229
-- Now no errors.
230230
expectDiagnostics [("Foo.hs", [])]

‎ghcide/test/exe/DependentFileTest.hs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11

2-
{-# LANGUAGE GADTs #-}
3-
{-# LANGUAGE OverloadedLabels #-}
2+
{-# LANGUAGE GADTs #-}
43

54
module DependentFileTest (tests) where
65

76
import Config
87
import Control.Monad.IO.Class (liftIO)
9-
import Data.Row
108
import qualified Data.Text as T
119
import Development.IDE.Test (expectDiagnostics)
1210
import Development.IDE.Types.Location
@@ -52,8 +50,10 @@ tests = testGroup "addDependentFile"
5250
[FileEvent (filePathToUri "dep-file.txt") FileChangeType_Changed ]
5351

5452
-- Modifying Baz will now trigger Foo to be rebuilt as well
55-
let change = TextDocumentContentChangeEvent $ InL $ #range .== Range (Position 2 0) (Position 2 6)
56-
.+ #rangeLength .== Nothing
57-
.+ #text .== "f = ()"
53+
let change = TextDocumentContentChangeEvent $ InL TextDocumentContentChangePartial
54+
{ _range = Range (Position 2 0) (Position 2 6)
55+
, _rangeLength = Nothing
56+
, _text = "f = ()"
57+
}
5858
changeDoc doc [change]
5959
expectDiagnostics [("Foo.hs", [])]

0 commit comments

Comments
 (0)