Error on unused-top-binds in tests (#1030)

This guards against defining a test or benchmark but forgetting to
include it in the test tree.

Author: meooow25

containers-tests/containers-tests.cabal

@@ -40,6 +40,9 @@ common deps
     , deepseq  >=1.2     && <1.6
     , template-haskell
 
+common warnings
+  ghc-options: -Werror=unused-top-binds
+
 common test-deps
   import: deps
   build-depends:
@@ -140,39 +143,39 @@ library
 -----------------------------
 
 benchmark intmap-benchmarks
-  import: benchmark-deps
+  import: benchmark-deps, warnings
   default-language: Haskell2010
   type:           exitcode-stdio-1.0
   hs-source-dirs: benchmarks
   main-is:        IntMap.hs
   ghc-options:    -O2
 
 benchmark intset-benchmarks
-  import: benchmark-deps
+  import: benchmark-deps, warnings
   default-language: Haskell2010
   type:           exitcode-stdio-1.0
   hs-source-dirs: benchmarks
   main-is:        IntSet.hs
   ghc-options:    -O2
 
 benchmark map-benchmarks
-  import: benchmark-deps
+  import: benchmark-deps, warnings
   default-language: Haskell2010
   type:           exitcode-stdio-1.0
   hs-source-dirs: benchmarks
   main-is:        Map.hs
   ghc-options:    -O2
 
 benchmark tree-benchmarks
-  import: benchmark-deps
+  import: benchmark-deps, warnings
   default-language: Haskell2010
   type:           exitcode-stdio-1.0
   hs-source-dirs: benchmarks
   main-is:        Tree.hs
   ghc-options:    -O2
 
 benchmark sequence-benchmarks
-  import: benchmark-deps
+  import: benchmark-deps, warnings
   default-language: Haskell2010
   type:           exitcode-stdio-1.0
   hs-source-dirs: benchmarks
@@ -183,15 +186,15 @@ benchmark sequence-benchmarks
     , transformers
 
 benchmark set-benchmarks
-  import: benchmark-deps
+  import: benchmark-deps, warnings
   default-language: Haskell2010
   type:           exitcode-stdio-1.0
   hs-source-dirs: benchmarks
   main-is:        Set.hs
   ghc-options:    -O2
 
 benchmark graph-benchmarks
-  import: benchmark-deps
+  import: benchmark-deps, warnings
   default-language: Haskell2010
   type:           exitcode-stdio-1.0
   hs-source-dirs: benchmarks
@@ -201,7 +204,7 @@ benchmark graph-benchmarks
       random            >=0       && <1.2
 
 benchmark set-operations-intmap
-  import: benchmark-deps
+  import: benchmark-deps, warnings
   default-language: Haskell2010
   type:           exitcode-stdio-1.0
   hs-source-dirs: benchmarks/SetOperations
@@ -210,7 +213,7 @@ benchmark set-operations-intmap
   ghc-options:    -O2
 
 benchmark set-operations-intset
-  import: benchmark-deps
+  import: benchmark-deps, warnings
   default-language: Haskell2010
   type:           exitcode-stdio-1.0
   hs-source-dirs: benchmarks/SetOperations
@@ -219,7 +222,7 @@ benchmark set-operations-intset
   ghc-options:    -O2
 
 benchmark set-operations-map
-  import: benchmark-deps
+  import: benchmark-deps, warnings
   default-language: Haskell2010
   type:           exitcode-stdio-1.0
   hs-source-dirs: benchmarks/SetOperations
@@ -228,7 +231,7 @@ benchmark set-operations-map
   ghc-options:    -O2
 
 benchmark set-operations-set
-  import: benchmark-deps
+  import: benchmark-deps, warnings
   default-language: Haskell2010
   type:           exitcode-stdio-1.0
   hs-source-dirs: benchmarks/SetOperations
@@ -237,7 +240,7 @@ benchmark set-operations-set
   ghc-options:    -O2
 
 benchmark lookupge-intmap
-  import: benchmark-deps
+  import: benchmark-deps, warnings
   default-language: Haskell2010
   type:           exitcode-stdio-1.0
   hs-source-dirs: benchmarks/LookupGE
@@ -246,7 +249,7 @@ benchmark lookupge-intmap
   build-depends:  containers-tests
 
 benchmark lookupge-map
-  import: benchmark-deps
+  import: benchmark-deps, warnings
   default-language: Haskell2010
   type:           exitcode-stdio-1.0
   hs-source-dirs: benchmarks/LookupGE
@@ -263,7 +266,7 @@ benchmark lookupge-map
 -- plus the testing stuff.
 
 test-suite map-lazy-properties
-  import: test-deps
+  import: test-deps, warnings
   default-language: Haskell2010
   hs-source-dirs:   tests
   main-is:          map-properties.hs
@@ -275,7 +278,7 @@ test-suite map-lazy-properties
     CPP
 
 test-suite map-strict-properties
-  import: test-deps
+  import: test-deps, warnings
   default-language: Haskell2010
   hs-source-dirs:   tests
   main-is:          map-properties.hs
@@ -288,7 +291,7 @@ test-suite map-strict-properties
     CPP
 
 test-suite bitqueue-properties
-  import: test-deps
+  import: test-deps, warnings
   default-language: Haskell2010
   hs-source-dirs:   tests
   main-is:          bitqueue-properties.hs
@@ -299,7 +302,7 @@ test-suite bitqueue-properties
     CPP
 
 test-suite set-properties
-  import: test-deps
+  import: test-deps, warnings
   default-language: Haskell2010
   hs-source-dirs:   tests
   main-is:          set-properties.hs
@@ -317,7 +320,7 @@ test-suite set-properties
       Utils.NoThunks
 
 test-suite intmap-lazy-properties
-  import: test-deps
+  import: test-deps, warnings
   default-language: Haskell2010
   hs-source-dirs:   tests
   main-is:          intmap-properties.hs
@@ -330,7 +333,7 @@ test-suite intmap-lazy-properties
     CPP
 
 test-suite intmap-strict-properties
-  import: test-deps
+  import: test-deps, warnings
   default-language: Haskell2010
   hs-source-dirs:   tests
   main-is:          intmap-properties.hs
@@ -344,7 +347,7 @@ test-suite intmap-strict-properties
     CPP
 
 test-suite intset-properties
-  import: test-deps
+  import: test-deps, warnings
   default-language: Haskell2010
   hs-source-dirs:   tests
   main-is:          intset-properties.hs
@@ -357,7 +360,7 @@ test-suite intset-properties
     CPP
 
 test-suite seq-properties
-  import: test-deps
+  import: test-deps, warnings
   default-language: Haskell2010
   hs-source-dirs:   tests
   main-is:          seq-properties.hs
@@ -369,7 +372,7 @@ test-suite seq-properties
     CPP
 
 test-suite tree-properties
-  import: test-deps
+  import: test-deps, warnings
   default-language: Haskell2010
   hs-source-dirs:   tests
   main-is:          tree-properties.hs
@@ -381,15 +384,15 @@ test-suite tree-properties
     CPP
 
 test-suite graph-properties
-  import: test-deps
+  import: test-deps, warnings
   default-language: Haskell2010
   hs-source-dirs:   tests
   main-is:          graph-properties.hs
   type:             exitcode-stdio-1.0
   ghc-options:      -O2
 
 test-suite map-strictness-properties
-  import: test-deps
+  import: test-deps, warnings
   default-language: Haskell2010
   hs-source-dirs:   tests
   main-is:          map-strictness.hs
@@ -412,7 +415,7 @@ test-suite map-strictness-properties
       Utils.NoThunks
 
 test-suite intmap-strictness-properties
-  import: test-deps
+  import: test-deps, warnings
   default-language: Haskell2010
   hs-source-dirs:   tests
   main-is:          intmap-strictness.hs
@@ -436,7 +439,7 @@ test-suite intmap-strictness-properties
       Utils.NoThunks
 
 test-suite intset-strictness-properties
-  import: test-deps
+  import: test-deps, warnings
   default-language: Haskell2010
   hs-source-dirs:   tests
   main-is:          intset-strictness.hs
@@ -457,7 +460,7 @@ test-suite intset-strictness-properties
       Utils.NoThunks
 
 test-suite listutils-properties
-  import: test-deps
+  import: test-deps, warnings
   default-language: Haskell2010
   hs-source-dirs: tests
   main-is:        listutils-properties.hs

containers-tests/tests/intmap-properties.hs

@@ -216,13 +216,6 @@ main = defaultMain $ testGroup "intmap-properties"
              , testProperty "isSubmapOfBy"         prop_isSubmapOfBy
              ]
 
-apply2 :: Fun (a, b) c -> a -> b -> c
-apply2 f a b = apply f (a, b)
-
-apply3 :: Fun (a, b, c) d -> a -> b -> c -> d
-apply3 f a b c = apply f (a, b, c)
-
-
 {--------------------------------------------------------------------
   Arbitrary, reasonably balanced trees
 --------------------------------------------------------------------}

containers-tests/tests/intset-properties.hs

@@ -67,6 +67,8 @@ main = defaultMain $ testGroup "intset-properties"
                    , testProperty "prop_foldL" prop_foldL
                    , testProperty "prop_foldL'" prop_foldL'
                    , testProperty "prop_map" prop_map
+                   , testProperty "prop_mapMonotonicId" prop_mapMonotonicId
+                   , testProperty "prop_mapMonotonicLinear" prop_mapMonotonicLinear
                    , testProperty "prop_maxView" prop_maxView
                    , testProperty "prop_minView" prop_minView
                    , testProperty "prop_split" prop_split
@@ -389,9 +391,15 @@ prop_mapMonotonicId :: IntSet -> Property
 prop_mapMonotonicId s = mapMonotonic id s === map id s
 
 prop_mapMonotonicLinear :: Positive Int -> Int -> IntSet -> Property
-prop_mapMonotonicLinear (Positive a) b s = mapMonotonic f s === map f s
+prop_mapMonotonicLinear (Positive a) b s =
+  all ok (toList s) ==>
+    mapMonotonic f s === map f s
   where
     f x = a*x + b
+    ok x =  -- must not overflow
+      fromIntegral (minBound :: Int) <= y && y <= fromIntegral (maxBound :: Int)
+      where
+        y = fromIntegral a * fromIntegral x + fromIntegral b :: Integer
 
 prop_maxView :: IntSet -> Bool
 prop_maxView s = case maxView s of

containers-tests/tests/map-properties.hs

@@ -345,8 +345,7 @@ mkArb step n
 -- A type with a peculiar Eq instance designed to make sure keys
 -- come from where they're supposed to.
 data OddEq a = OddEq a Bool deriving (Show)
-getOddEq :: OddEq a -> (a, Bool)
-getOddEq (OddEq a b) = (a, b)
+
 instance Arbitrary a => Arbitrary (OddEq a) where
   arbitrary = OddEq <$> arbitrary <*> arbitrary
 instance Eq a => Eq (OddEq a) where

containers-tests/tests/seq-properties.hs

@@ -562,10 +562,8 @@ prop_sort :: Seq OrdA -> Bool
 prop_sort xs =
     toList' (sort xs) ~= Data.List.sort (toList xs)
 
-data UnstableOrd = UnstableOrd
-    { ordKey :: OrdA
-    , _ignored :: A
-    } deriving (Show)
+data UnstableOrd = UnstableOrd OrdA A
+    deriving (Show)
 
 instance Eq UnstableOrd where
     x == y = compare x y == EQ