Update k8s_secret.go

Author: arybolovlev

workspacehelper/k8s_secret.go

@@ -11,22 +11,14 @@ import (
 
 // GetSecretData retrieves the data from a secret in a given namespace
 func (r *WorkspaceHelper) GetSecretData(namespace string, name string) (map[string][]byte, error) {
-	// If no secretName defined, return empty map
-	if name == "" {
-		return make(map[string][]byte), nil
-	}
-
 	r.reqLogger.Info("Getting Secret", "Namespace", namespace, "Name", name)
 
 	secret := &corev1.Secret{}
 	err := r.client.Get(context.TODO(), types.NamespacedName{Name: name, Namespace: namespace}, secret)
-
 	if err != nil {
 		r.reqLogger.Error(err, "Failed to get Secret", "Namespace", namespace, "Name", name)
-
 		return nil, err
 	}
-
 	return secret.Data, nil
 }
 
@@ -38,9 +30,7 @@ func (r *WorkspaceHelper) GetSecretForVariable(namespace string, variable *v1alp
 
 	if variable.ValueFrom.SecretKeyRef == nil {
 		err := errors.New("Include Secret in ValueFrom")
-
 		r.reqLogger.Error(err, "No Secret specified", "Namespace", namespace, "Variable", variable.Key)
-
 		return err
 	}
 
@@ -57,13 +47,10 @@ func (r *WorkspaceHelper) GetSecretForVariable(namespace string, variable *v1alp
 	value, ok := data[key]
 	if !ok {
 		err := errors.New("Include Secret key reference in ValueFrom")
-
 		r.reqLogger.Error(err, "No Secret key specified", "Namespace", namespace, "Name", name, "Key", key)
-
 		return err
 	}
 
 	variable.Value = string(value)
-
 	return nil
 }