You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Address PR feedback: Clarify RDS database usage for passwordless authentication
Added comments to address reviewer feedback about postgres-passwordless module usage:
1. **Using RDS, not EC2+Docker**: The current configuration correctly uses the
standard RDS database module (./modules/database) which creates aws_db_instance
with native IAM authentication support via enable_iam_database_authentication.
2. **postgres-passwordless module not used**: The postgres-passwordless module
creates an EC2 instance with PostgreSQL in Docker, which is not suitable for
production use cases. RDS is the correct approach.
3. **IAM authentication properly configured**:
- RDS: enable_iam_database_authentication = true when passwordless requested
- TFE: database_passwordless_aws_use_iam passed to runtime configuration
- Region: database_passwordless_aws_region set for AWS authentication
This follows the standard AWS best practice of using managed RDS services
with IAM database authentication rather than self-managed PostgreSQL on EC2.
0 commit comments