Skip to content

🛠️ Convert helper ginkgo tests to regular unit tests #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2025
Merged

🛠️ Convert helper ginkgo tests to regular unit tests #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4289a7b
TFECO-10811 Replace ginkgo tests with testify/assert unit tests
Shweta-Deshpande Oct 14, 2025
ab33560
Add new make target for unit tests
Shweta-Deshpande Oct 25, 2025
7d5c32d
Update dependency
Shweta-Deshpande Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/unit-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,4 @@ jobs:
run: |
make test-api
make test-internal
make test-unit
8 changes: 8 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,14 @@ test-internal: fmt vet copywrite ## Run internal/* tests.
./internal/pointer \
./internal/slice

.PHONY: test-unit
test-unit: fmt vet copywrite ## Run internal/controller tests.
go test ./internal/controller/... \
-timeout 5m \
-count 1 \
-v \
-run="^Test(DoNotRequeue|RequeueAfter|RequeueOnErr|FormatOutput|FinalizerBehaviors|MatchWildcardName|ValidateTFEVersion)$$"

.PHONY: test-helm
test-helm: ## Run Helm chart tests.
cd charts/test; go test -timeout 5m -count=1 -v ./...
Expand Down
1 change: 1 addition & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ require (
github.com/onsi/ginkgo/v2 v2.23.4
github.com/onsi/gomega v1.36.3
github.com/prometheus/client_golang v1.22.0
github.com/stretchr/testify v1.11.1
go.uber.org/zap v1.27.0
k8s.io/api v0.34.1
k8s.io/apimachinery v0.34.1
Expand Down
Loading
Loading