Skip to content

Conversation

@Shweta-Deshpande
Copy link
Contributor

@Shweta-Deshpande Shweta-Deshpande commented Oct 22, 2025

Rollback Plan

N/A

Changes to Security Controls

No

Description

The helpers_tests.go file does not need a ginkgo and gomega framework to execute the tests since they are simple unit tests, testing internal helper functions. This PR will modify them to be regular unit tests which will run in parallel and table driven format. Replaced ginkgo's Expect.To()with testify/assert.

Usage Example

N/A

References

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@Shweta-Deshpande Shweta-Deshpande requested a review from a team as a code owner October 22, 2025 22:35
@github-actions github-actions bot added dependencies Pull requests that update a dependency file golang controller test size/XL labels Oct 22, 2025
@Shweta-Deshpande Shweta-Deshpande changed the title TFECO-10811 Convert helper ginkgo tests to regular unit tests 🛠️ TFECO-10811 Convert helper ginkgo tests to regular unit tests Oct 22, 2025
@arybolovlev arybolovlev changed the title 🛠️ TFECO-10811 Convert helper ginkgo tests to regular unit tests 🛠️ Convert helper ginkgo tests to regular unit tests Oct 23, 2025
Copy link
Collaborator

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change!

I think it would make sense to update it right after #641 is merged, since that PR changes the name of the function covered by one of these tests.

Another point: these tests are currently not being executed. You will need to add a new make target -- my suggestion would be test-unit -- and also update the corresponding GitHub Action to ensure this new target runs when needed.

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Oct 25, 2025
@Shweta-Deshpande
Copy link
Contributor Author

Thanks for making this change!

I think it would make sense to update it right after #641 is merged, since that PR changes the name of the function covered by one of these tests.

Another point: these tests are currently not being executed. You will need to add a new make target -- my suggestion would be test-unit -- and also update the corresponding GitHub Action to ensure this new target runs when needed.

Done

arybolovlev
arybolovlev previously approved these changes Nov 19, 2025
@arybolovlev
Copy link
Collaborator

A tiny change, a giant leap for this project. 👍🏻

@Shweta-Deshpande Shweta-Deshpande merged commit f4952ed into main Nov 19, 2025
7 checks passed
@Shweta-Deshpande Shweta-Deshpande deleted the TFECO-10811 branch November 19, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

controller dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code golang size/XL test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants