-
Notifications
You must be signed in to change notification settings - Fork 41
🛠️ Convert helper ginkgo tests to regular unit tests #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6908017 to
8011e1c
Compare
arybolovlev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change!
I think it would make sense to update it right after #641 is merged, since that PR changes the name of the function covered by one of these tests.
Another point: these tests are currently not being executed. You will need to add a new make target -- my suggestion would be test-unit -- and also update the corresponding GitHub Action to ensure this new target runs when needed.
8011e1c to
937f28f
Compare
Done |
0140f40 to
ab33560
Compare
|
A tiny change, a giant leap for this project. 👍🏻 |
Rollback Plan
N/A
Changes to Security Controls
No
Description
The helpers_tests.go file does not need a ginkgo and gomega framework to execute the tests since they are simple unit tests, testing internal helper functions. This PR will modify them to be regular unit tests which will run in parallel and table driven format. Replaced ginkgo's Expect.To()with testify/assert.
Usage Example
N/A
References
Community Note