Maint (#78)

* FFM-8544 Fix logger

* FFM-8544 Fix logger

Author: erdirowlands

featureflags/sdk_logging_codes.py

@@ -27,7 +27,7 @@ def get_sdk_code_message(key):
         5002: "SSE event received: ",
         5003: "SSE retrying to connect in",
         5004: "SSE stopped",
-        5005: "Stream is still retrying after 5 retries: ",
+        5005: "Stream is still retrying after 5 retries",
         # SDK_EVAL_6xxx - these are hardcoded in `variation.py` as they
         # are more complex
         # SDK_METRICS_7xxx
@@ -146,8 +146,8 @@ def warn_stream_retrying(seconds):
     log.warning(sdk_err_msg(5003, seconds))
 
 
-def warn_stream_retrying_long_duration(seconds):
-    log.warning(sdk_err_msg(5005, f'{seconds} seconds'))
+def warn_stream_retrying_long_duration():
+    log.warning(sdk_err_msg(5005))
 
 
 def warn_post_metrics_failed(reason):

featureflags/streaming.py

@@ -75,8 +75,7 @@ def run(self):
                 # we log an error to the user
                 retry_error_log_threshold = 4
                 if retries >= retry_error_log_threshold:
-                    warn_stream_retrying_long_duration(
-                        retry_error_log_threshold)
+                    warn_stream_retrying_long_duration()
 
                 # Calculate back of sleep
                 sleep = (BACK_OFF_IN_SECONDS * 2 ** retries +

tests/unit/test_sdk_logging_codes.py

@@ -25,7 +25,7 @@ def test_logs_dont_raise_exception():
     sdk_codes.warn_auth_retying(1, "some error")
     sdk_codes.warn_stream_disconnected("example reason")
     sdk_codes.warn_stream_retrying(5)
-    sdk_codes.warn_stream_retrying_long_duration(5)
+    sdk_codes.warn_stream_retrying_long_duration()
     sdk_codes.warn_post_metrics_failed("example reason")
     sdk_codes.warn_post_metrics_target_batch_failed("example reason")
     sdk_codes.warn_default_variation_served("identifier", target, "default")