FFM-9866 Flag/Segment not found warning change (#84)

erdirowlands · web-flow · commit 2b331352dc88 · 2023-11-08T12:22:44.000Z
diff --git a/examples/bool_variation_example/bool_variation.py b/examples/bool_variation_example/bool_variation.py
@@ -1,20 +1,26 @@
+import logging
 import time
 
 from featureflags.evaluations.auth_target import Target
 from featureflags.client import CfClient
 from featureflags.util import log
 
+
 def main():
-    log.debug("Starting example")
+    log.setLevel(logging.INFO)
+    log.info("Starting example")
     api_key = "Your API Key"
     client = CfClient(api_key)
 
-    target = Target(identifier='HT_1', name="Harness_Target_1", attributes={"location": "emea"})
+    target = Target(identifier='HT_1', name="Harness_Target_1",
+                    attributes={"location": "emea"})
 
     while True:
-        result = client.bool_variation('identifier_of_your_bool_flag', target, False)
-        log.debug("Result %s", result)
+        result = client.bool_variation('identifier_of_your_bool_flag', target,
+                                       False)
+        log.info("Result %s", result)
         time.sleep(10)
 
+
 if __name__ == "__main__":
     main()
diff --git a/examples/cleanup_example/cleanup.py b/examples/cleanup_example/cleanup.py
@@ -1,22 +1,27 @@
+import logging
 import time
 
 from featureflags.evaluations.auth_target import Target
 from featureflags.client import CfClient
 from featureflags.util import log
 
+
 def main():
-    log.debug("Starting example")
+    log.setLevel(logging.INFO)
+    log.info("Starting example")
     api_key = "Your API key"
     client = CfClient(api_key)
 
-    target = Target(identifier='HT_1', name="Harness_Target_1", attributes={"location": "emea"})
+    target = Target(identifier='HT_1', name="Harness_Target_1",
+                    attributes={"location": "emea"})
 
     for x in range(10):
         result = client.bool_variation('harnessappdemodarkmode', target, False)
-        log.debug("Result %s", result)
+        log.info("Result %s", result)
         time.sleep(10)
 
     client.close()
 
+
 if __name__ == "__main__":
     main()
diff --git a/examples/getting_started/getting_started.py b/examples/getting_started/getting_started.py
@@ -1,3 +1,5 @@
+import logging
+
 from featureflags.client import CfClient
 from featureflags.config import *
 from featureflags.evaluations.auth_target import Target
@@ -13,6 +15,7 @@
 flagName = os.getenv('FF_FLAG_NAME', "harnessappdemodarkmode")
 
 def main():
+    log.setLevel(logging.INFO)
     log.info("Harness SDK Getting Started")
     # Create a Feature Flag Client
     client = CfClient(api_key)
diff --git a/examples/json_variation_example/json_variation.py b/examples/json_variation_example/json_variation.py
@@ -1,19 +1,21 @@
+import logging
 import time
 
 from featureflags.evaluations.auth_target import Target
 from featureflags.client import CfClient
 from featureflags.util import log
 
 def main():
-    log.debug("Starting example")
+    log.setLevel(logging.INFO)
+    log.info("Starting example")
     api_key = "Your API Key"
     client = CfClient(api_key)
 
     target = Target(identifier='HT_1', name="Harness_Target_1", attributes={"location": "emea"})
 
     while True:
         result = client.json_variation('identifier_of_your_json_flag', target, {})
-        log.debug("Result %s", result)
+        log.info("Result %s", result)
         time.sleep(10)
 
 if __name__ == "__main__":
diff --git a/examples/number_variation_example/number_variation.py b/examples/number_variation_example/number_variation.py
@@ -1,19 +1,21 @@
+import logging
 import time
 
 from featureflags.evaluations.auth_target import Target
 from featureflags.client import CfClient
 from featureflags.util import log
 
 def main():
-    log.debug("Starting example")
+    log.setLevel(logging.INFO)
+    log.info("Starting example")
     api_key = "Your API Key"
     client = CfClient(api_key)
 
     target = Target(identifier='harness')
 
     while True:
         result = client.number_variation('identifier_of_your_number_flag', target, -1)
-        log.debug("Result %s", result)
+        log.info("Result %s", result)
         time.sleep(10)
 
 if __name__ == "__main__":
diff --git a/examples/simple_example/simple_example.py b/examples/simple_example/simple_example.py
@@ -1,3 +1,4 @@
+import logging
 import os
 import time
 
@@ -8,19 +9,26 @@
 
 api_key = os.getenv('FF_API_KEY', "")
 
+
 def main():
+
+    log.setLevel(logging.INFO)
+    api_key = "Your API Key"
+
     # Create a Feature Flag Client
     client = CfClient(apiKey)
 
-    # Create a target (different targets can get different results based on rules that you add in the UI).  
-    target = Target(identifier='HT_1', name="Harness_Target_1", attributes={"location": "emea"})
+    # Create a target (different targets can get different results based on
+    # rules that you add in the UI).
+    target = Target(identifier='HT_1', name="Harness_Target_1",
+                    attributes={"location": "emea"})
 
-    # Loop forever reporting the state of the flag.  If there is an error the default value will be returned
+    # Loop forever reporting the state of the flag.  If there is an error
+    # the default value will be returned
     while True:
         result = client.bool_variation('harnessappdemodarkmode', target, False)
         log.info("Flag variation %s", result)
         time.sleep(10)
-           
 
 
 if __name__ == "__main__":
diff --git a/examples/string_variation_example/string_variation.py b/examples/string_variation_example/string_variation.py
@@ -1,19 +1,21 @@
+import logging
 import time
 
 from featureflags.evaluations.auth_target import Target
 from featureflags.client import CfClient
 from featureflags.util import log
 
 def main():
-    log.debug("Starting example")
+    log.setLevel(logging.INFO)
+    log.info("Starting example")
     api_key = "Your API Key"
     client = CfClient(api_key)
 
     target = Target(identifier='harness')
 
     while True:
         result = client.string_variation('identifier_of_your_string_flag', target, "")
-        log.debug("Result %s", result)
+        log.info("Result %s", result)
         time.sleep(10)
 
 if __name__ == "__main__":
diff --git a/examples/url_change_example/env.zip b/examples/url_change_example/env.zip
diff --git a/examples/url_change_example/url_change.py b/examples/url_change_example/url_change.py
@@ -1,3 +1,4 @@
+import logging
 import os
 import time
 
@@ -9,7 +10,8 @@
 
 
 def main():
-    log.debug("Starting example")
+    log.setLevel(logging.INFO)
+    log.info("Starting example")
     api_key = os.getenv('FF_API_KEY', "")
     client = CfClient(api_key,
                       with_base_url("https://config.ff.harness.io/api/1.0"),
@@ -19,7 +21,7 @@ def main():
 
     while True:
         result = client.bool_variation('harnessappdemodarkmode', target, False)
-        log.debug("Result %s", result)
+        log.info("Result %s", result)
         time.sleep(10)
 
 if __name__ == "__main__":
diff --git a/examples/wait_for_initialization_example/wait_for_initialization.py b/examples/wait_for_initialization_example/wait_for_initialization.py
@@ -1,3 +1,4 @@
+import logging
 import time
 
 from featureflags.config import with_base_url, with_events_url
@@ -7,20 +8,21 @@
 
 
 def main():
-    log.debug("Starting example")
+    log.setLevel(logging.INFO)
+    log.info("Starting example")
     api_key = "Your API Key"
     client = CfClient(api_key)
     # Don't continue until all flags and groups have been loaded into the cache.
-    log.debug("Waiting to load all flags and groups before proceeding")
+    log.info("Waiting to load all flags and groups before proceeding")
     client.wait_for_initialization()
 
     #  If required you can check the initialized status of the Client at anytime
-    log.debug("Client is_initialized status is %s", client.is_initialized())
+    log.info("Client is_initialized status is %s", client.is_initialized())
     target = Target(identifier='harness')
 
     while True:
         result = client.bool_variation('identifier_of_your_bool_flag', target, False)
-        log.debug("Result %s", result)
+        log.info("Result %s", result)
         time.sleep(10)
 
 
diff --git a/featureflags/__init__.py b/featureflags/__init__.py
@@ -2,4 +2,4 @@
 
 __author__ = """Enver Bisevac"""
 __email__ = "enver.bisevac@harness.io"
-__version__ = '1.2.4'
+__version__ = '1.2.5'
diff --git a/featureflags/analytics.py b/featureflags/analytics.py
@@ -33,7 +33,7 @@
 VARIATION_VALUE_ATTRIBUTE = 'variationValue'
 TARGET_ATTRIBUTE = 'target'
 SDK_VERSION_ATTRIBUTE = 'SDK_VERSION'
-SDK_VERSION = '1.2.4'
+SDK_VERSION = '1.2.5'
 SDK_TYPE_ATTRIBUTE = 'SDK_TYPE'
 SDK_TYPE = 'server'
 SDK_LANGUAGE_ATTRIBUTE = 'SDK_LANGUAGE'
diff --git a/featureflags/repository.py b/featureflags/repository.py
@@ -82,7 +82,8 @@ def __init__(self, cache: Cache, store: Store = None) -> None:
         self.store = store
 
     def get_flag(self, identifier: str,
-                 cacheable: bool = None) -> Optional[FeatureConfig]:
+                 cacheable: bool = None, is_outdated_check=False) -> \
+            Optional[FeatureConfig]:
         flag_key = format_flag_key(identifier)
         try:
             flag = self.cache.get(flag_key)
@@ -96,11 +97,15 @@ def get_flag(self, identifier: str,
                     log.debug("set flag to the cache %s", identifier)
                     self.cache.set(flag_key, flag)
                 return flag
-        log.warning("flag not found %s", identifier)
+        # If we are checking if a flag is outdated, it might not be in the
+        # cache to start with, so don't log a warning here
+        if not is_outdated_check:
+            log.warning("flag not found %s", identifier)
         return None
 
     def get_segment(self, identifier: str,
-                    cacheable: bool = None) -> Optional[Segment]:
+                    cacheable: bool = None, is_outdated_check=False) -> \
+            Optional[Segment]:
         segment_key = format_segment_key(identifier)
         try:
             segment = self.cache.get(segment_key)
@@ -114,7 +119,10 @@ def get_segment(self, identifier: str,
                     log.debug("set segment to the cache %s", identifier)
                     self.cache.set(segment_key, segment)
                 return segment
-        log.warning("segment not found %s", identifier)
+        # If we are checking if a segment is outdated, it might not be in the
+        # cache to start with, so don't log a warning here
+        if not is_outdated_check:
+            log.warning("segment not found %s", identifier)
         return None
 
     def set_flag(self, flag: FeatureConfig) -> None:
@@ -197,7 +205,8 @@ def close(self) -> None:
 
     def is_flag_outdated(self, identifier: str,
                          new_config: FeatureConfig) -> bool:
-        flag = self.get_flag(identifier, cacheable=False)
+        flag = self.get_flag(identifier, cacheable=False,
+                             is_outdated_check=True)
         if flag and not isinstance(flag.version, Unset) and \
                 not isinstance(new_config, Unset) and \
                 not isinstance(new_config.version, Unset):
@@ -206,7 +215,8 @@ def is_flag_outdated(self, identifier: str,
 
     def is_segment_outdated(self, identifier: str,
                             new_segment: Segment) -> bool:
-        segment = self.get_segment(identifier, cacheable=False)
+        segment = self.get_segment(identifier, cacheable=False,
+                                   is_outdated_check=True)
         if segment and not isinstance(segment.version, Unset) and \
                 not isinstance(new_segment, Unset) and \
                 not isinstance(new_segment.version, Unset):
diff --git a/setup.cfg b/setup.cfg
@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 1.2.4
+current_version = 1.2.5
 commit = True
 tag = True
 
diff --git a/setup.py b/setup.py
@@ -57,6 +57,6 @@
     test_suite="tests",
     tests_require=test_requirements,
     url="https://github.com/harness/ff-python-server-sdk",
-    version='1.2.4',
+    version='1.2.5',
     zip_safe=False,
 )
