BUG/MINOR: fix nil pointer in refreshCerts

hdurand0710 · hdurand0710 · commit ddf90905667f · 2024-05-15T16:27:56.000+02:00
If the certificate file exists, but is not in use, crt is nil and instance.Reload panics
panic: runtime error: invalid memory address or nil pointer dereference
diff --git a/pkg/haproxy/certs/main.go b/pkg/haproxy/certs/main.go
@@ -199,7 +199,7 @@ func refreshCerts(certs map[string]*cert, certDir string) (removed bool) {
 			logger.Error(os.Remove(path.Join(certDir, filename)))
 			delete(certs, certName)
 			removed = true
-			logger.Debugf("secret %s removed, reload required", crt.name)
+			logger.Debugf("secret %s removed, reload required", certName)
 		}
 	}
 	return

Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,7 @@ func refreshCerts(certs map[string]*cert, certDir string) (removed bool) {`
`199`	`199`	`logger.Error(os.Remove(path.Join(certDir, filename)))`
`200`	`200`	`delete(certs, certName)`
`201`	`201`	`removed = true`
`202`		`- logger.Debugf("secret %s removed, reload required", crt.name)`
	`202`	`+ logger.Debugf("secret %s removed, reload required", certName)`
`203`	`203`	`}`
`204`	`204`	`}`
`205`	`205`	`return`