BUG/MINOR: remove backend cfgSnippet state when backend is deleted

Author: Mo3m3n

controller/annotations/cfgSnippet.go

@@ -21,6 +21,14 @@ type cfgData struct {
 	updated []string
 }
 
+// cfgSnippet is a particular type of config that is not
+// handled by the upstram library haproxytech/client-native.
+// Which means there is no client-native models to
+// store, exchange and query cfgSnippet Data. Thus this logic
+// is directly handled by Ingress Controller in this package.
+//
+// The code in this file need to be rewritten to avoid init,
+// global variables and rather expose a clean interface.
 var cfgSnippet struct {
 	global    *cfgData
 	frontends map[string]*cfgData
@@ -137,3 +145,10 @@ func UpdateBackendCfgSnippet(api api.HAProxyClient, backend string) (updated []s
 	cfgSnippet.backends[backend] = data
 	return
 }
+
+func RemoveBackendCfgSnippet(backend string) {
+	if cfgSnippet.backends == nil {
+		return
+	}
+	delete(cfgSnippet.backends, backend)
+}

controller/handler/refresh.go

@@ -58,6 +58,7 @@ func (h Refresh) clearBackends(api api.HAProxyClient, cfg *config.ControllerCfg)
 			if err := api.BackendDelete(backend.Name); err != nil {
 				logger.Panic(err)
 			}
+			annotations.RemoveBackendCfgSnippet(backend.Name)
 		}
 	}
 }