BUG/MINOR: fixes podprefix test in maxconn calculation after names changed with Helm naming adoption.

With previous naming of kubernetes resources, no collision could happen with :

   if !strings.HasPrefix(meta.Name, podPrefix) {...}

But after Helm naming adoption, we have default backend pod named "haproxy-kubernetes-ingress-default-backend-xxxxxxxxx-xxxxx" and ingress controller named "haproxy-kubernetes-ingress-xxxxxxxxxx-xxxxx" which results in podprefix = haproxy-kubernetes-ingress and both pods passing the test.

Author: ivanmatmati

controller/kubernetes.go

@@ -16,7 +16,6 @@ package controller
 
 import (
 	"errors"
-	"strings"
 	"time"
 
 	corev1 "k8s.io/api/core/v1"
@@ -749,15 +748,15 @@ func (k *K8s) EventPods(namespace, podPrefix string, resyncPeriod time.Duration,
 		cache.ResourceEventHandlerFuncs{
 			AddFunc: func(obj interface{}) {
 				meta := obj.(*corev1.Pod).ObjectMeta
-				if !strings.HasPrefix(meta.Name, podPrefix) {
+				if utils.GetPodPrefix(meta.Name) != podPrefix {
 					return
 				}
 				eventChan <- SyncDataEvent{SyncType: POD, Namespace: meta.Namespace, Data: store.PodEvent{Created: true}}
 			},
 			DeleteFunc: func(obj interface{}) {
 				meta := obj.(*corev1.Pod).ObjectMeta
 
-				if !strings.HasPrefix(meta.Name, podPrefix) {
+				if utils.GetPodPrefix(meta.Name) != podPrefix {
 					return
 				}
 				eventChan <- SyncDataEvent{SyncType: POD, Namespace: meta.Namespace, Data: store.PodEvent{}}