CLEANUP/MINOR: ci: reduce number of artifacts in ci

Author: oktalz

.gitlab/diff.yml

@@ -23,7 +23,7 @@ diff:
     - test -z "$(git ls-files --others --exclude-standard 2> /dev/null)" || exit "Documentation created untracked files, cannot proceed"
     - junit-report add --status=ok --file=diff --message="Diff is clean" --description="Check for uncommitted changes in the repository"
   artifacts:
-    when: always
+    when: on_failure
     paths:
       - junit-report.xml
     reports:
@@ -59,7 +59,7 @@ check-large-files:
         junit-report add --status=ok --file=large-files --message="commit clean" --description="No large files found in the latest commit."
       fi
   artifacts:
-    when: always
+    when: on_failure
     paths:
       - junit-report.xml
     reports:

.gitlab/lint.yml

@@ -20,7 +20,7 @@ tidy:
         junit-report add --status=failed --message="go mod tidy not executed" --description="$(git diff)"
       fi
   artifacts:
-    when: always
+    when: on_failure
     paths:
       - junit-report.xml
     reports:
@@ -49,7 +49,7 @@ format:
         junit-report add --status=failed --message="go code not formatted" --description="$(git diff)"
       fi
   artifacts:
-    when: always
+    when: on_failure
     paths:
       - junit-report.xml
     reports:
@@ -75,7 +75,7 @@ lint:
         junit-report add --status=failed --message="git diff is not clean" --description="$(git diff)"
       fi
   artifacts:
-    when: always
+    when: on_failure
     paths:
       - junit-report.xml
     reports:
@@ -86,9 +86,15 @@ commit-policy:
   rules:
     - if: $CI_PIPELINE_SOURCE == 'merge_request_event'
   image:
-    name: $CI_REGISTRY_GO/commit-check:5.2.0
+    name: $CI_REGISTRY_GO/commit-check:5.4.0
     entrypoint: [""]
   tags:
     - go
   script:
       - /check
+  artifacts:
+    when: on_failure
+    paths:
+      - junit-report.xml
+    reports:
+      junit: junit-report.xml

.gitlab/security.yml

@@ -21,7 +21,7 @@ license:
         junit-report add --status=failed --message="licenses errors" --description="$(task licenses 2>&1)"
       fi
   artifacts:
-    when: always
+    when: on_failure
     paths:
       - junit-report.xml
     reports:
@@ -49,7 +49,7 @@ govulncheck:
         junit-report add --status=failed --message="vulnerabilities detected" --description="$(task govulncheck 2>&1)"
       fi
   artifacts:
-    when: always
+    when: on_failure
     paths:
       - junit-report.xml
     reports:

taskfile/.tools.yml

@@ -13,7 +13,7 @@ vars:
   CONTROLLER_GEN_URL: sigs.k8s.io/controller-tools/cmd/controller-gen
 
   CHECK_COMMIT_NAME: check-commit
-  CHECK_COMMIT_VERSION: v5.3.0
+  CHECK_COMMIT_VERSION: v5.4.0
   CHECK_COMMIT_URL: github.com/haproxytech/check-commit/v5
 
   BETTERALIGN_NAME: betteralign